New issue
Advanced search Search tips

Issue 919605 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
jbudorick@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Protect against mistakes using assert_called_once() and assert_not_called() (for all of chromium)

Project Member Reported by ntfschr@chromium.org, Jan 7 
See issue 878777 for background (but that issue is catapult-only).

The same issue is relevant for the rest of chromium (and other repos) because //third_party/pymock is a bit outdated.

Ideal solution would be to upgrade third_party/pymock. A presubmit might be reasonable, but it's not clear which python files use third_party/pymock (and therefore are subject to the presubmit).

Comment 1 by jbudorick@chromium.org, Jan 7 

I think the better solution is to actually use vpython's pymock wheel and remove //third_party/pymock.

Comment 2 by ntfschr@chromium.org, Jan 7 

What is "vpython's pymock wheel?"

Comment 4 by ntfschr@chromium.org, Jan 8 

Thanks for the pointers. Sent http://crrev/i/775560 for some downstream cleanups.

Seems like we would want to eventually clean up all instances of host_paths.PYMOCK_PATH (such as [1])?

[1] https://cs.chromium.org/chromium/src/build/android/list_class_verification_failures_test.py?l=16&rcl=bceb9ca5e3a930ea2020b50616cb1eb3218baea1

Comment 5 by jbudorick@google.com, Jan 8 

Yep.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/0974922653e3b17cf8a0878242466c280d85bb6b

commit 0974922653e3b17cf8a0878242466c280d85bb6b
Author: Nate Fischer <ntfschr@google.com>
Date: Fri Jan 11 02:19:29 2019

Comment 7 by agrieve@chromium.org, Jan 14

Status: Available (was: Untriaged)
►

Sign in to add a comment