Issue metadata
Sign in to add a comment
|
5.9%-83.8% regression in xr.browsing.wpr.static at 616323:620038 |
||||||||||||||||||||||||||
Issue descriptionBisect points to https://chromium-review.googlesource.com/c/1357306 as the culprit. Not sure if R8 is expected to result in higher memory usage, but if so, just close as wontfix.
,
Jan 7
,
Jan 7
This is surprising, but definitely possible. Are there any more details about this benchmark so I can get an idea what R8 is doing wrong?
,
Jan 7
All the benchmark is doing is loading some WPR archives of some popular sites (Google, Youtube, etc.) in the VR browser and measuring how much memory that takes. It's essentially a copy of the standard memory.top_10_mobile benchmark, but in VR. Unfortunately, it looks like the affected metric just reports 0 for that particular benchmark, so I can't check whether this is a VR-specific issue or a general Chrome one.
,
Jan 7
This regression is in the renderer process and GPU process. However, there is also a larger improvement in this metric for the browser process, which brings the all_processes benchmark to an improvement. This is (I believe) caused by R8 making public builds 1 dex file again. In multidex experiments (https://docs.google.com/document/d/1EJR7cryCOxVW9G_r7_XnwscGP6FLU1UjhVNQROrJPHM/edit?usp=sharing), it was shown that going to multidex will improve GPU and renderer PSS, while it would hurt browser PSS. We had to go with multidex a few months ago on public builds because we ran out of method count, but now with R8 we are under the method count limit again. Therefore, we are no longer multidexed, and are therefore no longer paying the cost in the browser process, and are no longer getting the benefits in the GPU and renderer process. |
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jan 7