New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 919554 link

Starred by 1 user
Status: Assigned
Owner:
chanli@chromium.org
Cc:
lijeffrey@chromium.org
█ robert...@chromium.org
chanli@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] AssertionError: FlakeSwarmingTaskOutput.error: expected type SwarmingTaskError, but got dict

Project Member Reported by chanli@chromium.org, Jan 7 
Error reporting: https://pantheon.corp.google.com/errors/COCK4bfYlKfD9AE?time=P30D&project=findit-for-me

Stack trace:
AssertionError: FlakeSwarmingTaskOutput.error: expected type SwarmingTaskError, but got dict
at __setattr__ (/base/data/home/apps/s~findit-for-me/waterfall-backend:19816-d68fd59.415168806055661834/libs/structured_object.py:161)
at __init__ (/base/data/home/apps/s~findit-for-me/waterfall-backend:19816-d68fd59.415168806055661834/libs/structured_object.py:144)
at _ParseFlakeSwarmingTaskOutput (/base/data/home/apps/s~findit-for-me/waterfall-backend:19816-d68fd59.415168806055661834/services/flake_failure/flake_swarming.py:70)
at OnSwarmingTaskTimeout (/base/data/home/apps/s~findit-for-me/waterfall-backend:19816-d68fd59.415168806055661834/services/flake_failure/flake_swarming.py:90)
at OnTimeout (/base/data/home/apps/s~findit-for-me/waterfall-backend:19816-d68fd59.415168806055661834/pipelines/flake_failure/run_flake_swarming_task_pipeline.py:58)
at callback (/base/data/home/apps/s~findit-for-me/waterfall-backend:19816-d68fd59.415168806055661834/gae_libs/pipelines.py:436)


Looks like the issue is related to RunFlakeSwarmingTaskPipeline

Comment 1 by liaoyuke@chromium.org, Jan 7 

I think this is the authentication issue that was blocking the deployment, stgao@ is on the fix.

Comment 2 by liaoyuke@chromium.org, Jan 7 

Though the pipeline should properly surface the root cause instead of swallowing the exception.

Comment 3 by lijeffrey@chromium.org, Jan 7 

This should be an easy/tiny change, as I believe the type for error being passed in OnSwarmingTaskError is a dict, which actually needs to be converted to SwarmingTaskError (which is the dto version) before saving.

In any case this isn't the root cause for the authentication issue, as by the time this exception occurred the authentication issue has already happened.

Comment 4 by chanli@chromium.org, Jan 7 

So this is a bug that got revealed by the authentication issue.
►

Sign in to add a comment