New issue
Advanced search Search tips

Issue 919503 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocked on:
issue 923564
issue 900677



Sign in to add a comment

Migrate generate_legacy_perf_dashboard_json script to use Histograms api

Project Member Reported by jmad...@chromium.org, Jan 7

Issue description

This script uses the old dashboard format. It will eventually need to be switched to use the new Histograms format. This issue is to track this task. Mentioned on  issue 900677 :

"We have a nice library so you don't have to think about the json structure:
https://github.com/catapult-project/catapult/blob/master/tracing/tracing/value/histogram_set.py
Here's a doc to get started:
https://docs.google.com/document/d/1vWs1KOLDfv9YC8M_xfmHViwDxDC6wEWKjkQK1-nJmNs/edit

In HistogramSet, you'd add a Histogram named "score" with units=unitlessNumber and a Diagnostic named "stories" containing strings such as "DrawCallPerf_gl_render_to_texture_null". When those Histograms are uploaded to the chromeperf dashboard, it would add the data to a timeseries whose test path looks like master/bot/angle_perftests/score/DrawCallPerf_gl_render_to_texture_null. If necessary, please file a Speed>Dashboard bug to migrate the existing data from the old test paths to the new test paths."


 
Cc: -nednguyen@chromium.org nedngu...@google.com
Cc: -nedngu...@google.com crouleau@chromium.org
Cc: bsheedy@chromium.org
+Brian made a conversion script from legacy format to histogramset
There's actually two "legacy" formats, the one output by gtest-based perf tests (which I added the conversion script for https://cs.chromium.org/chromium/src/third_party/catapult/tracing/tracing/value/gtest_json_converter.py) and "legacy" output (which has an existing converter https://cs.chromium.org/chromium/src/third_party/catapult/tracing/tracing/value/legacy_json_converter.py).

I assume this refers to the latter?

Comment 5 by jmad...@chromium.org, Jan 18 (4 days ago)

Can this be merged into issue 923564 ?

Comment 6 by crouleau@chromium.org, Jan 18 (4 days ago)

Blockedon: 923564

Sign in to add a comment