In "Remote tabs" page of tab grid, "Close All" button and new tab button("+") are not useful thus should be hidden.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa751e0d21edd186e071d23658a31183dcd731a3 commit aa751e0d21edd186e071d23658a31183dcd731a3 Author: Yi Su <mrsuyi@chromium.org> Date: Wed Jan 09 08:37:13 2019 Use UIToolbar for toolbar in tabgrid. This CL re-implement the top and bottom toolbars in TabGrid based on UIToolbar for better dynamic type support. When accessibility font size is chosen, long pressing on the buttons in toolbars will show a built-in accessbility modal panel of UIToolbar. Bug: 893539, 919490 Change-Id: I53ebee9a9ad6e7b9997a001780dbe3c4f88a9308 Reviewed-on: https://chromium-review.googlesource.com/c/1397639 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#621078} [modify] https://crrev.com/aa751e0d21edd186e071d23658a31183dcd731a3/ios/chrome/browser/ui/tab_grid/tab_grid_bottom_toolbar.h [modify] https://crrev.com/aa751e0d21edd186e071d23658a31183dcd731a3/ios/chrome/browser/ui/tab_grid/tab_grid_bottom_toolbar.mm [modify] https://crrev.com/aa751e0d21edd186e071d23658a31183dcd731a3/ios/chrome/browser/ui/tab_grid/tab_grid_constants.h [modify] https://crrev.com/aa751e0d21edd186e071d23658a31183dcd731a3/ios/chrome/browser/ui/tab_grid/tab_grid_constants.mm [modify] https://crrev.com/aa751e0d21edd186e071d23658a31183dcd731a3/ios/chrome/browser/ui/tab_grid/tab_grid_new_tab_button.h [modify] https://crrev.com/aa751e0d21edd186e071d23658a31183dcd731a3/ios/chrome/browser/ui/tab_grid/tab_grid_new_tab_button.mm [modify] https://crrev.com/aa751e0d21edd186e071d23658a31183dcd731a3/ios/chrome/browser/ui/tab_grid/tab_grid_page_control.mm [modify] https://crrev.com/aa751e0d21edd186e071d23658a31183dcd731a3/ios/chrome/browser/ui/tab_grid/tab_grid_top_toolbar.h [modify] https://crrev.com/aa751e0d21edd186e071d23658a31183dcd731a3/ios/chrome/browser/ui/tab_grid/tab_grid_top_toolbar.mm [modify] https://crrev.com/aa751e0d21edd186e071d23658a31183dcd731a3/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm [modify] https://crrev.com/aa751e0d21edd186e071d23658a31183dcd731a3/ios/showcase/tab_grid/sc_toolbars_view_controller.mm
Why does the CL in comment#2 address this bug? Seems like it should address a bug related to accessibility.
Yes, but the implementation actually hides the new tab button in remote tabs for both bottom toolbar layout and floating button layout, since I already have another CL that removes the "Close All" button.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/099f8801d6270a7ef5daa52d3f2eb82c8390cad1 commit 099f8801d6270a7ef5daa52d3f2eb82c8390cad1 Author: Yi Su <mrsuyi@chromium.org> Date: Thu Jan 10 10:51:00 2019 Hide "Close All" and new tab buttons in remote page of tab grid. In remote tabs page of tab grid under horizontal compact X vertical regular screen size, the bottom toolbar shows "Close All" and new tab button in disabled state. This CL removes them from bottom toolbar. Bug: 919490 Change-Id: I267baef1b1a233224d312d060006f59566df4cf7 Reviewed-on: https://chromium-review.googlesource.com/c/1402800 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#621537} [modify] https://crrev.com/099f8801d6270a7ef5daa52d3f2eb82c8390cad1/ios/chrome/browser/ui/tab_grid/tab_grid_bottom_toolbar.h [modify] https://crrev.com/099f8801d6270a7ef5daa52d3f2eb82c8390cad1/ios/chrome/browser/ui/tab_grid/tab_grid_bottom_toolbar.mm [modify] https://crrev.com/099f8801d6270a7ef5daa52d3f2eb82c8390cad1/ios/chrome/browser/ui/tab_grid/tab_grid_new_tab_button.mm [modify] https://crrev.com/099f8801d6270a7ef5daa52d3f2eb82c8390cad1/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
Issue verified Version: Chrome Canary 73.0.3672.0 Device: iPhone 6 Plus iOS: 12.1.2 "Close All" button and new tab button("+") hidden https://drive.google.com/open?id=1V9Y3vyIaviCXTagBrOxSAYNBFImyWHYL
Comment 1 by pkl@chromium.org
, Jan 7