New issue
Advanced search Search tips

Issue 919483 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Passwords] Migrate PasswordManagerProxy to a Promise based API

Project Member Reported by jdoerrie@chromium.org, Jan 7 
Currently PasswordManagerProxy in the Settings WebUI uses a callback based API to get the results of async operations. This bug serves to track the effort to migrate this to a Promise based API, for example as done in https://crrev.com/c/1394592.

Once the extension API supports promises as well (see https://crbug.com/328932), a similar change should be applied to passwords_private.idl and associated code.

Comment 1 by jdoerrie@chromium.org, Jan 7

Labels: Hotlist-Refactoring
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abdeb5cd440164ab5e27645ab3b6731d3896fe6f

commit abdeb5cd440164ab5e27645ab3b6731d3896fe6f
Author: jdoerrie <jdoerrie@chromium.org>
Date: Mon Jan 07 18:37:32 2019

[Settings WebUI] Use Callback for Requesting Plaintext Password

This change modifies the passwords_private requestPlaintextPassword
extension function to return the password via a callback instead of
raising the onPlaintextPasswordRetrieved event.

Bug: 919483
Change-Id: I854899af375cb746ea278cd895ad72a34836cb37
Reviewed-on: https://chromium-review.googlesource.com/c/1394592
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620394}
[modify] https://crrev.com/abdeb5cd440164ab5e27645ab3b6731d3896fe6f/chrome/browser/android/password_ui_view_android.cc
[modify] https://crrev.com/abdeb5cd440164ab5e27645ab3b6731d3896fe6f/chrome/browser/android/password_ui_view_android.h
[modify] https://crrev.com/abdeb5cd440164ab5e27645ab3b6731d3896fe6f/chrome/browser/extensions/api/passwords_private/passwords_private_api.cc
[modify] https://crrev.com/abdeb5cd440164ab5e27645ab3b6731d3896fe6f/chrome/browser/extensions/api/passwords_private/passwords_private_api.h
[modify] https://crrev.com/abdeb5cd440164ab5e27645ab3b6731d3896fe6f/chrome/browser/extensions/api/passwords_private/passwords_private_apitest.cc
[modify] https://crrev.com/abdeb5cd440164ab5e27645ab3b6731d3896fe6f/chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h
[modify] https://crrev.com/abdeb5cd440164ab5e27645ab3b6731d3896fe6f/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc
[modify] https://crrev.com/abdeb5cd440164ab5e27645ab3b6731d3896fe6f/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h
[modify] https://crrev.com/abdeb5cd440164ab5e27645ab3b6731d3896fe6f/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl_unittest.cc
[modify] https://crrev.com/abdeb5cd440164ab5e27645ab3b6731d3896fe6f/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc
[modify] https://crrev.com/abdeb5cd440164ab5e27645ab3b6731d3896fe6f/chrome/browser/resources/settings/autofill_page/password_manager_proxy.js
[modify] https://crrev.com/abdeb5cd440164ab5e27645ab3b6731d3896fe6f/chrome/browser/resources/settings/autofill_page/passwords_section.js
[modify] https://crrev.com/abdeb5cd440164ab5e27645ab3b6731d3896fe6f/chrome/browser/resources/settings/autofill_page/show_password_behavior.js
[modify] https://crrev.com/abdeb5cd440164ab5e27645ab3b6731d3896fe6f/chrome/browser/ui/passwords/password_manager_presenter.cc
[modify] https://crrev.com/abdeb5cd440164ab5e27645ab3b6731d3896fe6f/chrome/browser/ui/passwords/password_manager_presenter.h
[modify] https://crrev.com/abdeb5cd440164ab5e27645ab3b6731d3896fe6f/chrome/browser/ui/passwords/password_ui_view.h
[modify] https://crrev.com/abdeb5cd440164ab5e27645ab3b6731d3896fe6f/chrome/browser/ui/passwords/password_ui_view_mock.cc
[modify] https://crrev.com/abdeb5cd440164ab5e27645ab3b6731d3896fe6f/chrome/browser/ui/passwords/password_ui_view_mock.h
[modify] https://crrev.com/abdeb5cd440164ab5e27645ab3b6731d3896fe6f/chrome/common/extensions/api/passwords_private.idl
[modify] https://crrev.com/abdeb5cd440164ab5e27645ab3b6731d3896fe6f/chrome/test/data/extensions/api_test/passwords_private/test.js
[modify] https://crrev.com/abdeb5cd440164ab5e27645ab3b6731d3896fe6f/chrome/test/data/webui/settings/passwords_and_autofill_fake_data.js
[modify] https://crrev.com/abdeb5cd440164ab5e27645ab3b6731d3896fe6f/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
[modify] https://crrev.com/abdeb5cd440164ab5e27645ab3b6731d3896fe6f/third_party/closure_compiler/externs/passwords_private.js
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3687e7ebec190d1348636d524a6968164b651fae

commit 3687e7ebec190d1348636d524a6968164b651fae
Author: jdoerrie <jdoerrie@chromium.org>
Date: Mon Jan 14 12:04:55 2019

[Settings WebUI] Autofill Page Test Clean Up

This change modifies TestPasswordManagerProxy to inherit from
TestBrowserProxy, moves it into its own file and moves the passwords
section tests inside the CrSettingsBrowserTest instead of being in a
separate browser test. Furthermore it merges autofill_browsertest.js
into the already exisiting autofill_page_test.js and
CrSettingsAutofillPageTest test suite.

Bug: 919483
Change-Id: I4a44cec6bf5db0e479c0f6064f3a9453fbadcf5e
Reviewed-on: https://chromium-review.googlesource.com/c/1398289
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622428}
[modify] https://crrev.com/3687e7ebec190d1348636d524a6968164b651fae/chrome/test/data/webui/BUILD.gn
[modify] https://crrev.com/3687e7ebec190d1348636d524a6968164b651fae/chrome/test/data/webui/settings/a11y/passwords_a11y_test.js
[delete] https://crrev.com/b5721fc683c9684d589f482e39e0ba21703cc608/chrome/test/data/webui/settings/autofill_browsertest.js
[modify] https://crrev.com/3687e7ebec190d1348636d524a6968164b651fae/chrome/test/data/webui/settings/autofill_page_test.js
[modify] https://crrev.com/3687e7ebec190d1348636d524a6968164b651fae/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/3687e7ebec190d1348636d524a6968164b651fae/chrome/test/data/webui/settings/passwords_and_autofill_fake_data.js
[rename] https://crrev.com/3687e7ebec190d1348636d524a6968164b651fae/chrome/test/data/webui/settings/passwords_section_test.js
[add] https://crrev.com/3687e7ebec190d1348636d524a6968164b651fae/chrome/test/data/webui/settings/test_password_manager_proxy.js
►

Sign in to add a comment