Issue metadata
Sign in to add a comment
|
11.5%-48.7% regression in v8.browsing_desktop at 619105:619140 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jan 7
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12d0b70d940000
,
Jan 7
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/12d0b70d940000 v8binding: Implement timers with IDL callback function of type Function by yukishiino@chromium.org https://chromium.googlesource.com/chromium/src/+/f95130edf1c94febbf0eac48f1808ad12edf75de v8-gc-latency-mark-compactor: 8.657 → 11.73 (+3.075) Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: None
,
Jan 10
,
Jan 10
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/802f3e8a34634b5efc133df62883734c3a30c3b2 commit 802f3e8a34634b5efc133df62883734c3a30c3b2 Author: Yuki Shiino <yukishiino@chromium.org> Date: Tue Jan 15 14:45:35 2019 v8binding: Collect timer's v8::Function in V8 Scavenger GC Makes it possible that V8 Scavenger GC collects the underlying V8 function of ScheduledAction. V8 Full GC can collect them anyway, but this patch makes it possible for V8 Scavenger GC, too, in order to mitigate the memory regression. Bug: 919474, 919475 Change-Id: Ifff6ae1d6698f8bced834e82a717557dba130b64 Reviewed-on: https://chromium-review.googlesource.com/c/1404900 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#622850} [modify] https://crrev.com/802f3e8a34634b5efc133df62883734c3a30c3b2/third_party/blink/renderer/bindings/core/v8/scheduled_action.cc [modify] https://crrev.com/802f3e8a34634b5efc133df62883734c3a30c3b2/third_party/blink/renderer/platform/bindings/callback_function_base.h
,
Jan 17
(5 days ago)
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jan 7