New issue
Advanced search Search tips

Issue 919475 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

11.5%-48.7% regression in v8.browsing_desktop at 619105:619140

Project Member Reported by jgruber@chromium.org, Jan 7

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=919475

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=0187fdbc96d53e7b211974e319aa59e5d93bb523de4a07cd9e283ca5267d92b4


Bot(s) for this bug's original alert(s):

Win 7 Nvidia GPU Perf
Win 7 Perf
linux-perf

v8.browsing_desktop - Benchmark documentation link:
  None
Cc: yukishiino@chromium.org
Owner: yukishiino@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/12d0b70d940000

v8binding: Implement timers with IDL callback function of type Function by yukishiino@chromium.org
https://chromium.googlesource.com/chromium/src/+/f95130edf1c94febbf0eac48f1808ad12edf75de
v8-gc-latency-mark-compactor: 8.657 → 11.73 (+3.075)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  None
Cc: haraken@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/802f3e8a34634b5efc133df62883734c3a30c3b2

commit 802f3e8a34634b5efc133df62883734c3a30c3b2
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Tue Jan 15 14:45:35 2019

v8binding: Collect timer's v8::Function in V8 Scavenger GC

Makes it possible that V8 Scavenger GC collects the underlying V8
function of ScheduledAction.  V8 Full GC can collect them anyway,
but this patch makes it possible for V8 Scavenger GC, too, in order
to mitigate the memory regression.

Bug: 919474,  919475 
Change-Id: Ifff6ae1d6698f8bced834e82a717557dba130b64
Reviewed-on: https://chromium-review.googlesource.com/c/1404900
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622850}
[modify] https://crrev.com/802f3e8a34634b5efc133df62883734c3a30c3b2/third_party/blink/renderer/bindings/core/v8/scheduled_action.cc
[modify] https://crrev.com/802f3e8a34634b5efc133df62883734c3a30c3b2/third_party/blink/renderer/platform/bindings/callback_function_base.h

Comment 7 by yukishiino@chromium.org, Jan 17 (5 days ago)

Status: Fixed (was: Started)

Sign in to add a comment