New issue
Advanced search Search tips

Issue 919468 link

Starred by 1 user
Status: Fixed
Owner:
pfeldman@chromium.org
Closed: Jan 8
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Misalignment of 'Lat / Long' texts are observed with their text-boxes under 'Geolocations' section.

Project Member Reported by cdin...@virtusa.com, Jan 7 
Chrome Version: 73.0.3664.0 (Official Build) Revision	ea459cba924d6aba847571f1d700f7f002c4b3c6-refs/branch-heads/3664@{#1} (32/64-bit)
OS: Windows (7, 8, 8.1, 10), Mac(10.13.1, 10.13.6, 10.14.3) & Linux(14.04 LTS).

What steps will reproduce the problem?
1. Launch Chrome, go to NTP and open 'DevTools' window.
2. Press 'F1' key to open 'Settings' page and go to 'Geolocations' section.
3. Click on 'Add location' button to open the Add location form and observe.

Actual: 'Lat / Long' texts are misaligned with text-boxes.
Expected: 'Lat / Long' texts should aligned properly with text-boxes.

This is a regression issue, broken in M-73 series, below is manual regression range:

Good build: 73.0.3637.0 (Revision: 615357)
Bad build: 73.0.3638.0 (Revision: 615716)

Chromium bisect:
  https://chromium.googlesource.com/chromium/src/+log/e3034da0612ec7d327515331889e2d1579eaf818..90c853aae4b8e1e538f6b486f0a0a30fa1c655dc

Suspecting: https://chromium.googlesource.com/chromium/src/+/90c853aae4b8e1e538f6b486f0a0a30fa1c655dc

@pfeldman: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE: 
1. Provided suspect through 'Chromium bisect' script because unable to perform bisect using 'per-revision' bisect script.
2. Tried performing 'per revision' bisect on multiple Windows and Mac machines but unable to perform the same since getting "Error running the gsutil command: AccessDeniedException" error.

Kindly review the attached screen-cast for reference.

Thank you.
Geolocation_screenshot.png
21.1 KB View Download
Actual behavior.mp4
942 KB View Download
Expected behavior.mp4
396 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5512bbcd16d51cc4bf8bbf47ae3e168586cf35c3

commit 5512bbcd16d51cc4bf8bbf47ae3e168586cf35c3
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Mon Jan 07 22:45:45 2019

DevTools: align geolocations entry fields.

Bug:  919468 
Change-Id: I8f7e17b5dce3b9bf8b6b3a2fb4b37d8736351795
Reviewed-on: https://chromium-review.googlesource.com/c/1398394
Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620512}
[modify] https://crrev.com/5512bbcd16d51cc4bf8bbf47ae3e168586cf35c3/third_party/blink/renderer/devtools/front_end/emulation/GeolocationsSettingsTab.js

Comment 2 by dchau...@etouch.net, Jan 8

Labels: TE-Verified-M73 TE-Verified-73.0.3665.0
Update:
Rechecked this issue on Windows (7, 8, 8.1, 10), Mac(10.13.1, 10.13.6, 10.14.3) & Linux(14.04 LTS) machines using latest Canary #73.0.3665.0 and issue is fixed. Hence adding TE-Verified labels.

Please refer the attached screen-cast for reference.

Thank you.
Fixed behavior.mp4
381 KB View Download

Comment 3 by pfeldman@chromium.org, Jan 8

Status: Fixed (was: Assigned)
►

Sign in to add a comment