New issue
Advanced search Search tips

Issue 919448 link

Starred by 1 user
Status: Fixed
Owner:
alph@chromium.org
Closed: Jan 8
Cc:
nyerramilli@chromium.org
pbomm...@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unable to stop recording in 'Memory' section of DevTools.

Project Member Reported by dipt...@virtusa.com, Jan 7 
Chrome Version: 73.0.3664.0 Revision ea459cba924d6aba847571f1d700f7f002c4b3c6-refs/branch-heads/3664@{#1}(32/64 bit)
OS: Windows(7,8,8.1,10), Linux(14.04 LTS) and Mac(10.13.1, 10.13.6, 10.14.3) 

What steps will reproduce the problem?
(1) Launch chrome, open dev tools window and navigate to 'Memory' section.
(2) Select 'Allocation instrumentation on timeline' radio button then click on 'Record allocation stacks' checkbox.
(3) Now Record some activity and click on Stop button, Observe. 

Actual: Unable to stop recording in Memory section.

Expected: Should be able to stop recording in Memory section.

This is a regression issue, broken in 'M73', will soon update the other info:

Good Build:73.0.3643.0
Bad Build: 73.0.3644.0
Actual_Record.mp4
1.1 MB View Download
Expected_Record.mp4
404 KB View Download

Comment 1 by dipt...@virtusa.com, Jan 7

Labels: hasbisect
Owner: alph@chromium.org
Status: Assigned (was: Unconfirmed)
Chromium Bisect:
https://chromium.googlesource.com/chromium/src/+log/157d9c65bb9a5b9c5fb0fb37543830679e1846d4..1887ffa2c51f39e928a4448476214aab8975fcd8

Suspect: https://chromium.googlesource.com/chromium/src/+/f947a35ccacafacb0ec501868662f8d7b77f14d0

@alph: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly refer the attached screen-cast.

Note: Tried bisecting using per revision bisect on multiple Windows and Mac machines but getting errors hence, providing chromium bisect.
 
Thank You.

Comment 2 by nyerramilli@chromium.org, Jan 7

Cc: pbomm...@chromium.org
Labels: ReleaseBlock-Stable
marking as RBS, please change if required

Comment 3 by alph@chromium.org, Jan 7

Labels: Needs-Feedback
Cannot repro it.
Could you please provide the crash stack partially visible in the recorded screencast.

Comment 4 by alph@chromium.org, Jan 7

Labels: -Needs-Feedback
I managed to repro it. Thanks.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c503f9bba7a4d1f95c4c019fe618e8f404d29ad

commit 2c503f9bba7a4d1f95c4c019fe618e8f404d29ad
Author: Alexei Filippov <alph@chromium.org>
Date: Tue Jan 08 18:54:56 2019

DevTools: Fix parsing heap snapshot trace_tree field.

BUG= 919448 

Change-Id: If5351324ebbaf36516082d80679fbf0e3647387b
Reviewed-on: https://chromium-review.googlesource.com/c/1399508
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620819}
[modify] https://crrev.com/2c503f9bba7a4d1f95c4c019fe618e8f404d29ad/third_party/blink/renderer/devtools/front_end/heap_profiler_test_runner/HeapProfilerTestRunner.js
[modify] https://crrev.com/2c503f9bba7a4d1f95c4c019fe618e8f404d29ad/third_party/blink/renderer/devtools/front_end/heap_snapshot_worker/HeapSnapshotLoader.js

Comment 6 by alph@chromium.org, Jan 8

Status: Fixed (was: Assigned)
►

Sign in to add a comment