Regression : Media controls are not accessible when clicked on option label. |
|||
Issue descriptionChrome Version : 73.0.3664.0 (Official Build) ea459cba924d6aba847571f1d700f7f002c4b3c6-refs/branch-heads/3664@{#1} 32/64 bit OS : Mac(10.13.6, 10.13.1, 10.14.3), Windows(7,8,10), Linux(14.04 LTS) Test URL : https://mounirlamouri.github.io/sandbox/media/dynamic-controls.html What steps will reproduce the problem? 1. Launch chrome and navigate to above test URL. 2. Click on 3 dot menu icon in video and click on the label of any option in the list. 3. Observe. Actual Result : Media controls in the list are not accessible when clicked on option label. Expected Result : All media controls in the list should be accessible even when clicked on option label. This is a regression issue broken in M-73 and below is the bisect information: Good Build : 73.0.3661.0 (Revision : 619955) Bad Build : 73.0.3662.0 (Revision : 620151) Chromium bisect URL: https://chromium.googlesource.com/chromium/src/+log/a2937235a5c620df05843570602b9a40c1c84b4e..ce9b54be312c4ebc1872989627a2f53d36503cf1 Suspecting: r620108 ? @CJ DiMeglio : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note : 1. Unable to provide bisect using per-revision script as it shows an error message. 2. Tried on other machines but still getting the same error again. 3. Hence provided suspect through 'Chromium bisect'. 4. Issue can also be reproduced on following test URL's -- - https://www.quirksmode.org/html5/tests/video.html - http://googlechrome.github.io/samples/picture-in-picture Thank you..!
,
Jan 7
(currently trying to repro on windows as well, but machine is out of date, so may take a bit).
,
Jan 8
Hi @lethalantidote, Retested above issue in latest Canary #73.0.3665.0 on Linux (14.04 LTS) OS and i can reproduce this issue consistently. No additional configuration is required to reproduce this issue. Thanks..
,
Jan 9
A coworker was able to reproduce this on their machine, and we have a fix: https://chromium-review.googlesource.com/c/chromium/src/+/1401454 But due to the nature of the fix, we must wait until all the other aria attributes are updated. This may take a few weeks, so in the mean time, I will land this quick fix CL, which will cause the aria labels to repeat again, but at least we can use the menu in the meantime: https://chromium-review.googlesource.com/c/chromium/src/+/1401842
,
Jan 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae96bb1b3036a26c3709b73c5c26d5c04e0b6b10 commit ae96bb1b3036a26c3709b73c5c26d5c04e0b6b10 Author: CJ DiMeglio <lethalantidote@chromium.org> Date: Wed Jan 09 02:26:45 2019 Allow overflow container to be tab selectable again. Because we had given the overflow container element a tab index of -1, it was causing the overflow menu to close on any interaction. Originally we had set the tab index to -1 to take care of some duplication issue in the aria readback, but we have found another solution for that here: https://chromium-review.googlesource.com/c/chromium/src/+/1401454 Bug: 919446 Change-Id: I9fdd794bc131bcd16d04d4fad95bdd366d7f6941 Reviewed-on: https://chromium-review.googlesource.com/c/1401842 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#621004} [modify] https://crrev.com/ae96bb1b3036a26c3709b73c5c26d5c04e0b6b10/third_party/blink/renderer/modules/media_controls/elements/media_control_input_element.cc
,
Jan 10
--------- Update : --------- Verified above issue in latest Canary build #73.0.3667.0 on Mac(10.13.1, 10.13.6, 10.14.3), Windows(7,8,8.1,10) & Linux(14.04 LTS) OS and the issue is fixed. Kindly review an attached screen-cast for reference. Thank you..! |
|||
►
Sign in to add a comment |
|||
Comment 1 by lethalantidote@chromium.org
, Jan 7