New issue
Advanced search Search tips

Issue 919443 link

Starred by 1 user
Status: Verified
Owner:
jazzhsu@chromium.org
Closed: Jan 10
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Overflow menu closes when trying to click and drag scroll-bar.

Project Member Reported by aim...@virtusa.com, Jan 7 
Chrome Version: 73.0.3664.0 (Official Build) ea459cba924d6aba847571f1d700f7f002c4b3c6-refs/branch-heads/3664@{#1}(32/64-bit).
 	
OS: Win(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.2) and Linux(14.04 LTS).

Test URL: https://mounirlamouri.github.io/sandbox/media/dynamic-controls.html
	       
What steps will reproduce the problem?
1. Launch chrome and navigate to the above URL.
2. Set Video width to '100'.
3. Click on 3-Dots and try to click on scroll bar.
4. Observe.

Actual Result: Overflow menu closes when trying to click and drag scroll-bar.
Expected Result: Overflow menu should not close when trying to click and drag scroll-bar.

This is a regression issue broken in M-73 and below is the per-revision-bisect-info:
Good Build : 73.0.3633.0(Revision:614502)
Bad Build : 73.0.3634.0(Revision:614909)

You are probably looking for a change made after 614554 (known good), but no later than 614555 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/1519a34eff922497f280e53a035e019e8f10b436..3fd190dee907661320a5bfc5963d615406fffd35

Suspect: https://chromium.googlesource.com/chromium/src/+/3fd190dee907661320a5bfc5963d615406fffd35

jazzhsu@: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: 
1. Issue is also seen on Dev build # 73.0.3642.0

Kindly refer the screen cast for reference

Thank You!
Actual Result.mp4
413 KB View Download
Expected Result.mp4
441 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56b980acf34bb9523a2e658433267ea716501103

commit 56b980acf34bb9523a2e658433267ea716501103
Author: Jazz Xu <jazzhsu@chromium.org>
Date: Wed Jan 09 20:42:31 2019

[Media Controls] Fix overflow menu close when clicking scrollbar

Bug is cause by chrome trying to find and focus on first focusable element
(in this case, the video element) when clicking scrollbar, which cause the
overflow menu lose focus and close itself. We fix the problem by making
popup menu focusable so that it won't lose focus when interacting with
scrollbar

Bug:  919443 
Change-Id: I7afdcc4ca2b2b6e4c9677f0d9bbeae0d504b351a
Reviewed-on: https://chromium-review.googlesource.com/c/1401362
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621296}
[modify] https://crrev.com/56b980acf34bb9523a2e658433267ea716501103/third_party/blink/renderer/modules/media_controls/elements/media_control_popup_menu_element.cc
[modify] https://crrev.com/56b980acf34bb9523a2e658433267ea716501103/third_party/blink/renderer/modules/media_controls/elements/media_control_popup_menu_element.h
[modify] https://crrev.com/56b980acf34bb9523a2e658433267ea716501103/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css

Comment 2 by aim...@virtusa.com, Jan 10

Labels: TE-Verified-M73 TE-Verified-73.0.3667.0
Update:

Retested the above issue on Win(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.2) and Linux(14.04 LTS) using latest Canary build #73.0.3667.0 and issue is fixed.

Now, Overflow menu does not close when trying to click and drag scroll-bar.

Kindly refer the screen cast for reference

Thank You!
Canary Behaviour.mp4
305 KB View Download

Comment 3 by jazzhsu@chromium.org, Jan 10

Status: Verified (was: Assigned)
►

Sign in to add a comment