New issue
Advanced search Search tips

Issue 919424 link

Starred by 1 user

Issue metadata

Status: Unconfirmed
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocked on:
issue 919420
issue 924020

Blocking:
issue 919414



Sign in to add a comment

Signed Exchange: Remove support for 1b2

Project Member Reported by kouhei@chromium.org, Jan 7

Issue description

Maintaining support for two versions is hard. We intend to remove support for 1b2 shortly after Chromium is capable of parsing new 1b3 format.
 
Cc: kinuko@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9007cf2bea672f700c14e63ee66df6d37d47e01f

commit 9007cf2bea672f700c14e63ee66df6d37d47e01f
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Wed Jan 09 08:23:24 2019

SignedExchange: Accept b3 magic strings

This CL will let Chromium accept the b3 version and its magic strings.
We will keep support for b2 for a very short period (1 week) for transition.

Bug:  919417 , 919424
Change-Id: I42d32b7c98652d92dcba0eb71395d937d3ad3fff
Reviewed-on: https://chromium-review.googlesource.com/c/1401825
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621075}
[modify] https://crrev.com/9007cf2bea672f700c14e63ee66df6d37d47e01f/content/browser/web_package/signed_exchange_consts.h
[modify] https://crrev.com/9007cf2bea672f700c14e63ee66df6d37d47e01f/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/9007cf2bea672f700c14e63ee66df6d37d47e01f/content/browser/web_package/signed_exchange_prologue.cc
[modify] https://crrev.com/9007cf2bea672f700c14e63ee66df6d37d47e01f/content/browser/web_package/signed_exchange_prologue_unittest.cc
[modify] https://crrev.com/9007cf2bea672f700c14e63ee66df6d37d47e01f/content/browser/web_package/signed_exchange_utils.cc
[modify] https://crrev.com/9007cf2bea672f700c14e63ee66df6d37d47e01f/content/browser/web_package/signed_exchange_utils_unittest.cc

Comment 3 by kouhei@chromium.org, Jan 17 (6 days ago)

from horo@: we need to keep a 1b2 test for fallback testing.

Comment 4 by ksakamoto@chromium.org, Yesterday (24 hours ago)

Blockedon: 924020

Sign in to add a comment