ChromiumOS ASAN Release builder does not create test_fonts/.uuid |
|||||
Issue descriptionhttps://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8925212410848208928/+/steps/compile_confirm_no-op/0/stdout """ ninja explain: output test_fonts/.uuid doesn't exist ninja explain: fontconfig_caches/df1acc8c-39d5-4a8b-8507-b1a7396ac3ac-le64.cache-7 is dirty ninja explain: test_fonts/.uuid is dirty """ This makes build unhealthy. thomasanderson, can I ask you to take a look? The file seems to be erased in base::SetUpFontconfig()
,
Jan 10
,
Jan 10
I'm unable to reproduce the issue with the gn args of the bot at the revision where it failed. Do you have repro steps?
,
Jan 10
I can reproduce like below. Second ninja invocation for test_fonts/.uuid should be no-op. tikuta@tikuta:~/chromium/src$ cat out/ChromiumOS_ASAN_Release/args.gn enable_ipc_fuzzer = true is_asan = true is_component_build = false is_debug = false is_lsan = true sanitizer_coverage_flags = "trace-pc-guard" strip_absolute_paths_from_debug_symbols = true target_os = "chromeos" use_goma = true v8_enable_verify_heap = true # goma_dir = "/b/swarming/w/ir/cache/goma/client" tikuta@tikuta:~/chromium/src$ ninja -C out/ChromiumOS_ASAN_Release/ test_fonts/.uuid ninja: Entering directory `out/ChromiumOS_ASAN_Release/' [1/1] Regenerating ninja files [799/799] ACTION //base/test:do_generate_fontconfig_caches(//build/toolchain/linux:clang_x64) tikuta@tikuta:~/chromium/src$ ninja -C out/ChromiumOS_ASAN_Release/ test_fonts/.uuid ninja: Entering directory `out/ChromiumOS_ASAN_Release/' [1/1] ACTION //base/test:do_generate_fontconfig_caches(//build/toolchain/linux:clang_x64)
,
Jan 10
thanks, I'm able to repro now and I think this is just a dependency issue. I'll upload a fix soon (I wasn't able to repro before because I was building the do_generate_fontconfig_caches target which has all the necessary dependencies)
,
Jan 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcc0fd9fc4cdcb05eb07a2efd2f083c88f1e31c6 commit dcc0fd9fc4cdcb05eb07a2efd2f083c88f1e31c6 Author: Tom Anderson <thomasanderson@chromium.org> Date: Fri Jan 11 19:54:39 2019 Fix dependency issue when building test_fonts/.uuid The copied test fonts are inputs to generate_fontconfig_caches, so must be listed in deps, not data_deps ( https://crbug.com/919422 ). generate_fontconfig_caches creates test_fonts/.uuid, but fontconfig deletes .uuid when there are no fonts [1], so if generate_fontconfig_caches runs before test_fonts are copied, .uuid will be deleted and the build will be dirty (and the cache file will be incorrect). [1] https://cs.chromium.org/chromium/src/third_party/fontconfig/src/src/fcdir.c?rcl=ba206df9b9a7ca300265f650842c1459ff7c634a&l=429 BUG= 919422 R=thakis CC=erikchen,tikuta Change-Id: I94057b8035510a122e379249f9f8c60c9e526a57 Reviewed-on: https://chromium-review.googlesource.com/c/1406228 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#622108} [modify] https://crrev.com/dcc0fd9fc4cdcb05eb07a2efd2f083c88f1e31c6/base/test/BUILD.gn
,
Jan 11
,
Jan 15
Thanks! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by tikuta@chromium.org
, Jan 7