New issue
Advanced search Search tips

Issue 919417 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 10
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 919420

Blocking:
issue 919414



Sign in to add a comment

Signed Exchange: Accept 1b3 content type and magic bytestrings

Project Member Reported by kouhei@chromium.org, Jan 7

Issue description

The 1b3 SXGs come with `v=b3` content-type param and new "1b3" magic bytestrings.
Chromium needs to support parsing them and accept the new format.
 
Blockedon: 919420
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9007cf2bea672f700c14e63ee66df6d37d47e01f

commit 9007cf2bea672f700c14e63ee66df6d37d47e01f
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Wed Jan 09 08:23:24 2019

SignedExchange: Accept b3 magic strings

This CL will let Chromium accept the b3 version and its magic strings.
We will keep support for b2 for a very short period (1 week) for transition.

Bug:  919417 , 919424
Change-Id: I42d32b7c98652d92dcba0eb71395d937d3ad3fff
Reviewed-on: https://chromium-review.googlesource.com/c/1401825
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621075}
[modify] https://crrev.com/9007cf2bea672f700c14e63ee66df6d37d47e01f/content/browser/web_package/signed_exchange_consts.h
[modify] https://crrev.com/9007cf2bea672f700c14e63ee66df6d37d47e01f/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/9007cf2bea672f700c14e63ee66df6d37d47e01f/content/browser/web_package/signed_exchange_prologue.cc
[modify] https://crrev.com/9007cf2bea672f700c14e63ee66df6d37d47e01f/content/browser/web_package/signed_exchange_prologue_unittest.cc
[modify] https://crrev.com/9007cf2bea672f700c14e63ee66df6d37d47e01f/content/browser/web_package/signed_exchange_utils.cc
[modify] https://crrev.com/9007cf2bea672f700c14e63ee66df6d37d47e01f/content/browser/web_package/signed_exchange_utils_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/460ebb5ca88dd84c8a63d8cb7c26b0e0db631333

commit 460ebb5ca88dd84c8a63d8cb7c26b0e0db631333
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Thu Jan 10 13:28:33 2019

SignedExchangeSignatureVerifier: Support b3 magic bytestring

This CL will let chromium accept signatures signed with
"Signed Exchange 1 b3" magic bytestring.

Bug:  919417 
Change-Id: If5c4fa6c65f8d0d6b367cb0d7ec5a16d42c6091e
Reviewed-on: https://chromium-review.googlesource.com/c/1404549
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621562}
[modify] https://crrev.com/460ebb5ca88dd84c8a63d8cb7c26b0e0db631333/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/460ebb5ca88dd84c8a63d8cb7c26b0e0db631333/content/browser/web_package/signed_exchange_signature_verifier.cc
[modify] https://crrev.com/460ebb5ca88dd84c8a63d8cb7c26b0e0db631333/content/browser/web_package/signed_exchange_signature_verifier.h
[modify] https://crrev.com/460ebb5ca88dd84c8a63d8cb7c26b0e0db631333/content/browser/web_package/signed_exchange_signature_verifier_unittest.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment