New issue
Advanced search Search tips

Issue 919414 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug


Sign in to add a comment

☂ Signed Exchange: Support SXG 1b3 implementation snapshot

Project Member Reported by kouhei@chromium.org, Jan 7

Issue description

Tracks Chromium effort of implementing https://github.com/WICG/webpackage/issues/350

See also https://github.com/WICG/webpackage/issues/362 for go tool impl.
 
Blockedon: 919417
Blockedon: 919420
Blockedon: 919424
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b48d800f43c97c277dfbe322365091454ee684d3

commit b48d800f43c97c277dfbe322365091454ee684d3
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Wed Jan 09 03:20:34 2019

SignedExchange: Verify if the response is cacheable by a shared cache

This implements the step 5 of [1]. Signed exchange is not valid if
response is not cacheable by a shared cache.

[1] https://wicg.github.io/webpackage/draft-yasskin-http-origin-signed-responses.html#cross-origin-trust

Bug: 919414
Change-Id: I2ceef3c0e3899ae1b9bbe1e0bb644b601732cbe0
Reviewed-on: https://chromium-review.googlesource.com/c/1400422
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621030}
[modify] https://crrev.com/b48d800f43c97c277dfbe322365091454ee684d3/content/browser/web_package/signed_exchange_envelope.cc
[modify] https://crrev.com/b48d800f43c97c277dfbe322365091454ee684d3/content/browser/web_package/signed_exchange_envelope_unittest.cc
[modify] https://crrev.com/b48d800f43c97c277dfbe322365091454ee684d3/third_party/blink/web_tests/external/wpt/signed-exchange/resources/generate-test-sxgs.sh
[add] https://crrev.com/b48d800f43c97c277dfbe322365091454ee684d3/third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg-noncacheable.sxg
[add] https://crrev.com/b48d800f43c97c277dfbe322365091454ee684d3/third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg-noncacheable.sxg.headers
[add] https://crrev.com/b48d800f43c97c277dfbe322365091454ee684d3/third_party/blink/web_tests/external/wpt/signed-exchange/sxg-noncacheable.tentative.html

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1921554699fc6d02c7565f128aab8c9ec7b3655

commit a1921554699fc6d02c7565f128aab8c9ec7b3655
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Thu Jan 10 05:52:36 2019

SignedExchangeCertificateChain: Remove |version| arg

This CL removes the |version| argument from
SignedExchangeCertificateChain::Parse().
The |version| argument no longer makes sense since the current Chromium
only supports parsing the b2/b3 format.

Bug: 919414
Change-Id: Iabd70f9cf0c52be72a9c6f455461531c75e5874f
Reviewed-on: https://chromium-review.googlesource.com/c/1404552
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621482}
[modify] https://crrev.com/a1921554699fc6d02c7565f128aab8c9ec7b3655/content/browser/web_package/signed_exchange_cert_fetcher.cc
[modify] https://crrev.com/a1921554699fc6d02c7565f128aab8c9ec7b3655/content/browser/web_package/signed_exchange_certificate_chain.cc
[modify] https://crrev.com/a1921554699fc6d02c7565f128aab8c9ec7b3655/content/browser/web_package/signed_exchange_certificate_chain.h
[modify] https://crrev.com/a1921554699fc6d02c7565f128aab8c9ec7b3655/content/browser/web_package/signed_exchange_certificate_chain_fuzzer.cc
[modify] https://crrev.com/a1921554699fc6d02c7565f128aab8c9ec7b3655/content/browser/web_package/signed_exchange_certificate_chain_unittest.cc
[modify] https://crrev.com/a1921554699fc6d02c7565f128aab8c9ec7b3655/content/browser/web_package/signed_exchange_handler_unittest.cc

Blockedon: 920897
Blocking: 803774
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 17 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f75cedf892435f7362e1f8d1ab1d4f21743649d9

commit f75cedf892435f7362e1f8d1ab1d4f21743649d9
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Thu Jan 17 06:07:50 2019

SignedExchange: Migrate test cases to 1b3

third_party/blink/web_tests/external/wpt/signed-exchange/sxg-head-request.tentative.html
is no longer relevant, since 1b3 no longer have request method serialized.
The request method in a 1b3 SXG is assumed to be always GET.

Bug: 919414
Change-Id: I0f7ec3de66db70b9cc12af209b74a22a4187460c
Reviewed-on: https://chromium-review.googlesource.com/c/1405156
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623604}
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/content/browser/web_package/signed_exchange_envelope_unittest.cc
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/content/browser/web_package/signed_exchange_handler_unittest.cc
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/content/test/data/sxg/generate-test-sxgs.sh
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/content/test/data/sxg/test.example.com_invalid_test.sxg
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/content/test/data/sxg/test.example.com_invalid_test.sxg.mock-http-headers
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/content/test/data/sxg/test.example.org_hello.txt.sxg
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/content/test/data/sxg/test.example.org_noext_test.sxg
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/content/test/data/sxg/test.example.org_test.sxg
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/content/test/data/sxg/test.example.org_test.sxg.mock-http-headers
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/content/test/data/sxg/test.example.org_test_download.sxg
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/content/test/data/sxg/test.example.org_test_download.sxg.mock-http-headers
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/content/test/data/sxg/test.example.org_test_invalid_cbor_header.sxg
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/content/test/data/sxg/test.example.org_test_invalid_cbor_header.sxg.mock-http-headers
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/content/test/data/sxg/test.example.org_test_invalid_content_type.sxg
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/content/test/data/sxg/test.example.org_test_invalid_magic_string.sxg
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/content/test/data/sxg/test.example.org_test_invalid_magic_string.sxg.mock-http-headers
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/content/test/data/sxg/test.example.org_test_missing_nosniff.sxg
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/content/test/data/sxg/test.example.org_test_missing_nosniff.sxg.mock-http-headers
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/third_party/blink/web_tests/external/wpt/signed-exchange/resources/generate-test-sxgs.sh
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg/__dir__.headers
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg/check-cert-request.sxg
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg/fallback-to-another-sxg.sxg
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg/nested-sxg.sxg
[delete] https://crrev.com/1d1fee8b5059cbfc044d6028cff20fb6a3020511/third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg/sxg-head-request.sxg
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg/sxg-inner-url-bom.sxg
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg/sxg-invalid-utf8-inner-url.sxg
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg/sxg-invalid-validity-url.sxg
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg/sxg-location.sxg
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg/sxg-noncacheable.sxg
[modify] https://crrev.com/f75cedf892435f7362e1f8d1ab1d4f21743649d9/third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg/sxg-utf8-inner-url.sxg
[delete] https://crrev.com/1d1fee8b5059cbfc044d6028cff20fb6a3020511/third_party/blink/web_tests/external/wpt/signed-exchange/sxg-head-request.tentative.html

Comment 9 by ksakamoto@chromium.org, Jan 18 (5 days ago)

Blockedon: 923229

Comment 10 by ksakamoto@google.com, Yesterday (24 hours ago)

Blockedon: 924020
Project Member

Comment 11 by bugdroid1@chromium.org, Today (23 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/accda0679e362676b899d8afe01c45b5a3ef61e6

commit accda0679e362676b899d8afe01c45b5a3ef61e6
Author: Rob Buis <rbuis@igalia.com>
Date: Tue Jan 22 07:14:31 2019

SignedExchangeCertFetcher: Remove |version| arg

Bug: 919414

Change-Id: I1753f02c791784b152153835fc2a8add260c035c
Reviewed-on: https://chromium-review.googlesource.com/c/1425700
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#624739}
[modify] https://crrev.com/accda0679e362676b899d8afe01c45b5a3ef61e6/content/browser/web_package/signed_exchange_cert_fetcher.cc
[modify] https://crrev.com/accda0679e362676b899d8afe01c45b5a3ef61e6/content/browser/web_package/signed_exchange_cert_fetcher.h
[modify] https://crrev.com/accda0679e362676b899d8afe01c45b5a3ef61e6/content/browser/web_package/signed_exchange_cert_fetcher_factory.cc
[modify] https://crrev.com/accda0679e362676b899d8afe01c45b5a3ef61e6/content/browser/web_package/signed_exchange_cert_fetcher_factory.h
[modify] https://crrev.com/accda0679e362676b899d8afe01c45b5a3ef61e6/content/browser/web_package/signed_exchange_cert_fetcher_unittest.cc
[modify] https://crrev.com/accda0679e362676b899d8afe01c45b5a3ef61e6/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/accda0679e362676b899d8afe01c45b5a3ef61e6/content/browser/web_package/signed_exchange_handler_unittest.cc

Sign in to add a comment