New issue
Advanced search Search tips

Issue 919413 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

platform_Powerwash: FAIL: Powerwash count didn't increase after powerwash cycle.

Project Member Reported by drinkcat@chromium.org, Jan 7

Issue description

Owner: fletch...@chromium.org
Status: Started (was: Available)
Working on a fix now.
Components: -Infra>Client>ChromeOS>CI OS>Firmware
Labels: -Pri-1 Pri-2
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9f8d99f792d427bbc1463afcef6e13f4027d1c39

commit 9f8d99f792d427bbc1463afcef6e13f4027d1c39
Author: Fletcher Woodruff <fletcherw@chromium.org>
Date: Tue Jan 08 01:59:32 2019

init: Add trailing newline to powerwash_count

Some tests expect a trailing newline in powerwash_count so add it back
in. Swap int parsing to base::StringToInt.

BUG= chromium:919413 
TEST=ran unit tests and platform_Powerwash on device

Change-Id: I751f3f8653797bdeda2e91d61b36181acd55bcf2
Reviewed-on: https://chromium-review.googlesource.com/c/1398141
Reviewed-by: Fletcher Woodruff <fletcherw@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Commit-Queue: Fletcher Woodruff <fletcherw@chromium.org>
Tested-by: Fletcher Woodruff <fletcherw@chromium.org>

[modify] https://crrev.com/9f8d99f792d427bbc1463afcef6e13f4027d1c39/init/clobber_state.cc
[modify] https://crrev.com/9f8d99f792d427bbc1463afcef6e13f4027d1c39/init/clobber_state_unittest.cc

Sign in to add a comment