Remove unnecessary classes and enums in public/platform/ and public/web/ |
|
Issue descriptionA bunch of classes and enums in public/platform/ and public/web/ become unnecessary after Onion Soup. For example: - public/platform/remoteplayback/ should be removed because remoteplayback is onion-souped. - The WebNotificationData::Direction enum should be removed. We should use NotificationDirection in notifications.mojom. - public/platform/presentation/ should be removed because presentation is onion-souped. - public/platform/wake_lock/ is empty. We should remove the directory. Complexity: Easy
,
Jan 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/205592100f64f79b3057af20cad12f11ad7e7162 commit 205592100f64f79b3057af20cad12f11ad7e7162 Author: Hwanseung Lee <hs1217.lee@samsung.com> Date: Tue Jan 08 08:01:00 2019 Remove public/platform/modules/presentation directory presentation is onion-souped. so this directory is not used anymore. Bug: 919392 Change-Id: Ib4d08da929ecae5493457d0d19b521760e3363ef Reviewed-on: https://chromium-review.googlesource.com/c/1399694 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#620651} [delete] https://crrev.com/3a6c1b3dec1f3d85030ca1356ba0dfb7ea1cfb64/third_party/blink/public/platform/modules/presentation/OWNERS [delete] https://crrev.com/3a6c1b3dec1f3d85030ca1356ba0dfb7ea1cfb64/third_party/blink/public/platform/modules/presentation/web_presentation_client.h [delete] https://crrev.com/3a6c1b3dec1f3d85030ca1356ba0dfb7ea1cfb64/third_party/blink/public/platform/modules/presentation/web_presentation_receiver.h [delete] https://crrev.com/3a6c1b3dec1f3d85030ca1356ba0dfb7ea1cfb64/third_party/blink/renderer/platform/exported/web_presentation_receiver.cc
,
Jan 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a998df346569ad382c31e2c408b3a84c30b377c8 commit a998df346569ad382c31e2c408b3a84c30b377c8 Author: Hwanseung Lee <hs1217.lee@samsung.com> Date: Tue Jan 08 13:50:37 2019 Remove public/platform/modules/wake_lock/ directory Remove this directory which is empty. Bug: 919392 Change-Id: Ie4e4b9e9459f5499e6e88781fc4d300f8b0dc245 Reviewed-on: https://chromium-review.googlesource.com/c/1400423 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#620703} [delete] https://crrev.com/e6e4a20f88f11bd08a7d405e169133e1081782ee/third_party/blink/public/platform/modules/wake_lock/OWNERS
,
Jan 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ffbaa6f6874b4d8c0cdf18bdefdd1ddc62db654 commit 2ffbaa6f6874b4d8c0cdf18bdefdd1ddc62db654 Author: Hwanseung Lee <hs1217.lee@samsung.com> Date: Thu Jan 10 15:26:49 2019 Replace WebNotificationData::Direction with NotificationDirection WebNotificationData::Direction is enum of mojom which is corresponding to NotificationDirection. it is Onion Soup effort replacing this. Bug: 919392 Change-Id: I4eb613f14389dceeddcee0cb4c2b0c2098609474 Reviewed-on: https://chromium-review.googlesource.com/c/1399696 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#621585} [modify] https://crrev.com/2ffbaa6f6874b4d8c0cdf18bdefdd1ddc62db654/content/renderer/notifications/notification_data_conversions.cc [modify] https://crrev.com/2ffbaa6f6874b4d8c0cdf18bdefdd1ddc62db654/content/renderer/notifications/notification_data_conversions_unittest.cc [modify] https://crrev.com/2ffbaa6f6874b4d8c0cdf18bdefdd1ddc62db654/third_party/blink/public/platform/modules/notifications/web_notification_data.h [modify] https://crrev.com/2ffbaa6f6874b4d8c0cdf18bdefdd1ddc62db654/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.cc |
|
►
Sign in to add a comment |
|
Comment 1 by haraken@chromium.org
, Jan 7