New issue
Advanced search Search tips

Issue 919390 link

Starred by 2 users
Status: Fixed
Owner:
johntlee@chromium.org
Closed: Jan 9
Cc:
ajha@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Separator line is missing between 'Printers' and 'Google cloud print ' option.

Project Member Reported by shru...@virtusa.com, Jan 7 
Chrome Version:73.0.3663.0 (Official Build) Revision	777e04a1821ce0673c0c5def89dcca29fa4bfd65-refs/branch-heads/3663@{#1}(64-bit)
OS : Mac(10.13.6, 10.13.1, 10.14.3) 

Steps to reproduce:
1. Launch chrome and Navigate to chrome://settings.
2. Observe under 'Printing 'section.
 
Actual Result   : Separator line is missing between 'Printers' and 'Google cloud print' option.
Expected Result : Separator line should be seen  between 'Printers' and 'Google cloud print' option.

This is a regression issue broken in M-73 and will soon update bisect information:
Good Build :73.0.3662.0
Bad Build : 73.0.3663.0


Kindly refer the attached screen-cast.
Thank You.
Expected_result.mov
4.2 MB View Download
Actual_result.mov
3.4 MB View Download

Comment 1 by shru...@virtusa.com, Jan 7

Labels: hasbisect OS-Linux OS-Windows
Owner: johntlee@chromium.org
Status: Assigned (was: Unconfirmed)
Update :
Bisect-info:
https://chromium.googlesource.com/chromium/src/+log/73.0.3662.0..73.0.3663.0?pretty=fuller&n=10000
Suspect:r 620172?

@John Lee: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: 
1. Unable to provide 'per-revision' bisect as it shows "We don't have enough builds to bisect" error message for above range. (tried on other machines but still getting the same error again)
2. Hence providing suspect via perform Chromium bisect .
3.Issue is also seen on OS: Windows(7,8,10) and Linux(14.04 LTS).

Thank You...

Comment 2 by johntlee@chromium.org, Jan 8 

Fixed
Screenshot from 2019-01-07 15-51-51.png
5.0 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4747b6ba46d14ec3523b0169d27612eb1fd619df

commit 4747b6ba46d14ec3523b0169d27612eb1fd619df
Author: John Lee <johntlee@chromium.org>
Date: Wed Jan 09 03:32:48 2019

Settings WebUI: Add back line between rows in Printers page

Bug:  919390 
Change-Id: I2fcfc0020a4f5956544aea1d93641adbe63e98e1
Reviewed-on: https://chromium-review.googlesource.com/c/1399706
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621033}
[modify] https://crrev.com/4747b6ba46d14ec3523b0169d27612eb1fd619df/chrome/browser/resources/settings/printing_page/printing_page.html

Comment 4 by johntlee@chromium.org, Jan 9

Status: Fixed (was: Assigned)

Comment 5 by johntlee@chromium.org, Jan 9

Cc: ajha@chromium.org
 Issue 920127  has been merged into this issue.

Comment 6 by shru...@virtusa.com, Jan 10

Labels: TE-Verified-M73 TE-Verified-73.0.3667.0
Update:
Retested above issue on  OS : Mac(10.13.6, 10.13.1, 10.14.3), Windows(7,8,10) and Linux(14.04 LTS)using latest Canary #73.0.3667.0 issue is fixed.
Now, Separator line is seen  between 'Printers' and 'Google cloud print' option.

Kindly review the attached screen-cast.

Thank you!

Comment 7 by shru...@virtusa.com, Jan 10 

Update :
Kindly refer the screen-cast of Canary #73.0.3667.0.

Thank You!
canary#73.0.36667.0.mov
5.9 MB View Download
►

Sign in to add a comment