New issue
Advanced search Search tips

Issue 919366 link

Starred by 1 user
Status: Fixed
Owner:
hcarmona@chromium.org
Closed: Jan 7
Cc:
mxcai@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

chrome/apps/OWNERS refers to missing file (can't make any changes in this dir)

Project Member Reported by mgiuca@chromium.org, Jan 7 
Any change to chrome/apps that consults chrome/apps/OWNERS (e.g. https://crrev.com/c/1391655) produces this presubmit error:

owners.SyntaxErrorInOwnersFile: /b/swarming/w/ir/cache/builder/chromium_presubmit/src/chrome/app/OWNERS:24 syntax error: //chrome/browser/ui/webui/welcome/nux/OWNERS does not refer to an existing file.

chrome/app/OWNERS refers to chrome/browser/ui/webui/welcome/nux/OWNERS which no longer exists. It was moved in r620112.

mxcai@ tried to update chrome/app/OWNERS to refer to the new path, but that CL was rejected because of the presubmit checking the OLD owners file, hitting the same error. So I am just going to revert r620112 (safer than proceeding through skipping a bunch of checks). Please reland, and update any references to these files from other OWNERS files.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fdb0515be77d9af0588610264e9932eacb2e6be

commit 8fdb0515be77d9af0588610264e9932eacb2e6be
Author: Matt Giuca <mgiuca@chromium.org>
Date: Mon Jan 07 00:48:07 2019

Revert "Move OWNERS file up a level for welcome related files."

This reverts commit 27af96f637149314d04a1a8f95fd05078e0fef4a.

Reason for revert: CLs in chrome/apps cannot land because the OWNERS
file there points at a missing file. Please reland, updating incoming
OWNERS files to point to the new location.

Original change's description:
> Move OWNERS file up a level for welcome related files.
>
> R=​dpapad@chromium.org
>
> Bug: NONE
> Change-Id: I73051130e3a8d8f0791ac172666b179a29de4dd9
> Reviewed-on: https://chromium-review.googlesource.com/c/1395815
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Commit-Queue: Hector Carmona <hcarmona@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#620112}

TBR=dpapad@chromium.org,hcarmona@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  919366 
Change-Id: I8fa33c77ff46ab260fe7eec0d3c6fd6bcce7da07
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/1395863
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620237}
[rename] https://crrev.com/8fdb0515be77d9af0588610264e9932eacb2e6be/chrome/browser/resources/welcome/onboarding_welcome/OWNERS
[rename] https://crrev.com/8fdb0515be77d9af0588610264e9932eacb2e6be/chrome/browser/ui/webui/welcome/nux/OWNERS

Comment 2 by mgiuca@chromium.org, Jan 7

Status: Fixed (was: Assigned)
The immediate issue is fixed due to the revert.
►

Sign in to add a comment