New issue
Advanced search Search tips

Issue 919364 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue pdfium:1193

Blocking:
issue 902646



Sign in to add a comment

Saving in annotation mode exits annotation mode

Project Member Reported by dstockwell@google.com, Jan 6

Issue description

This depends on an upstream fix in Ink which depends on issue pdfium:1193
 
Blocking: 902646
Blockedon: pdfium:1193
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05c4e412942d37fa177f4d3582e42a934d1e21a3

commit 05c4e412942d37fa177f4d3582e42a934d1e21a3
Author: dstockwell <dstockwell@google.com>
Date: Thu Jan 10 05:51:13 2019

pdf: Exit annotation mode after using destructive save

Due to limitations around saving documents that contain bookmarks
we must temporarily use a save API that destroys the Ink engine.
For now when the user triggers a save in annotation mode we will
save and then exit back to the plugin.

Bug: 919364,902646
Change-Id: Ia61d59b3d01965aba259692e96d40fc4389680b9
Reviewed-on: https://chromium-review.googlesource.com/c/1397502
Commit-Queue: dstockwell <dstockwell@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621481}
[modify] https://crrev.com/05c4e412942d37fa177f4d3582e42a934d1e21a3/chrome/browser/resources/pdf/elements/viewer-ink-host/viewer-ink-host.js
[modify] https://crrev.com/05c4e412942d37fa177f4d3582e42a934d1e21a3/chrome/browser/resources/pdf/ink/ink_api.js
[modify] https://crrev.com/05c4e412942d37fa177f4d3582e42a934d1e21a3/chrome/browser/resources/pdf/pdf_viewer.js

Sign in to add a comment