Issue metadata
Sign in to add a comment
|
ShelfAppBrowserTestNoDefaultBrowser.AltNumberBrowserTabbing is flaky |
||||||||||||||||||||||
Issue descriptionFindit identified the culprit r620103 as introducing flaky test(s) summarized in https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOTA4YTYyYmYwNTViY2EzMTMxM2QxOGRjYzMxNjE3MjQxZGY4MGI2OQw Please revert the culprit or disable the test(s) asap. If you are the owner, please fix! If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20culprit%20r620103&comment=Link%20to%20Culprit%3A%20https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOTA4YTYyYmYwNTViY2EzMTMxM2QxOGRjYzMxNjE3MjQxZGY4MGI2OQw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Jan 8
It's a crash in test shutdown: [11228:11228:0105/205518.455465:FATAL:web_contents_observer_sanity_checker.cc(319)] Check failed: is_loading_. #0 0x5632aa15c9af base::debug::StackTrace::StackTrace() #1 0x5632aa0df851 logging::LogMessage::~LogMessage() #2 0x5632aa680134 content::WebContentsObserverSanityChecker::DidStopLoading() #3 0x5632a8e0f93d content::WebContentsImpl::LoadingStateChanged() #4 0x5632a8e1a881 content::WebContentsImpl::DidStopLoading() #5 0x5632a8b6e7e0 content::FrameTreeNode::DidStopLoading() #6 0x5632a8b6e4df content::FrameTreeNode::~FrameTreeNode() #7 0x5632a8b9762d content::RenderFrameHostImpl::OnRenderProcessGone() #8 0x5632a8b974c5 _ZN3IPC8MessageTI35FrameHostMsg_RenderProcessGone_MetaNSt3__15tupleIJiiEEEvE8DispatchIN7content19RenderFrameHostImplES8_vMS8_FviiEEEbPKNS_7MessageEPT_PT0_PT1_T2_ #9 0x5632a8b96c3d content::RenderFrameHostImpl::OnMessageReceived() #10 0x5632a8d0be3a content::RenderProcessHostImpl::ProcessDied() #11 0x5632a8d0b815 content::RenderProcessHostImpl::FastShutdownIfPossible() #12 0x5632aa25754c browser_shutdown::OnShutdownStarting() #13 0x5632aa256f2f chrome::ExitIgnoreUnloadHandlers() #14 0x5632aa172395 base::debug::TaskAnnotator::RunTask() #15 0x5632aa0e584f base::MessageLoopImpl::RunTask() #16 0x5632aa0e5d23 base::MessageLoopImpl::DoWork() #17 0x5632aa16e999 base::MessagePumpLibevent::Run() #18 0x5632aa1036f5 base::RunLoop::Run() #19 0x5632aa1be8d7 InProcessBrowserTest::QuitBrowsers() #20 0x5632aa1be7bc InProcessBrowserTest::PostRunTestOnMainThread() #21 0x5632aa65255d content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #22 0x5632aa20b5fe ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #23 0x5632aa20a5d2 ChromeBrowserMainParts::PreMainMessageLoopRun() #24 0x5632a79e0a42 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #25 0x5632a8a56352 content::BrowserMainLoop::PreMainMessageLoopRun() #26 0x5632a8de07d7 content::StartupTaskRunner::RunAllTasksNow() #27 0x5632a8a5514d content::BrowserMainLoop::CreateStartupTasks() #28 0x5632a8a58212 content::BrowserMainRunnerImpl::Initialize() #29 0x5632a8a5365e content::BrowserMain() #30 0x5632a9d4bbca content::ContentMainRunnerImpl::RunServiceManager() #31 0x5632a9d4b846 content::ContentMainRunnerImpl::Run() #32 0x5632abe6baad service_manager::Main() #33 0x5632a9d49f64 content::ContentMain() #34 0x5632aa651ec7 content::BrowserTestBase::SetUp() #35 0x5632aa1bd0c6 InProcessBrowserTest::SetUp() #36 0x5632a7e7b300 testing::Test::Run() #37 0x5632a7e7c09f testing::TestInfo::Run() #38 0x5632a7e7c5f7 testing::TestCase::Run() #39 0x5632a7e87ea7 testing::internal::UnitTestImpl::RunAllTests() #40 0x5632a7e87a27 testing::UnitTest::Run() #41 0x5632aa1d2ac9 base::TestSuite::Run() #42 0x5632aa0c107d ChromeTestSuiteRunner::RunTestSuite() #43 0x5632aa6722bc content::LaunchTests() #44 0x5632aa0c1522 LaunchChromeTests() #45 0x5632aa0c100e main #46 0x7f22faa4ef45 __libc_start_main #47 0x5632a64bdcaa _start See issue 915360 - this happens in a variety of tests. It's probably not directly related to my CL, just the specific set of posted tasks in the queue during test shutdown.
,
Jan 8
,
Jan 9
This happens in other tests too. Here's a more detailed backtrace from a debug build: [252492:252492:0108/165806.494602:FATAL:web_contents_observer_sanity_checker.cc(319)] Check failed: is_loading_. #0 0x7fac46b9051d base::debug::StackTrace::StackTrace() #1 0x7fac4688b87a base::debug::StackTrace::StackTrace() #2 0x7fac468f60fe logging::LogMessage::~LogMessage() #3 0x55d69805b350 content::WebContentsObserverSanityChecker::DidStopLoading() #4 0x7fac3d0020fc content::WebContentsImpl::LoadingStateChanged() #5 0x7fac3d014214 content::WebContentsImpl::DidStopLoading() #6 0x7fac3c4a847e content::FrameTreeNode::DidStopLoading() #7 0x7fac3c4a7fd2 content::FrameTreeNode::~FrameTreeNode() #8 0x7fac3c58660d std::__Cr::__vector_base<>::~__vector_base() #9 0x7fac3c531f6d content::RenderFrameHostImpl::ResetChildren() #10 0x7fac3c538bc8 content::RenderFrameHostImpl::OnRenderProcessGone() #11 0x7fac3c594234 _ZN4base20DispatchToMethodImplIPN7content19RenderFrameHostImplEMS2_FvN5blink18WebScrollDirectionENS4_20WebScrollGranularityEENSt4__Cr5tupleIJS5_S6_EEEJLm0ELm1EEEEvRKT_T0_OT1_NS9_16integer_sequenceImJXspT2_EEEE #12 0x7fac3c594168 _ZN4base16DispatchToMethodIPN7content19RenderFrameHostImplEMS2_FvN5blink18WebScrollDirectionENS4_20WebScrollGranularityEENSt4__Cr5tupleIJS5_S6_EEEEEvRKT_T0_OT1_ #13 0x7fac3c5940f4 _ZN3IPC16DispatchToMethodIN7content19RenderFrameHostImplEMS2_FviiEvNSt4__Cr5tupleIJiiEEEEEvPT_T0_PT1_OT2_ #14 0x7fac3c565ac8 _ZN3IPC8MessageTI35FrameHostMsg_RenderProcessGone_MetaNSt4__Cr5tupleIJiiEEEvE8DispatchIN7content19RenderFrameHostImplES8_vMS8_FviiEEEbPKNS_7MessageEPT_PT0_PT1_T2_ #15 0x7fac3c5374bd content::RenderFrameHostImpl::OnMessageReceived() #16 0x7fac3cbf28c6 content::RenderProcessHostImpl::ProcessDied() #17 0x7fac3cbf2128 content::RenderProcessHostImpl::FastShutdownIfPossible() #18 0x55d696dea884 browser_shutdown::OnShutdownStarting() #19 0x55d696de9fa4 chrome::ExitIgnoreUnloadHandlers() #20 0x55d68f6a083a _ZN4base8internal13FunctorTraitsIPFvvEvE6InvokeIS3_JEEEvOT_DpOT0_ #21 0x55d68f6a080d _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIPFvvEJEEEvOT_DpOT0_ #22 0x55d68f704c81 _ZN4base8internal7InvokerINS0_9BindStateIPFvvEJEEES3_E7RunImplIRKS4_RKNSt4__Cr5tupleIJEEEJEEEvOT_OT0_NSA_16integer_sequenceImJXspT1_EEEE #23 0x55d68f704c4c _ZN4base8internal7InvokerINS0_9BindStateIPFvvEJEEES3_E3RunEPNS0_13BindStateBaseE #24 0x7fac4683d3ee _ZNO4base12OnceCallbackIFvvEE3RunEv #25 0x7fac4688cd2a base::debug::TaskAnnotator::RunTask() #26 0x7fac4691c53c base::MessageLoopImpl::RunTask() #27 0x7fac4691c84b base::MessageLoopImpl::DeferOrRunPendingTask() #28 0x7fac4691d084 base::MessageLoopImpl::DoWork() #29 0x7fac46be3789 base::MessagePumpLibevent::Run() #30 0x7fac4691bd56 base::MessageLoopImpl::Run() #31 0x7fac469c74c2 base::RunLoop::Run() #32 0x55d696b41d1c InProcessBrowserTest::RunUntilBrowserProcessQuits() #33 0x55d696b44285 InProcessBrowserTest::QuitBrowsers() #34 0x55d696b43fb4 InProcessBrowserTest::PostRunTestOnMainThread() #35 0x55d697f70eda content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #36 0x55d68f3d32fd _ZN4base8internal13FunctorTraitsIM25RenderViewContextMenuBaseFvvEvE6InvokeIS4_P21RenderViewContextMenuJEEEvT_OT0_DpOT1_ #37 0x55d68f3d3244 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIM25RenderViewContextMenuBaseFvvEJP21RenderViewContextMenuEEEvOT_DpOT0_ #38 0x55d697f73a85 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt4__Cr5tupleIJS8_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE #39 0x55d697f739bc _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE #40 0x55d68f3c3a9d _ZNKR4base17RepeatingCallbackIFvvEE3RunEv #41 0x55d696ca10d0 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #42 0x55d696c9f264 ChromeBrowserMainParts::PreMainMessageLoopRun() #43 0x55d692370b6b chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #44 0x7fac3bf6a132 content::BrowserMainLoop::PreMainMessageLoopRun() #45 0x7fac3ab63d7d _ZN4base8internal13FunctorTraitsIMN7content12ChildProcessEFvvEvE6InvokeIS5_PS3_JEEEvT_OT0_DpOT1_ #46 0x7fac3ab63cc4 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN7content12ChildProcessEFvvEJPS5_EEEvOT_DpOT0_ #47 0x7fac3bf6ff25 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKNSt4__Cr5tupleIJS8_EEEJLm0EEEEiOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE #48 0x7fac3bf6fe5c _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE #49 0x7fac3aa6a1ed _ZNKR4base17RepeatingCallbackIFvvEE3RunEv #50 0x7fac3cf5f6ed content::StartupTaskRunner::RunAllTasksNow() #51 0x7fac3bf65c8f content::BrowserMainLoop::CreateStartupTasks() #52 0x7fac3bf72553 content::BrowserMainRunnerImpl::Initialize() #53 0x7fac3bf5d5a9 content::BrowserMain() #54 0x7fac3e27afb0 content::RunBrowserProcessMain() #55 0x7fac3e27e425 content::ContentMainRunnerImpl::RunServiceManager() #56 0x7fac3e27cfec content::ContentMainRunnerImpl::Run() #57 0x7fac3e273d4c content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #58 0x7fac10327a04 service_manager::Main() #59 0x7fac3e278695 content::ContentMain() #60 0x55d697f700d4 content::BrowserTestBase::SetUp() #61 0x55d696b41068 InProcessBrowserTest::SetUp() #62 0x55d696a5892c extensions::ExtensionBrowserTest::SetUp() #63 0x55d68f42514e _ZN7testing8internal12InvokeHelperIRKNSt4__Cr6vectorIPN12user_manager4UserENS2_9allocatorIS6_EEEENS2_5tupleIJEEEE12InvokeMethodIN8chromeos15MockUserManagerEMSH_KFSB_vEEESB_PT_T0_RKSD_ #64 0x55d6932bac92 testing::internal::HandleExceptionsInMethodIfSupported<>() #65 0x55d69329aa24 testing::Test::Run() #66 0x55d69329b6d2 testing::TestInfo::Run() #67 0x55d69329c5df testing::TestCase::Run() #68 0x55d6932b047b testing::internal::UnitTestImpl::RunAllTests() #69 0x55d6932c456e testing::internal::HandleSehExceptionsInMethodIfSupported<>() #70 0x55d6932bc412 testing::internal::HandleExceptionsInMethodIfSupported<>() #71 0x55d6932b00b8 testing::UnitTest::Run() #72 0x55d696b8c871 RUN_ALL_TESTS() #73 0x55d696b89a3c base::TestSuite::Run() #74 0x55d696a2b077 ChromeTestSuiteRunner::RunTestSuite() #75 0x55d696a2b163 ChromeTestLauncherDelegate::RunTestSuite() #76 0x55d697ffd019 content::LaunchTests() #77 0x55d696a2c482 LaunchChromeTests() #78 0x55d696a2a96b main #79 0x7fac11c0b2b1 __libc_start_main #80 0x55d68f34d07a _start Repro: autoninja -C out/Debug browser_tests && testing/xvfb.py out/Debug/browser_tests --gtest_filter=ShelfAppBrowser* --gtest_repeat=100 --test-launcher-jobs=40
,
Jan 9
,
Jan 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9dcfd5af0b0f09d767850bc02013b59c0ac61a3f commit 9dcfd5af0b0f09d767850bc02013b59c0ac61a3f Author: James Cook <jamescook@chromium.org> Date: Thu Jan 10 17:45:38 2019 Navigate to about:blank in new windows in ShelfAppBrowserTest Two ShelfAppBrowserTest tests open new windows that try to load the new tab page. This results in extra navigations that aren't relevant to the test. Changing the code to use InProcBrowserTest::CreateBrowser() means the new windows load about:blank. This seems to reduce the frequency of flaky test shutdown crashes in navigation code. (I noticed this incidentally while investigating a different test. The second bug tracks the root cause.) Bug: 919347 , 466089 Test: browser_tests on Chrome OS Change-Id: I35d2a9a364b4c5f5369ef7a0ee55db3a75a9b82d Reviewed-on: https://chromium-review.googlesource.com/c/1404394 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#621625} [modify] https://crrev.com/9dcfd5af0b0f09d767850bc02013b59c0ac61a3f/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
,
Jan 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51bdda57a8d838112c315e6b95e45b979f41fd6e commit 51bdda57a8d838112c315e6b95e45b979f41fd6e Author: James Cook <jamescook@chromium.org> Date: Fri Jan 11 18:33:58 2019 Remove CHECK in WebContentsObserverSanityChecker::DidStopLoading The check causes low-level browser_test flake across a wide variety of test suites, usually due to check failures during test suite teardown. This is test-only code, so relax the check until the root cause can be investigated further. Bug: 466089, 871010, 913006, 915360, 919347 Test: browser_tests Change-Id: Ife2ab6a6d260471f79873b6f0fd2914a4c7bb71d Reviewed-on: https://chromium-review.googlesource.com/c/1403353 Reviewed-by: Camille Lamy <clamy@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#622067} [modify] https://crrev.com/51bdda57a8d838112c315e6b95e45b979f41fd6e/content/test/web_contents_observer_sanity_checker.cc
,
Jan 14
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by xidac...@chromium.org
, Jan 7Status: Assigned (was: Untriaged)