Issue metadata
Sign in to add a comment
|
ChromeVoxLiveRegionsTest.LiveRegionThenFocus is flaky |
||||||||||||||||||||
Issue descriptionFindit identified the culprit r620205 as introducing flaky test(s) summarized in https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZWIxMDJlYzc1MGM0MGNkZTNlYjJhYjVhMTBkMmNiZjliMGU2ZjQ5Nww Please revert the culprit or disable the test(s) asap. If you are the owner, please fix! If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20culprit%20r620205&comment=Link%20to%20Culprit%3A%20https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZWIxMDJlYzc1MGM0MGNkZTNlYjJhYjVhMTBkMmNiZjliMGU2ZjQ5Nww Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Jan 7
,
Jan 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/440fa58ca59bcc658f2cc6c697e95cf654babdc4 commit 440fa58ca59bcc658f2cc6c697e95cf654babdc4 Author: David Tseng <dtseng@chromium.org> Date: Mon Jan 07 19:04:06 2019 Reland: Fix live region corner cases. Made LiveRegion test more robust. Bug: 919342 TBR=dtseng@chromium.org Original change: 1. live regions are processed by examining tree changes. As a result, they occur prior to all other events within an EventBundle. In practice, we actually want to defer live region output until the end of the event bundle. We can achieve this by scheduling the processing of all queued output for live regions after the current js event loop. 2. re-enable a test which was flaking and catches text selection + live region output interplay. The expectation is that: - text selections should always flush (if triggered by user) - live regions should always category flush (on live regions). In effect, they will queue up after text selection changes - live regions triggered in the same event loop Blink-side with text selections should always be outputted after the text selection even if the client page js triggers the live region first 3. handle a corner case when a page sets aria-live="off". An example can be found on Gmail's main search text field (hotkey '/'). The <input> is marked up with aria-live="off". However, triggering text changes by typing causes the staticText child to be mutated and us to treat this as a live region. Ensure that live region code ignores all such output. Test: 1 and 2 are now covered by the re-enabled test. 3 is tested manually. Change-Id: Ieab663f97fb9f962a0e6ba05d3093e688374ca91 Reviewed-on: https://chromium-review.googlesource.com/c/1398290 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#620403} [modify] https://crrev.com/440fa58ca59bcc658f2cc6c697e95cf654babdc4/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs [modify] https://crrev.com/440fa58ca59bcc658f2cc6c697e95cf654babdc4/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js [modify] https://crrev.com/440fa58ca59bcc658f2cc6c697e95cf654babdc4/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions.js [modify] https://crrev.com/440fa58ca59bcc658f2cc6c697e95cf654babdc4/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs [modify] https://crrev.com/440fa58ca59bcc658f2cc6c697e95cf654babdc4/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js [modify] https://crrev.com/440fa58ca59bcc658f2cc6c697e95cf654babdc4/chrome/browser/resources/chromeos/chromevox/testing/mock_feedback.js
,
Jan 10
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Jan 7