New issue
Advanced search Search tips

Issue 919320 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Intent navigates and creates new tab

Project Member Reported by pinkerton@google.com, Jan 5

Issue description

M73 canary
iPhoneX iOS12.x

- open one tab, navigate to any page, say CNN.
- switch to gmail app and tap a link to intent back to Chrome

expected:

- two tabs, one with CNN, the other with the page opened from gmail

actual:

- two tabs, both with page opened from gmail

Appears that in addition to opening the link in a new tab, it also navigates in the existing tab. 
 
Owner: pkl@chromium.org
Status: Assigned (was: Untriaged)
That seems like a new (erroneous) behavior.
Verified that M73 canary is broken as reported. M72 beta is OK.
Cc: marq@chromium.org
Status: Started (was: Assigned)
Bisect result
Working - 73.0.3633.0
Failing - 73.0.3634.0

A "return" was unintentionally removed during a refactor in http://crrev/c/1329742. 
Pending fix: http://crrev/c/1401843
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83c8cea520c4e2ee8d9138ade7255667701106e2

commit 83c8cea520c4e2ee8d9138ade7255667701106e2
Author: Peter K. Lee <pkl@chromium.org>
Date: Wed Jan 09 14:14:17 2019

Return as soon as a tab has been created.

In http://crrev/c/1329742, a "return" was accidentally removed causing
a URL to be loaded twice.
See http://crrev/c/1329742/5/ios/chrome/app/main_controller.mm#2282

Bug:  919320 
Change-Id: I8a52a14c5bada805cc008783d41e5db72989fd5b
Reviewed-on: https://chromium-review.googlesource.com/c/1401843
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621138}
[modify] https://crrev.com/83c8cea520c4e2ee8d9138ade7255667701106e2/ios/chrome/app/main_controller.mm

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on iPad Pro iOS 11.4.1, iPhone XSMAX iOS 12.0.1 on build 73.0.3672.0 Canary

Sign in to add a comment