New issue
Advanced search Search tips

Issue 919282 link

Starred by 3 users

Issue metadata

Status: Assigned
Merged: issue 730110
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug



Sign in to add a comment

touch-action is not correctly preventing pinch-zoom

Reported by encrypts...@gmail.com, Jan 5

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36

Steps to reproduce the problem:
1. Load Chrome/Chromium on a device that supports at least two touch points (e.g., laptop with touchscreen, tablet)
2. Load this test site: https://googlechrome.github.io/samples/touch-action/
3. Use one finger on the touch screen to pan one of the test sections that are limited to panning (e.g., the "touch-action: pan-x" section)
4. While panning, add another finger and attempt a pinch-zoom gesture

What is the expected behavior?
When the "touch-action" CSS property is set to options that only permit pan vertically and/or horizontally (e.g., pan-x, pan-y), the pinch-zoom gesture should not work at any time when performed on the portion of the DOM that the property is applied to.

What went wrong?
When the user attempts a pinch-zoom gesture on the portion of the DOM with the touch-action property applied, one of three behaviors occurs:

1) If the user was not already touching the screen, the pinch-zoom gesture has no effect.

2) If the user was already performing a single-finger pan gesture, the user is then able to add another finger and perform the pinch-zoom gesture. This should not occur.

3) If the user was previously performing a single-finger pan gesture, has since stopped panning, but the UI remains in a state of momentum-based scrolling, the user is then able to perform the pinch-zoom gesture. This should not occur.

Did this work before? No 

Does this work in other browsers? No
 Identical bug behavior occurs with Edge 17.17134. This bug could not be reproduced on Firefox 64.0.

Chrome version: 71.0.3578.98  Channel: stable
OS Version: 10.0
Flash Version:
 
Note: this may be related to this bug: https://bugs.chromium.org/p/chromium/issues/detail?id=730110
Labels: Needs-Triage-M71
Cc: vamshi.kommuri@chromium.org
Labels: Triaged-ET
Mergedinto: 730110
Status: Duplicate (was: Unconfirmed)
As the issue seems to be similar to that of Issue 730110, hence merging into it and marking it as Duplicate. And adding required OS label in 730110. 

Thanks!
Cc: xidac...@chromium.org
I think this got fixed in https://crrev.com/06a04426d9ab89de735fcb04a0e5c7957d179e29 which is in beta. Indeed, I can't repro in Beta or Dev so the fix should be in stable soon.
@xidac I tested this just now in Chrome Canary on both Windows 10 and Android. Case #2 (adding a finger while panning) is indeed fixed, but case #3 (pinching while in momentum) is not fixed.
encryptstream@: when you say case #3, you mean crbug.com/730110, is that correct?
Cc: -xidac...@chromium.org bokan@chromium.org
Owner: xidac...@chromium.org
Status: Fixed (was: Duplicate)
Marking this fixed as it's not actually related to issue 730110 which does still repro
@bokan I may be wrong with what it's related to. Alternatively it is this: https://bugs.chromium.org/p/chromium/issues/detail?id=771330

@xida

Sorry about that, I was referring to the cases I outlined in the report. This one in particular:

> 3) If the user was previously performing a single-finger pan gesture, has since stopped panning, but the UI remains in a state of momentum-based scrolling, the user is then able to perform the pinch-zoom gesture. This should not occur.

In reality I think this might be separate, as it appears that there is no filtering done when in a momentum scrolling state. E.g., pan-y also works when only pan-x is explicitly enabled.

I can provide a video should that help.
Labels: OS-Linux
Status: Assigned (was: Fixed)
Ah, yes, you're right - we seem to ignore touch action while in a momentum/fling based scroll.

Sign in to add a comment