New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 919273 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

XRefs selectively not working

Project Member Reported by staphany@chromium.org, Jan 5

Issue description

Example: https://cs.chromium.org/chromium/src/content/renderer/appcache/appcache_frontend_impl.h

When hovering my mouse through the code, only 4 words have links:

Line 6: CONTENT_RENDERER_APPCACHE_APPCACHE_FRONTEND_IMPL_H_
Line 13: "content/common/appcache_interfaces.h"
Line 49: 
  - URLLoaderFactoryPtr
  - url_loader_factory

I did recently push changes to this file and am also seeing that lines in other files with related recent changes are also missing links (e.g. https://cs.chromium.org/chromium/src/content/renderer/render_frame_impl.cc?l=3709), so perhaps it's an issue that gets resolved with time. 
 

Comment 1 Deleted

It looks like the links are working on the initial example, so I'd look at files with more recent changes when attempting to reproduce the issue.
Owner: flyboy@chromium.org
Status: Assigned (was: Untriaged)
Status: WontFix (was: Assigned)
The xrefs are backed by a batch processing pipeline with a latency on the order of half a day, and also does not run on the weekends.  So this is expected.
Cc: pwnall@chromium.org
Could we at least get some feedback that XRefs are behind code, so they're unreliable? Perhaps disable the layer altogether (have it error out) if the data is behind the code?

I've had situations in the past where I used "find references", got an incorrect response, put together a CL based on that, and had it fail on the try bots.
I think that could be a reasonable feature request (please file one, separately from this bug).  We're in the process of a big migration now, so it's probably not wise for us to target this for the old/existing platform.

Sign in to add a comment