New issue
Advanced search Search tips

Issue 919268 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Move offline ARC ToS from chromeos-assets to demo_mode_resources

Project Member Reported by michae...@chromium.org, Jan 5

Issue description

Offline ARC++ ToS and privacy policies were added in  issue 857275  for offline Demo Mode. These files were large enough that we decided not to include them in rootfs ( issue 896749 ).

Instead, we will ship them with the offline Demo Mode Resources image, so they'll live on the stateful partition and won't be included in normal recovery images.

This bug is for moving the assets themselves, adding them to the component, and modifying Chrome to read them from the component during offline Demo Mode setup at OOBE.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c62f958c79c9fca5e63b614ebd21ee23be5d749

commit 3c62f958c79c9fca5e63b614ebd21ee23be5d749
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Sun Jan 13 12:16:22 2019

Show offline Demo Mode ToS from preinstalled demo resources

Loads the ARC++ ToS and Privacy Policy from the preinstalled demo
resources image during offline Demo Mode setup.

Bug: 919268
Change-Id: I3445c9efbf513ef63b1647061c782bb89d48294b
Reviewed-on: https://chromium-review.googlesource.com/c/1407957
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622344}
[modify] https://crrev.com/3c62f958c79c9fca5e63b614ebd21ee23be5d749/chrome/browser/chromeos/login/demo_mode/demo_setup_controller.cc
[modify] https://crrev.com/3c62f958c79c9fca5e63b614ebd21ee23be5d749/chrome/browser/chromeos/login/demo_mode/demo_setup_controller.h
[modify] https://crrev.com/3c62f958c79c9fca5e63b614ebd21ee23be5d749/chrome/browser/ui/webui/about_ui.cc
[modify] https://crrev.com/3c62f958c79c9fca5e63b614ebd21ee23be5d749/chrome/browser/ui/webui/about_ui.h
[modify] https://crrev.com/3c62f958c79c9fca5e63b614ebd21ee23be5d749/chrome/browser/ui/webui/about_ui_unittest.cc

Sign in to add a comment