New issue
Advanced search Search tips

Issue 919254 link

Starred by 1 user
Status: Fixed
Owner:
sergeyu@chromium.org
Closed: Jan 8
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

Fuchsia: Font rendering in webrunner is not consistent with other platforms

Project Member Reported by sergeyu@chromium.org, Jan 5 
Currently webrunner leaves default values font rendering configuration in RenderingPreferences. The default values are not optimal. For example on Android chrome uses subpixel positioning and slight hinting, while in webrunner subpixel positioning is disabled and we have medium hinting. 

Chrome uses the configuration returned from gfx::GetFontRenderParams() to set the values in RendererPreferences, see https://codesearch.chromium.org/chromium/src/chrome/browser/renderer_preferences_util.cc?type=cs&sq=package:chromium&targetos=chromium&g=0&l=153 . webrunner should do the same.

Comment 1 Deleted

Comment 2 Deleted

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd5f85adfeb64751772be6dcb594d023c4f9df81

commit fd5f85adfeb64751772be6dcb594d023c4f9df81
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Mon Jan 07 21:57:28 2019

Add content::UpdateFontRendererPreferencesFromSystemSettings()

Previously the code that sets font rendering config in RendererPreferences
was duplicated in 2 places. We also need to use that code in webrunner. Added
content::UpdateFontRendererPreferencesFromSystemSettings(). It's now used
in Android WebView, Chrome and webrunner.

Bug:  919254 
Change-Id: I5e4cccf9c9996a335fb79ba2b8d7f53eaf7fbc47
Reviewed-on: https://chromium-review.googlesource.com/c/1396843
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620493}
[modify] https://crrev.com/fd5f85adfeb64751772be6dcb594d023c4f9df81/android_webview/BUILD.gn
[modify] https://crrev.com/fd5f85adfeb64751772be6dcb594d023c4f9df81/android_webview/browser/aw_settings.cc
[modify] https://crrev.com/fd5f85adfeb64751772be6dcb594d023c4f9df81/chrome/browser/renderer_preferences_util.cc
[modify] https://crrev.com/fd5f85adfeb64751772be6dcb594d023c4f9df81/content/public/common/BUILD.gn
[add] https://crrev.com/fd5f85adfeb64751772be6dcb594d023c4f9df81/content/public/common/renderer_preferences_util.cc
[add] https://crrev.com/fd5f85adfeb64751772be6dcb594d023c4f9df81/content/public/common/renderer_preferences_util.h
[modify] https://crrev.com/fd5f85adfeb64751772be6dcb594d023c4f9df81/webrunner/browser/frame_impl.cc

Comment 4 by sergeyu@chromium.org, Jan 8

Status: Fixed (was: Started)
►

Sign in to add a comment