New issue
Advanced search Search tips

Issue 919242 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 11
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

<input> elements with autofocus aren't focused on fuchsia

Project Member Reported by jamesr@google.com, Jan 4

Issue description

Chrome Version: 73.0.3654.0
OS: Fuchsia

What steps will reproduce the problem?
(1) Open http://diveintohtml5.info/examples/input-autofocus.html

What is the expected result?

Input event is focused

What happens instead?

Input event isn't focused
 
Owner: kmarshall@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b9ddf8b8035507c18ef7b11e4af82c4047385a0

commit 8b9ddf8b8035507c18ef7b11e4af82c4047385a0
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Fri Jan 11 02:05:31 2019

[fuchsia] Fix Scenic focus & input handling.

Implements a number of fixes to text editing across multiple Scenic
windows.

It wires up focus & blur events to the WindowTreeHost and InputMethod,
so that the WTH's text editing modality can be started and stopped
as appropriate.

It also sets up and tears down IME service connections in response
to focus and blur events, because Fuchsia temporarily requires
applications to manage the lifetime of their input focus.


Bug:  919242 
Change-Id: I7ed96f312bc65d179f2f8565a4475660b1547a5f
Reviewed-on: https://chromium-review.googlesource.com/c/1403674
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621864}
[modify] https://crrev.com/8b9ddf8b8035507c18ef7b11e4af82c4047385a0/ui/base/ime/fuchsia/input_method_keyboard_controller_fuchsia.cc
[modify] https://crrev.com/8b9ddf8b8035507c18ef7b11e4af82c4047385a0/ui/base/ime/fuchsia/input_method_keyboard_controller_fuchsia.h
[modify] https://crrev.com/8b9ddf8b8035507c18ef7b11e4af82c4047385a0/ui/base/ime/input_method_fuchsia.cc
[modify] https://crrev.com/8b9ddf8b8035507c18ef7b11e4af82c4047385a0/ui/base/ime/input_method_fuchsia.h
[modify] https://crrev.com/8b9ddf8b8035507c18ef7b11e4af82c4047385a0/webrunner/BUILD.gn
[modify] https://crrev.com/8b9ddf8b8035507c18ef7b11e4af82c4047385a0/webrunner/browser/DEPS
[modify] https://crrev.com/8b9ddf8b8035507c18ef7b11e4af82c4047385a0/webrunner/browser/frame_impl.cc

Owner: jamesr@google.com
Status: Fixed (was: Assigned)
It seems to work on the rolled build of Chrome, but jamesr should be the one to mark this as verified.
Owner: kmarshall@chromium.org

Sign in to add a comment