APK wrappers crash on carriage return |
|||
Issue description
To repro, log a carriage return from anywhere in chrome. And then run through out/bin/chrome_public_apk run ...
LOG(ERROR) << "foo\rbar";
Failed to process line: barTraceback (most recent call last):
File "out/x86Debug/bin/chrome_public_apk", line 32, in <module>
sys.exit(main())
File "out/x86Debug/bin/chrome_public_apk", line 22, in main
resolve(None))
File "/usr/local/google/code/clankium/src/build/android/apk_operations.py", line 1408, in Run
_RunInternal(parser, output_directory=output_directory)
File "/usr/local/google/code/clankium/src/build/android/apk_operations.py", line 1389, in _RunInternal
args.command.Run()
File "/usr/local/google/code/clankium/src/build/android/apk_operations.py", line 1310, in Run
_LogcatCommand.Run(self)
File "/usr/local/google/code/clankium/src/build/android/apk_operations.py", line 1159, in Run
bool(self.args.verbose_count))
File "/usr/local/google/code/clankium/src/build/android/apk_operations.py", line 633, in _RunLogcat
logcat_processor.ProcessLine(line, fast)
File "/usr/local/google/code/clankium/src/build/android/apk_operations.py", line 595, in ProcessLine
log = self._ParseLine(line)
File "/usr/local/google/code/clankium/src/build/android/apk_operations.py", line 549, in _ParseLine
invokation_time = tokens[1]
IndexError: list index out of range
,
Jan 9
,
Jan 14
,
Jan 17
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/0bb7f9eb2adfeb3a6f5ddac69a17d50109ba74f6 commit 0bb7f9eb2adfeb3a6f5ddac69a17d50109ba74f6 Author: Sky Malice <skym@chromium.org> Date: Thu Jan 17 16:52:47 2019 Stop splitting logcat output on carriage returns. Bug: chromium:919223 Change-Id: I644572c3125f92b81e58bd3c9ee8c516474e1cab Reviewed-on: https://chromium-review.googlesource.com/c/1396738 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> [modify] https://crrev.com/0bb7f9eb2adfeb3a6f5ddac69a17d50109ba74f6/devil/devil/utils/cmd_helper_test.py [modify] https://crrev.com/0bb7f9eb2adfeb3a6f5ddac69a17d50109ba74f6/devil/devil/utils/cmd_helper.py
,
Jan 17
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/8e77731b13637a124d29b756a3e264b9cfcc493d commit 8e77731b13637a124d29b756a3e264b9cfcc493d Author: Caleb Rouleau <crouleau@chromium.org> Date: Thu Jan 17 23:03:39 2019 Revert "Stop splitting logcat output on carriage returns." This reverts commit 0bb7f9eb2adfeb3a6f5ddac69a17d50109ba74f6. Reason for revert: blocking the catapult roll https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-binary-size/138051 jbudorick@ says: "i think method_count needs to be updated; i'm guessing it's trying to match against a line that now has a CR at the end. " Bug: chromium:919223 Original change's description: > Stop splitting logcat output on carriage returns. > > Bug: chromium:919223 > Change-Id: I644572c3125f92b81e58bd3c9ee8c516474e1cab > Reviewed-on: https://chromium-review.googlesource.com/c/1396738 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Sky Malice <skym@chromium.org> TBR=skym@chromium.org,jbudorick@chromium.org Change-Id: Ia1ed6615d6d5d862ab452626f82996a777a2d450 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:919223 Reviewed-on: https://chromium-review.googlesource.com/c/1419080 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> [modify] https://crrev.com/8e77731b13637a124d29b756a3e264b9cfcc493d/devil/devil/utils/cmd_helper_test.py [modify] https://crrev.com/8e77731b13637a124d29b756a3e264b9cfcc493d/devil/devil/utils/cmd_helper.py
,
Jan 18
(4 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c47537d42e1cfb7f3ff655a450fd0b026a15b33b commit c47537d42e1cfb7f3ff655a450fd0b026a15b33b Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Jan 18 11:33:56 2019 Roll src/third_party/catapult a0e5e3328cd7..8e77731b1363 (6 commits) https://chromium.googlesource.com/catapult.git/+log/a0e5e3328cd7..8e77731b1363 git log a0e5e3328cd7..8e77731b1363 --date=short --no-merges --format='%ad %ae %s' 2019-01-17 crouleau@chromium.org Revert "Stop splitting logcat output on carriage returns." 2019-01-17 crouleau@chromium.org Revert "Ignore zeros in Breakdowns." 2019-01-17 uwyiming@google.com Add an option in WPR replay to prefer previously unmatched responses. 2019-01-17 crouleau@chromium.org [Telemetry] Cleanup: Remove unused argument from FindAllBrowserTypes 2019-01-17 uwyiming@google.com Adding uwyiming (myself) as an owner to WPR. 2019-01-17 skym@chromium.org Stop splitting logcat output on carriage returns. Created with: gclient setdep -r src/third_party/catapult@8e77731b1363 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:919223,chromium:919223,chromium:923125, chromium:922734 ,chromium:922828,chromium:919223 TBR=sullivan@chromium.org Change-Id: I7fc110d1697c8624cf391c634fa26204b3bef617 Reviewed-on: https://chromium-review.googlesource.com/c/1419365 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#624077} [modify] https://crrev.com/c47537d42e1cfb7f3ff655a450fd0b026a15b33b/DEPS |
|||
►
Sign in to add a comment |
|||
Comment 1 by jbudorick@chromium.org
, Jan 7Components: -Infra>Client>Chrome