New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 919204 link

Starred by 1 user
Status: Started
Owner:
bokan@chromium.org
Cc:
█ bmcquade@chromium.org
pnoland@chromium.org
ew...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Feature

Blocking:
issue 919589



Sign in to add a comment

Implement Scroll To Text Fragment Feature

Project Member Reported by bokan@chromium.org, Jan 4 
This bug tracks implementing the "Scroll To Text Fragment" feature behind a flag.

In summary, allows specifying in a fragment a block of text to scroll into view and highlight, e.g.:

www.example.com#targetText=alpha%20beta,psi%20omega

Will scroll and highlight a block of text starting with "alpha beta" and ending with "psi omega"

Full Design Doc: https://docs.google.com/document/d/1ftMneoES1_8heCuE5RgU93GjqdEFBAT3ins2ihS0ExA/edit#
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7489b2dc2a1f12b98ecf585fe05654df77c853cb

commit 7489b2dc2a1f12b98ecf585fe05654df77c853cb
Author: David Bokan <bokan@chromium.org>
Date: Fri Jan 11 07:39:28 2019

Refactor Fragment Anchor out of FrameView

Fragment anchors will soon become more complicated and involved than
they already are, see https://crbug.com/919204.

Currently, fragment anchor scrolling is implemented inside
LocalFrameView. There's a significant amount of code here and
implementing new additions here will be rather complicated.

As a first step, this CL consolidates and moves all the related logic
into a new FragmentAnchor class owned by LocalFrameView. This CL should
not have any behavioral changes.

Bug: 919204
Change-Id: I01cd4d08ac8df64eb4fe92f030c466349bf5b96f
Reviewed-on: https://chromium-review.googlesource.com/c/1395893
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621938}
[modify] https://crrev.com/7489b2dc2a1f12b98ecf585fe05654df77c853cb/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/7489b2dc2a1f12b98ecf585fe05654df77c853cb/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/7489b2dc2a1f12b98ecf585fe05654df77c853cb/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/7489b2dc2a1f12b98ecf585fe05654df77c853cb/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/7489b2dc2a1f12b98ecf585fe05654df77c853cb/third_party/blink/renderer/core/page/BUILD.gn
[add] https://crrev.com/7489b2dc2a1f12b98ecf585fe05654df77c853cb/third_party/blink/renderer/core/page/scrolling/fragment_anchor.cc
[add] https://crrev.com/7489b2dc2a1f12b98ecf585fe05654df77c853cb/third_party/blink/renderer/core/page/scrolling/fragment_anchor.h
[modify] https://crrev.com/7489b2dc2a1f12b98ecf585fe05654df77c853cb/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
►

Sign in to add a comment