New issue
Advanced search Search tips

Issue 919157 link

Starred by 1 user
Status: Fixed
Owner:
drubery@chromium.org
Closed: Jan 8
Cc:
vakh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Treat r01, r02, etc. as rar files for download inpsection

Project Member Reported by drubery@chromium.org, Jan 4 
These are multi-part rar files, and we should attempt to inspect their contents.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc32937f9cc7bb1ca82d2ac0c6c7eeb6a2e34462

commit dc32937f9cc7bb1ca82d2ac0c6c7eeb6a2e34462
Author: Daniel Rubery <drubery@chromium.org>
Date: Sat Jan 05 00:21:02 2019

Inspect r00...r29 as RARs

These are multi-part rar archives, and should be inspected as such.

Bug:  919157 
Change-Id: I53ee4aea51f33d7283772e2987fa2ffd66c92e6d
Reviewed-on: https://chromium-review.googlesource.com/c/1396558
Reviewed-by: Nathan Parker <nparker@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620122}
[modify] https://crrev.com/dc32937f9cc7bb1ca82d2ac0c6c7eeb6a2e34462/chrome/browser/resources/safe_browsing/download_file_types.asciipb

Comment 2 by drubery@chromium.org, Jan 5

Status: Fixed (was: Started)

Comment 3 by drubery@chromium.org, Jan 5

Status: Started (was: Fixed)
Just kidding, still need to push this through component update.

Comment 4 by drubery@chromium.org, Jan 7 

There were no crashes in canary over the weekend, so I'm pushing the new download_file_types.asciipb now.

Comment 5 by drubery@chromium.org, Jan 8

Status: Fixed (was: Started)
New download_file_types.asciipb rolled out, so this is now fixed.
►

Sign in to add a comment