New issue
Advanced search Search tips

Issue 919156 link

Starred by 1 user
Status: Fixed
Owner:
dlkumar@google.com
Closed: Jan 7
Cc:
jsaul@google.com
ftirelo@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

[Merge Request M72] Dont make EditText Focusable by default for Autofill fix flow

Project Member Reported by dlkumar@google.com, Jan 4 
Request to merge CL https://chromium-review.googlesource.com/c/chromium/src/+/1395560

2 line change in xml config.

verified in Canary 73

The feature is controlled by project's Finch flag. No other project/feature touches this file.

Thanks!
Project Member

Comment 1 by sheriffbot@chromium.org, Jan 4

Labels: -Merge-Request-72 Merge-Review-72 Hotlist-Merge-Review
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by gov...@chromium.org, Jan 7

Labels: -Merge-Review-72 Merge-Approved-72
Approving merge to M72 branch 3626 based on comment #0. Please merge ASAP so we can pick it up for this week beta release. Thank you.

Comment 3 by gov...@chromium.org, Jan 7 

Pls merge your change to M72 branch 3626 ASAP (latest by 12:00 PM PT, tomorrow, 12/08) so we can pick it up for this week beta release on Wednesday. Thank you.

Comment 4 by dlkumar@google.com, Jan 7

Cc: jsaul@google.com

Comment 5 by jsaul@google.com, Jan 7

Status: Fixed (was: Untriaged)
Merged as https://chromium-review.googlesource.com/c/chromium/src/+/1398511; marking as Fixed.
Project Member

Comment 6 by cr-audit...@appspot.gserviceaccount.com, Jan 7

Labels: -Merge-Approved-72 Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/169c35e6756529544e7fcaaae97a5e3d8380f011

Commit: 169c35e6756529544e7fcaaae97a5e3d8380f011
Author: dlkumar@google.com
Commiter: jsaul@google.com
Date: 2019-01-07 18:27:15 +0000 UTC

Dont make EditText Focusable by default

EditText should not be in focus by default and so move focus to layout instead of edit text.
This makes *hint* grey by default and turns blue when user starts to edit.

UX implementation review deck that has all screenshots

https://docs.google.com/presentation/d/1OTWsG8au8qS7FhcXyvvbOk5fhEmGE5YEEzSGgq9MVKw/edit?ts=5c2ea8b9#slide=id.g404c5faffe_1_12

Bug:  919156 
Change-Id: Ib78771c0a4cdd884505d40f8d723999d91207123
Reviewed-on: https://chromium-review.googlesource.com/c/1395560
Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#620018}(cherry picked from commit c33da1f759175f83ea95000cd44974d9cd80b96f)
Reviewed-on: https://chromium-review.googlesource.com/c/1398511
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/branch-heads/3626@{#593}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 7

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/169c35e6756529544e7fcaaae97a5e3d8380f011

commit 169c35e6756529544e7fcaaae97a5e3d8380f011
Author: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Date: Mon Jan 07 18:27:15 2019

Dont make EditText Focusable by default

EditText should not be in focus by default and so move focus to layout instead of edit text.
This makes *hint* grey by default and turns blue when user starts to edit.

UX implementation review deck that has all screenshots

https://docs.google.com/presentation/d/1OTWsG8au8qS7FhcXyvvbOk5fhEmGE5YEEzSGgq9MVKw/edit?ts=5c2ea8b9#slide=id.g404c5faffe_1_12

Bug:  919156 
Change-Id: Ib78771c0a4cdd884505d40f8d723999d91207123
Reviewed-on: https://chromium-review.googlesource.com/c/1395560
Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#620018}(cherry picked from commit c33da1f759175f83ea95000cd44974d9cd80b96f)
Reviewed-on: https://chromium-review.googlesource.com/c/1398511
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/branch-heads/3626@{#593}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/169c35e6756529544e7fcaaae97a5e3d8380f011/chrome/android/java/res/layout/autofill_name_fixflow.xml
►

Sign in to add a comment