Navi Synthetic Trial Misconfigured |
|||||||||
Issue descriptionSynthetic field trials should not have the same name as the field trial.
,
Jan 4
Requesting merge for this CL. This CL is low risk as it swaps 1 string for another for metrics purposes. This is not a user visible string and is used only to organize metrics.
,
Jan 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/018a54e17a8b7106ec83192a41963c0ddbaa0c1e commit 018a54e17a8b7106ec83192a41963c0ddbaa0c1e Author: Matthew Wolenetz <wolenetz@chromium.org> Date: Fri Jan 04 22:20:07 2019 Revert "Navi: Use a different synthetic trial name than the study." This reverts commit d32c19b4e6973f158c90ad9754bbec02e09fdaa4. Reason for revert: Strongly suspected as the culprit causing compile failure and closing the tree (https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Win/42729) Original change's description: > Navi: Use a different synthetic trial name than the study. > > Bug: 919140 > Change-Id: I9071d768bc5993b78e8114b7a6744d0d40415875 > Reviewed-on: https://chromium-review.googlesource.com/c/1391474 > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Commit-Queue: Hector Carmona <hcarmona@chromium.org> > Cr-Commit-Position: refs/heads/master@{#620071} TBR=asvitkine@chromium.org,dpapad@chromium.org,hcarmona@chromium.org Change-Id: I9f480d4d43f30658916c893020e1b32fcd5ee7ce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 919140 Reviewed-on: https://chromium-review.googlesource.com/c/1396703 Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#620081} [modify] https://crrev.com/018a54e17a8b7106ec83192a41963c0ddbaa0c1e/chrome/browser/ui/webui/welcome/nux_helper.cc
,
Jan 4
Removing merge request until this relands.
,
Jan 4
FYI - #3 fixed the compile regression: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Win/42731
,
Jan 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77ed09dacadb3523047787e6d0eed0cc14b16ef3 commit 77ed09dacadb3523047787e6d0eed0cc14b16ef3 Author: Hector Carmona <hcarmona@chromium.org> Date: Fri Jan 04 23:40:28 2019 Navi: Use a different synthetic trial name than the study. Bug: 919140 Change-Id: Ifc5c680e5e48afd4b0f75d260cd6c277350d5d7b Reviewed-on: https://chromium-review.googlesource.com/c/1396712 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#620107} [modify] https://crrev.com/77ed09dacadb3523047787e6d0eed0cc14b16ef3/chrome/browser/ui/webui/welcome/nux_helper.cc
,
Jan 7
Requesting merge now that this has been landed over the weekend. This CL is low risk as it swaps 1 string for another for metrics purposes. This is not a user visible string and is used only to organize metrics.
,
Jan 7
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 7
branch:3626
,
Jan 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05241c0f2eb0d282a6722858e8be37309c526c03 commit 05241c0f2eb0d282a6722858e8be37309c526c03 Author: Hector Carmona <hcarmona@chromium.org> Date: Mon Jan 07 23:35:06 2019 Navi: Use a different synthetic trial name than the study. Bug: 919140 Change-Id: Ifc5c680e5e48afd4b0f75d260cd6c277350d5d7b Reviewed-on: https://chromium-review.googlesource.com/c/1396712 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#620107}(cherry picked from commit 77ed09dacadb3523047787e6d0eed0cc14b16ef3) Reviewed-on: https://chromium-review.googlesource.com/c/1399703 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#600} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/05241c0f2eb0d282a6722858e8be37309c526c03/chrome/browser/ui/webui/welcome/nux_helper.cc
,
Jan 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05241c0f2eb0d282a6722858e8be37309c526c03 Commit: 05241c0f2eb0d282a6722858e8be37309c526c03 Author: hcarmona@chromium.org Commiter: hcarmona@chromium.org Date: 2019-01-07 23:35:06 +0000 UTC Navi: Use a different synthetic trial name than the study. Bug: 919140 Change-Id: Ifc5c680e5e48afd4b0f75d260cd6c277350d5d7b Reviewed-on: https://chromium-review.googlesource.com/c/1396712 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#620107}(cherry picked from commit 77ed09dacadb3523047787e6d0eed0cc14b16ef3) Reviewed-on: https://chromium-review.googlesource.com/c/1399703 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#600} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Jan 8
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Jan 4