New issue
Advanced search Search tips

Issue 919118 link

Starred by 1 user
Status: Fixed
Owner:
mcasas@chromium.org
Closed: Jan 10
Cc:
fs...@chromium.org
Components:
EstimatedDays: ----
NextAction: 2019-01-17
OS: ----
Pri: 3
Type: Feature

Blocked on:
issue 919116


Sign in to add a comment

Ship CanvasRenderingContext2D.getContextAttributes()

Project Member Reported by mcasas@chromium.org, Jan 4 
CanvasRenderingContext2D.getContextAttributes() is present in the
idl file [1] as an experiment, but is being standarised anyway,
see: https://github.com/whatwg/html/issues/2563 and its associated PR 
https://github.com/whatwg/html/pull/4253.

This bug tracks the code parts of shipping said method (there should
be another blink intent-to-ship or similar superset of this).

[1] https://cs.chromium.org/chromium/src/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.idl?q=canvas+context+2d+idl&sq=package:chromium&dr=C&l=142
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcdadcff6809cbdb0a9f604d773220cfe465c4fa

commit bcdadcff6809cbdb0a9f604d773220cfe465c4fa
Author: Miguel Casas <mcasas@chromium.org>
Date: Thu Jan 10 15:59:14 2019

Canvas context 2D: ship getContextAttributes()

This CL takes getContextAttributes() out of the experiment where
it is on ToT, exposing the alpha attribute only. See the associated
Intent-to-Ship thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/IcxDgEnEEIs/eWc-OXUGDQAJ

Bug:  919118 
Change-Id: I44561ef5906318aa4140eba13410edb716b2701d
Reviewed-on: https://chromium-review.googlesource.com/c/1400761
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621591}
[modify] https://crrev.com/bcdadcff6809cbdb0a9f604d773220cfe465c4fa/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc
[modify] https://crrev.com/bcdadcff6809cbdb0a9f604d773220cfe465c4fa/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.idl
[modify] https://crrev.com/bcdadcff6809cbdb0a9f604d773220cfe465c4fa/third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt

Comment 3 by mcasas@chromium.org, Jan 10

NextAction: 2019-01-17

Comment 4 by monor...@bugs.chromium.org, Jan 17 (5 days ago) 

The NextAction date has arrived: 2019-01-17

Comment 5 by mcasas@chromium.org, Jan 17 (5 days ago) 

#1 landed in 73.0.3668.0
►

Sign in to add a comment