Issue metadata
Sign in to add a comment
|
ChromeBrowserMainBrowserTest.VariationsServiceStartsRequestOnNetworkChange crashing when network service is enabled |
||||||||||||||||||||
Issue descriptionhttps://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8925251906134830352/+/steps/network_service_browser_tests/0/logs/ChromeBrowserMainBrowserTest.VariationsServiceStartsRequestOnNetworkChange__status_CRASH_/0 [ RUN ] ChromeBrowserMainBrowserTest.VariationsServiceStartsRequestOnNetworkChange [1:1:0104/070656.925424:INFO:hugepage_text.cc(68)] Mlocking text pages failed: Cannot allocate memory (12) [25345:25345:0104/070656.960034:WARNING:chrome_browser_main_chromeos.cc(544)] Running as stub user with profile dir: test-user [25345:25345:0104/070656.997481:FATAL:shell.cc(285)] Check failed: instance_. #0 0x55a04ee61a1f base::debug::StackTrace::StackTrace() #1 0x55a04edc3bca logging::LogMessage::~LogMessage() #2 0x55a051d1586d ash::Shell::Get() #3 0x55a051c7efa5 ash::AshService::CreateService() #4 0x55a05008e552 service_manager::mojom::ServiceFactoryStubDispatch::Accept() #5 0x55a04fe00c36 mojo::InterfaceEndpointClient::HandleValidatedMessage() #6 0x55a04fe11816 mojo::FilterChain::Accept() #7 0x55a04fe01fc5 mojo::InterfaceEndpointClient::HandleIncomingMessage() #8 0x55a04fe079f8 mojo::internal::MultiplexRouter::ProcessIncomingMessage() #9 0x55a04fe06e4d mojo::internal::MultiplexRouter::Accept() #10 0x55a04fe11816 mojo::FilterChain::Accept() #11 0x55a04fdfea46 mojo::Connector::ReadSingleMessage() #12 0x55a04fdff441 mojo::Connector::ReadAllAvailableMessages() #13 0x55a04fdff2e9 mojo::Connector::OnHandleReadyInternal() #14 0x55a04c9c8fb7 mojo::SimpleWatcher::DiscardReadyState() #15 0x55a04f50fee2 mojo::SimpleWatcher::OnHandleReady() #16 0x55a04cbeacc1 _ZN4base8internal7InvokerINS0_9BindStateIMN3viz14GpuServiceImplEFvN3gfx21GenericSharedMemoryIdEiRKN3gpu9SyncTokenEEJNS_7WeakPtrIS4_EES6_iS8_EEEFvvEE7RunImplISC_NSt3__15tupleIJSE_S6_iS8_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSJ_16integer_sequenceImJXspT1_EEEE #17 0x55a04ee85171 base::debug::TaskAnnotator::RunTask() #18 0x55a04edcca2f base::MessageLoopImpl::RunTask() #19 0x55a04edcd013 base::MessageLoopImpl::DoWork() #20 0x55a04ee7fd79 base::MessagePumpLibevent::Run() #21 0x55a04edcc5d8 base::MessageLoopImpl::Run() #22 0x55a04edf3909 base::RunLoop::Run() #23 0x55a04a4f0ec4 data_reduction_proxy::(anonymous namespace)::SimulateNetworkChange() #24 0x55a04f4b41ce content::NetworkConnectionChangeSimulator::SetConnectionType() #25 0x55a04ef3493d ChromeBrowserMainParts::ServiceManagerConnectionStarted() #26 0x55a04ceb7c81 content::BrowserMainLoop::InitializeMojo() #27 0x55a04ceb58d9 content::BrowserMainLoop::BrowserThreadsStarted() #28 0x55a04d36edf5 content::StartupTaskRunner::RunAllTasksNow() #29 0x55a04ceb55b5 content::BrowserMainLoop::CreateStartupTasks() #30 0x55a04ceb8a74 content::BrowserMainRunnerImpl::Initialize() #31 0x55a04ceb35d7 content::BrowserMain() #32 0x55a04ea1b4ec content::ContentMainRunnerImpl::RunServiceManager() #33 0x55a04ea1b0f1 content::ContentMainRunnerImpl::Run() #34 0x55a0510d10c3 service_manager::Main() #35 0x55a04ea19724 content::ContentMain() #36 0x55a04f49d0f2 content::BrowserTestBase::SetUp() #37 0x55a04eed9c83 InProcessBrowserTest::SetUp() #38 0x55a04beeb100 testing::Test::Run() #39 0x55a04beebe9f testing::TestInfo::Run() #40 0x55a04beec3f7 testing::TestCase::Run() #41 0x55a04bef7ca7 testing::internal::UnitTestImpl::RunAllTests() #42 0x55a04bef7827 testing::UnitTest::Run() #43 0x55a04eef1359 base::TestSuite::Run() #44 0x55a04ed9fadd ChromeTestSuiteRunner::RunTestSuite() #45 0x55a04f4c1dca content::LaunchTests() #46 0x55a04ed9ff90 LaunchChromeTests() #47 0x55a04ed9fa6e main #48 0x7f1181864f45 __libc_start_main #49 0x55a04a38e8ca _start
,
Jan 4
,
Jan 4
actually, I don't think it has anything to do with Mash (unless it's a result of flipping the default value for the single-process-mash flag?), so re-titling.
,
Jan 4
This test is unusual - it's shimming in an extra ChromeBrowserMainExtraParts. It looks like some test code then spins a message loop midway through browser init. Some earlier piece of code has tickled the ash mojo service, so it tries to create the service and fails because ash::Shell hasn't been constructed yet.
,
Jan 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3d829b43c1fa1a77eb64d3ecbefde7170f20026 commit b3d829b43c1fa1a77eb64d3ecbefde7170f20026 Author: Evan Stade <estade@chromium.org> Date: Fri Jan 04 22:05:16 2019 Disable a test that fails on chromeos with network service. -ChromeBrowserMainBrowserTest.VariationsServiceStartsRequestOnNetworkChange Bug: 919108 Change-Id: Ie98a0e201ff18cfe5f5ca109834327c477be9c3f Reviewed-on: https://chromium-review.googlesource.com/c/1396297 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#620079} [modify] https://crrev.com/b3d829b43c1fa1a77eb64d3ecbefde7170f20026/testing/buildbot/filters/mojo.fyi.chromeos.network_browser_tests.filter
,
Jan 4
oops. The comment in the filter file still mentions mash. Ignore that.
,
Jan 15
can you triage please? let me know if this will block the initial rollout of network service on cros.
,
Jan 15
,
Jan 15
,
Jan 16
This is a test issue and shouldn't block the network service launch.
,
Jan 19
(4 days ago)
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by est...@chromium.org
, Jan 4