New issue
Advanced search Search tips

Issue 919100 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 915360
Owner: ----
Closed: Jan 14
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ForceMaximizeOnFirstRunTest, PRE_TwoRuns is flaky

Project Member Reported by xidac...@chromium.org, Jan 4

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jan 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/799e2b3dc3e8dd228ec8934fa6dffcae7b8c35ce

commit 799e2b3dc3e8dd228ec8934fa6dffcae7b8c35ce
Author: Xida Chen <xidachen@chromium.org>
Date: Fri Jan 04 15:43:39 2019

Disable ForceMaximizeOnFirstRunTest.PRE_TwoRuns on ChromeOs

TBR=maxmorin@chromium.org
NOTRY=true

Bug:  919100 
Change-Id: Ie218eb7ea89b447c9f53d303b5d0d73ed9a9b4c3
Reviewed-on: https://chromium-review.googlesource.com/c/1396226
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619958}
[modify] https://crrev.com/799e2b3dc3e8dd228ec8934fa6dffcae7b8c35ce/chrome/browser/chromeos/policy/force_maximize_on_first_run_chromeos_browsertest.cc

The TwoRuns are flaky too
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e65d5c6dd4a5c99f0ca76cbf415258ee2130c299

commit e65d5c6dd4a5c99f0ca76cbf415258ee2130c299
Author: Xida Chen <xidachen@chromium.org>
Date: Fri Jan 04 16:39:38 2019

Disable ForceMaximizeOnFirstRunTest.TwoRuns on ChromeOS

TBR=maxmorin@chromium.org
NOTRY=true

Bug:  919100 
Change-Id: Iae7d18c3664a0aef21ebee4bc7e5bdcf9ea4a08c
Reviewed-on: https://chromium-review.googlesource.com/c/1396300
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619969}
[modify] https://crrev.com/e65d5c6dd4a5c99f0ca76cbf415258ee2130c299/chrome/browser/chromeos/policy/force_maximize_on_first_run_chromeos_browsertest.cc

Mergedinto: 915360
Status: Duplicate (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a071d93e277ce9b1312c5333c1e9108e5c5fd270

commit a071d93e277ce9b1312c5333c1e9108e5c5fd270
Author: James Cook <jamescook@chromium.org>
Date: Thu Jan 17 17:15:40 2019

Enable tests that were CHECK failing in WebContentsObserverSanityChecker

There's an underlying issue with the is_loading_ cycle in WebContents.
I've removed the check while the root cause is under investigation.
Re-enable tests that were disabled because of this check:

ForceMaximizeOnFirstRunTest.PRE_TwoRuns
ForceMaximizeOnFirstRunTest.TwoRuns
TabRestoreTest.RestoreWindowBounds

Bug: 871010,  919100 , 466089
Test: browser_tests on linux and chromeos
Change-Id: Iaf20faf7f7329044df19aef7df55b50bd8ecaecd
Reviewed-on: https://chromium-review.googlesource.com/c/1409554
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623730}
[modify] https://crrev.com/a071d93e277ce9b1312c5333c1e9108e5c5fd270/chrome/browser/chromeos/policy/force_maximize_on_first_run_chromeos_browsertest.cc
[modify] https://crrev.com/a071d93e277ce9b1312c5333c1e9108e5c5fd270/chrome/browser/sessions/tab_restore_browsertest.cc

Sign in to add a comment