New issue
Advanced search Search tips

Issue 919094 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Enable DCHECK on iOS canary builds

Project Member Reported by justincohen@chromium.org, Jan 4

Issue description

This should give us better coverage on errors we are hitting on devices.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 7

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/bfbd734515d404b53f7e65b95b08cc7abdbe1055

commit bfbd734515d404b53f7e65b95b08cc7abdbe1055
Author: Justin Cohen <justincohen@google.com>
Date: Mon Jan 07 17:13:21 2019

Cc: linds...@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 7

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/9e6d27d9081fc02429cb0467b10b9aa1c2168be9

commit 9e6d27d9081fc02429cb0467b10b9aa1c2168be9
Author: Justin Cohen <justincohen@google.com>
Date: Mon Jan 07 20:01:25 2019

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20b6f0785a9473a9ccdc05a0feb3c3c5716c784c

commit 20b6f0785a9473a9ccdc05a0feb3c3c5716c784c
Author: Justin Cohen <justincohen@google.com>
Date: Wed Jan 16 01:38:50 2019

[ios] Add kDCheckIsFatalFeature feature.

This will be used to enable breakpad uploads for DCHECKs in canary.

Bug: 919094
Change-Id: I8e76db99696e7a948d2d740f0568cba41b1b4dce
Reviewed-on: https://chromium-review.googlesource.com/c/1410992
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622990}
[modify] https://crrev.com/20b6f0785a9473a9ccdc05a0feb3c3c5716c784c/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/20b6f0785a9473a9ccdc05a0feb3c3c5716c784c/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/20b6f0785a9473a9ccdc05a0feb3c3c5716c784c/ios/chrome/browser/ios_chrome_flag_descriptions.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 16 (6 days ago)

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/bc0432494feabae078f193968ac78505a089ed8b

commit bc0432494feabae078f193968ac78505a089ed8b
Author: Justin Cohen <justincohen@google.com>
Date: Wed Jan 16 15:48:35 2019

Sign in to add a comment