New issue
Advanced search Search tips

Issue 919093 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 14
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add builbucket_service for catapult command line tools

Project Member Reported by perezju@chromium.org, Jan 4

Issue description

The service can use go/buildbucket-rpc to request information about
builders and builds in out waterfalls.
 
what is buildbucket_service? if you are thinking of creating a generic client that might be useful for others as well, let's talk.
I don't have in mind making this a super generic/reusable client. At least not from the start.

These "services" in:
https://cs.chromium.org/chromium/src/third_party/catapult/experimental/soundwave/services/

are all just thin wrappers around APIs for services in speed/benchmarking we use to write some command line tools (e.g. pinpoint_cli to start pinpoint try jobs, or soundwave to get data from chrome perf dashboard).

As an example of a tool I'm hoping to write (I had an equivalent in the older buildbot world) is a "grep" like tool to look through the logs of recent runs of a particular benchmark or test case to search e.g. for a particular error message and figure out where it started occurring. But that will be pretty much tied to how performance_test_suite works, so not really that general.

Anyway, happy to set a GVC meeting if you want to talk more.
i see. For prpc protocol, here is a reference implementation https://cs.chromium.org/chromium/infra/luci/appengine/components/components/prpc/client.py
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/89411cacdcc25db039c69a5facc00299aa2c35df

commit 89411cacdcc25db039c69a5facc00299aa2c35df
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Mon Jan 14 11:06:36 2019

[cli services] Add buildbucket_service

The service will be used to access information about builds and builders
running in our waterfalls.

Also removing the old (unfinished) version based on legacy buildbot
APIs.

Bug:  chromium:919093 
Change-Id: I93abce5d6eee7f889236f6eb6924e003d57504ab
Reviewed-on: https://chromium-review.googlesource.com/c/1396159
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>

[delete] https://crrev.com/030e4644c80d04cb3f75f6e1cec22583a1592f00/experimental/qbot/qbot/build_model.py
[add] https://crrev.com/89411cacdcc25db039c69a5facc00299aa2c35df/experimental/soundwave/services/buildbucket_service.py
[delete] https://crrev.com/030e4644c80d04cb3f75f6e1cec22583a1592f00/experimental/qbot/example.py
[add] https://crrev.com/89411cacdcc25db039c69a5facc00299aa2c35df/experimental/soundwave/services/buildbucket_service_test.py
[delete] https://crrev.com/030e4644c80d04cb3f75f6e1cec22583a1592f00/experimental/qbot/qbot/builder_model.py
[delete] https://crrev.com/030e4644c80d04cb3f75f6e1cec22583a1592f00/experimental/qbot/README.md
[delete] https://crrev.com/030e4644c80d04cb3f75f6e1cec22583a1592f00/experimental/qbot/qbot/api.py
[delete] https://crrev.com/030e4644c80d04cb3f75f6e1cec22583a1592f00/experimental/qbot/qbot/__init__.py

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9d39cb7402e371e19d1485f07270953c266d4cd

commit c9d39cb7402e371e19d1485f07270953c266d4cd
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Jan 16 02:43:37 2019

Roll src/third_party/catapult 96320b515106..78448d90081e (17 commits)

https://chromium.googlesource.com/catapult.git/+log/96320b515106..78448d90081e


git log 96320b515106..78448d90081e --date=short --no-merges --format='%ad %ae %s'
2019-01-15 vollick@chromium.org Plumb the trace buffer size for atrace
2019-01-15 perezju@chromium.org Revert "[py_utils] Add modules_util.RequireVersion"
2019-01-15 taylori@google.com Fix handling of perfetto protobuf on mac
2019-01-15 perezju@chromium.org [dashboard] Remove dead code in start_try_job.py
2019-01-15 perezju@chromium.org Revert "Remove TagMap."
2019-01-15 perezju@chromium.org [Telemetry] Add list_of_scalar_values.mean
2019-01-15 dtu@chromium.org [pinpoint] Add Tags field to try job dialog.
2019-01-15 dtu@chromium.org [pinpoint] Ignore cached isolate hashes over 8 weeks old.
2019-01-14 eroman@chromium.org Fix import of new NetExport generated logs.
2019-01-14 bsheedy@chromium.org Fix gtest conversion multiplier
2019-01-14 eyaich@google.com Adding timeToFirstViewportReady metric
2019-01-14 perezju@chromium.org [py_utils] Add modules_util.RequireVersion
2019-01-14 perezju@chromium.org Remove GetNetworkData methods
2019-01-14 perezju@chromium.org [cli services] Add buildbucket_service
2019-01-14 perezju@chromium.org [Telemetry] Remove TBMv1 metrics.SmoothnessMetric
2019-01-11 benjhayden@chromium.org Remove TagMap.
2019-01-11 benjhayden@chromium.org Truncate serialized floats in HistogramSet JSON.


Created with:
  gclient setdep -r src/third_party/catapult@78448d90081e

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:776709,chromium:777865,chromium:918218,chromium:921616,chromium:874940,chromium:916877, chromium:917273 ,chromium:921342,chromium:904879,chromium:776709,chromium:777865,chromium:480512, chromium:919093 , chromium:691581 ,chromium:921000,chromium:918218,chromium:918208
TBR=sullivan@chromium.org

Change-Id: I75c07d8719f5668f9b4a95a9757cf6c25412b547
Reviewed-on: https://chromium-review.googlesource.com/c/1413252
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#623062}
[modify] https://crrev.com/c9d39cb7402e371e19d1485f07270953c266d4cd/DEPS

Sign in to add a comment