New issue
Advanced search Search tips

Issue 919089 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::WebElement::HasHTMLTagName

Project Member Reported by ClusterFuzz, Jan 4

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5739710806491136

Fuzzer: puzzor
Job Type: linux_ubsan_vptr_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  blink::WebElement::HasHTMLTagName
  autofill::form_util::InferButtonTitlesForForm
  autofill::form_util::UnownedFormElementsAndFieldSetsToFormData
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=619898:619899

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5739710806491136

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for instructions to reproduce this bug locally.
 
Project Member

Comment 1 by ClusterFuzz, Jan 4

Labels: OS-Windows
Project Member

Comment 2 by ClusterFuzz, Jan 4

Components: Blink UI>Browser>Autofill
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 3 by ClusterFuzz, Jan 4

Labels: Test-Predator-Auto-Owner
Owner: kolos@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/aba15f91a3d6563d2af8574528a096e2023d9146 ([Password Generation] Crowdsource button titles for <form>less forms.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Cc: kolos@chromium.org
 Issue 919105  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1abb542130f5607a0233d5f741bc28d07fbeb11

commit c1abb542130f5607a0233d5f741bc28d07fbeb11
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Fri Jan 04 16:18:10 2019

[Password Generation] Missed <body> tag shouldn't crash button titles detection

Bug:  919089 ,  919088 , 910546
Change-Id: I0ce5a28ccf7f13cfa6fda547b628fbe6cf4d9a83
Reviewed-on: https://chromium-review.googlesource.com/c/1396032
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619965}
[modify] https://crrev.com/c1abb542130f5607a0233d5f741bc28d07fbeb11/components/autofill/content/renderer/form_autofill_util.cc

Status: Fixed (was: Assigned)
Issue 919226 has been merged into this issue.
Project Member

Comment 8 by ClusterFuzz, Jan 5

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 4868769520025600 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 9 by ClusterFuzz, Jan 5

ClusterFuzz has detected this issue as fixed in range 619964:619965.

Detailed report: https://clusterfuzz.com/testcase?key=5739710806491136

Fuzzer: puzzor
Job Type: linux_ubsan_vptr_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  blink::WebElement::HasHTMLTagName
  autofill::form_util::InferButtonTitlesForForm
  autofill::form_util::UnownedFormElementsAndFieldSetsToFormData
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=619898:619899
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=619964:619965

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5739710806491136

See https://github.com/google/clusterfuzz-tools for instructions to reproduce this bug locally.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Sign in to add a comment