New issue
Advanced search Search tips

Issue 919085 link

Starred by 1 user
Status: Assigned
Owner:
mbonadei@chromium.org
Cc:
oprypin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Break the dependency between //third_party/libjingle_xmpp and WebRTC

Project Member Reported by mbonadei@chromium.org, Jan 4 
For historical reasons these two projects are related to each other but as of today there is no need for https://cs.chromium.org/chromium/src/third_party/libjingle_xmpp/ to depend on WebRTC.

The dependencies are almost only on rtc_base stuff, like RTC_CHECK and RTC_LOG.

This bug tracks the effort of cleaning up this dependency.

As of today this situation creates some problems because https://cs.chromium.org/chromium/src/third_party/libjingle_xmpp/ uses rtc_* GN templates declared in . https://cs.chromium.org/chromium/src/third_party/webrtc/webrtc.gni and this means that every change made to these templates affects libjingle_xmpp.

Today I was trying to limit the visibility of WebRTC targets when WebRTC is built with Chromium (to make component builds maintainable) but I ended up breaking libjingle_xmpp.

Comment 1 by mbonadei@chromium.org, Jan 4

Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e5b3d54483039ad20d7fb808b0c48f90fc7eb52

commit 8e5b3d54483039ad20d7fb808b0c48f90fc7eb52
Author: Mirko Bonadei <mbonadei@chromium.org>
Date: Mon Jan 07 07:55:23 2019

Fix header guards in libjingle_xmpp/xmpp.

Bug: 919085
Change-Id: I2898d14b152559bfa96036fbcce012553690f926
Reviewed-on: https://chromium-review.googlesource.com/c/1396147
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620270}
[modify] https://crrev.com/8e5b3d54483039ad20d7fb808b0c48f90fc7eb52/third_party/libjingle_xmpp/xmpp/asyncsocket.h
[modify] https://crrev.com/8e5b3d54483039ad20d7fb808b0c48f90fc7eb52/third_party/libjingle_xmpp/xmpp/constants.h
[modify] https://crrev.com/8e5b3d54483039ad20d7fb808b0c48f90fc7eb52/third_party/libjingle_xmpp/xmpp/fakexmppclient.h
[modify] https://crrev.com/8e5b3d54483039ad20d7fb808b0c48f90fc7eb52/third_party/libjingle_xmpp/xmpp/jid.h
[modify] https://crrev.com/8e5b3d54483039ad20d7fb808b0c48f90fc7eb52/third_party/libjingle_xmpp/xmpp/jingleinfotask.h
[modify] https://crrev.com/8e5b3d54483039ad20d7fb808b0c48f90fc7eb52/third_party/libjingle_xmpp/xmpp/plainsaslhandler.h
[modify] https://crrev.com/8e5b3d54483039ad20d7fb808b0c48f90fc7eb52/third_party/libjingle_xmpp/xmpp/prexmppauth.h
[modify] https://crrev.com/8e5b3d54483039ad20d7fb808b0c48f90fc7eb52/third_party/libjingle_xmpp/xmpp/saslcookiemechanism.h
[modify] https://crrev.com/8e5b3d54483039ad20d7fb808b0c48f90fc7eb52/third_party/libjingle_xmpp/xmpp/saslhandler.h
[modify] https://crrev.com/8e5b3d54483039ad20d7fb808b0c48f90fc7eb52/third_party/libjingle_xmpp/xmpp/saslmechanism.h
[modify] https://crrev.com/8e5b3d54483039ad20d7fb808b0c48f90fc7eb52/third_party/libjingle_xmpp/xmpp/saslplainmechanism.h
[modify] https://crrev.com/8e5b3d54483039ad20d7fb808b0c48f90fc7eb52/third_party/libjingle_xmpp/xmpp/util_unittest.h
[modify] https://crrev.com/8e5b3d54483039ad20d7fb808b0c48f90fc7eb52/third_party/libjingle_xmpp/xmpp/xmppclient.h
[modify] https://crrev.com/8e5b3d54483039ad20d7fb808b0c48f90fc7eb52/third_party/libjingle_xmpp/xmpp/xmppclientsettings.h
[modify] https://crrev.com/8e5b3d54483039ad20d7fb808b0c48f90fc7eb52/third_party/libjingle_xmpp/xmpp/xmppengine.h
[modify] https://crrev.com/8e5b3d54483039ad20d7fb808b0c48f90fc7eb52/third_party/libjingle_xmpp/xmpp/xmppengineimpl.h
[modify] https://crrev.com/8e5b3d54483039ad20d7fb808b0c48f90fc7eb52/third_party/libjingle_xmpp/xmpp/xmpplogintask.h
[modify] https://crrev.com/8e5b3d54483039ad20d7fb808b0c48f90fc7eb52/third_party/libjingle_xmpp/xmpp/xmppstanzaparser.h
[modify] https://crrev.com/8e5b3d54483039ad20d7fb808b0c48f90fc7eb52/third_party/libjingle_xmpp/xmpp/xmpptask.h
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9642125b378ab46ecc5bf6c7d41b31a4bb0548c8

commit 9642125b378ab46ecc5bf6c7d41b31a4bb0548c8
Author: Mirko Bonadei <mbonadei@chromium.org>
Date: Mon Jan 07 08:58:24 2019

Stop using WebRTC's gtest wrapper.

First on many CLs to reduce the dependencies of libjingle_xmpp on
WebRTC.

There is no need to use the WebRTC's gtest wrapper so this CL makes
libjingle_xmpp depend directly on gtest.

Bug: 919085
Change-Id: I9375de48c66e438447f4ec39f2c9dd921b00ce58
Reviewed-on: https://chromium-review.googlesource.com/c/1396029
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620276}
[modify] https://crrev.com/9642125b378ab46ecc5bf6c7d41b31a4bb0548c8/third_party/libjingle_xmpp/BUILD.gn
[modify] https://crrev.com/9642125b378ab46ecc5bf6c7d41b31a4bb0548c8/third_party/libjingle_xmpp/DEPS
[modify] https://crrev.com/9642125b378ab46ecc5bf6c7d41b31a4bb0548c8/third_party/libjingle_xmpp/task_runner/task_unittest.cc
[modify] https://crrev.com/9642125b378ab46ecc5bf6c7d41b31a4bb0548c8/third_party/libjingle_xmpp/xmllite/qname_unittest.cc
[modify] https://crrev.com/9642125b378ab46ecc5bf6c7d41b31a4bb0548c8/third_party/libjingle_xmpp/xmllite/xmlbuilder_unittest.cc
[modify] https://crrev.com/9642125b378ab46ecc5bf6c7d41b31a4bb0548c8/third_party/libjingle_xmpp/xmllite/xmlelement_unittest.cc
[modify] https://crrev.com/9642125b378ab46ecc5bf6c7d41b31a4bb0548c8/third_party/libjingle_xmpp/xmllite/xmlnsstack_unittest.cc
[modify] https://crrev.com/9642125b378ab46ecc5bf6c7d41b31a4bb0548c8/third_party/libjingle_xmpp/xmllite/xmlparser_unittest.cc
[modify] https://crrev.com/9642125b378ab46ecc5bf6c7d41b31a4bb0548c8/third_party/libjingle_xmpp/xmllite/xmlprinter_unittest.cc
[modify] https://crrev.com/9642125b378ab46ecc5bf6c7d41b31a4bb0548c8/third_party/libjingle_xmpp/xmpp/jid_unittest.cc
[modify] https://crrev.com/9642125b378ab46ecc5bf6c7d41b31a4bb0548c8/third_party/libjingle_xmpp/xmpp/util_unittest.cc
[modify] https://crrev.com/9642125b378ab46ecc5bf6c7d41b31a4bb0548c8/third_party/libjingle_xmpp/xmpp/xmppengine_unittest.cc
[modify] https://crrev.com/9642125b378ab46ecc5bf6c7d41b31a4bb0548c8/third_party/libjingle_xmpp/xmpp/xmpplogintask_unittest.cc
[modify] https://crrev.com/9642125b378ab46ecc5bf6c7d41b31a4bb0548c8/third_party/libjingle_xmpp/xmpp/xmppstanzaparser_unittest.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3803455a8f665aa8e5e84a094cdfba6e7aa3547e

commit 3803455a8f665aa8e5e84a094cdfba6e7aa3547e
Author: Mirko Bonadei <mbonadei@chromium.org>
Date: Mon Jan 07 12:26:09 2019

Fix header guards in libjingle_xmpp/task_runner.

Bug: 919085
Change-Id: I7f9b3eaf5d2a0832715f1fdc777007ff2a0c7c5e
Reviewed-on: https://chromium-review.googlesource.com/c/1397603
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620295}
[modify] https://crrev.com/3803455a8f665aa8e5e84a094cdfba6e7aa3547e/third_party/libjingle_xmpp/task_runner/task.h
[modify] https://crrev.com/3803455a8f665aa8e5e84a094cdfba6e7aa3547e/third_party/libjingle_xmpp/task_runner/taskparent.h
[modify] https://crrev.com/3803455a8f665aa8e5e84a094cdfba6e7aa3547e/third_party/libjingle_xmpp/task_runner/taskrunner.h
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09482f57fa4b43b2a70f74fcb8d67113c2faea54

commit 09482f57fa4b43b2a70f74fcb8d67113c2faea54
Author: Mirko Bonadei <mbonadei@chromium.org>
Date: Mon Jan 07 13:17:22 2019

Remove -Wno-error when building for Android.

Bug: 919085
Change-Id: I5d4d56a67958ace54a6e89cc7e3f20387d457d96
Reviewed-on: https://chromium-review.googlesource.com/c/1396149
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620305}
[modify] https://crrev.com/09482f57fa4b43b2a70f74fcb8d67113c2faea54/third_party/libjingle_xmpp/BUILD.gn
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e2c92ee25ff1dae60a4efdf7b0aacd8ea05a206

commit 7e2c92ee25ff1dae60a4efdf7b0aacd8ea05a206
Author: Mirko Bonadei <mbonadei@chromium.org>
Date: Mon Jan 07 18:00:49 2019

Remove files that are never built.

These files are not built because they are not part or any GN target.

Bug: 919085
Change-Id: Ibd73d5176487a564c3033841213231aeb50c2b98
Reviewed-on: https://chromium-review.googlesource.com/c/1397984
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620374}
[delete] https://crrev.com/3f506bc44cf5a6c0c7c0058b5f7ab31eead19fbd/third_party/libjingle_xmpp/xmpp/jingleinfotask.cc
[delete] https://crrev.com/3f506bc44cf5a6c0c7c0058b5f7ab31eead19fbd/third_party/libjingle_xmpp/xmpp/jingleinfotask.h
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b46878a5977fee39e292a743882352ef6893afb

commit 8b46878a5977fee39e292a743882352ef6893afb
Author: Mirko Bonadei <mbonadei@chromium.org>
Date: Tue Jan 08 16:28:39 2019

Stop using WEBRTC_ macros to detect the target OS.

Bug: 919085
Change-Id: I925f6af3347c6630259b4ef48b15e9b4fbcc1efb
Reviewed-on: https://chromium-review.googlesource.com/c/1397605
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620750}
[modify] https://crrev.com/8b46878a5977fee39e292a743882352ef6893afb/third_party/libjingle_xmpp/BUILD.gn
[modify] https://crrev.com/8b46878a5977fee39e292a743882352ef6893afb/third_party/libjingle_xmpp/task_runner/task_unittest.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f32093e4b9ec4738fbc6a654a37f64fdad304164

commit f32093e4b9ec4738fbc6a654a37f64fdad304164
Author: Mirko Bonadei <mbonadei@chromium.org>
Date: Tue Jan 08 18:22:08 2019

Stop using RTC_DCHECK/RTC_DISALLOW_COPY_AND_ASSIGN in libjingle_xmpp.

Since libjingle_xmpp is only used in Chromium there is no need to
rely on RTC_DCHECK/RTC_DISALLOW_COPY_AND_ASSIGN but it is better to
use Chromium's DCHECK/DISALLOW_COPY_AND_ASSIGN directly.

Bug: 919085
Change-Id: Ic0b7f1518ac51db216d436747a6f88361b3e3998
Reviewed-on: https://chromium-review.googlesource.com/c/1396126
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620800}
[modify] https://crrev.com/f32093e4b9ec4738fbc6a654a37f64fdad304164/third_party/libjingle_xmpp/BUILD.gn
[modify] https://crrev.com/f32093e4b9ec4738fbc6a654a37f64fdad304164/third_party/libjingle_xmpp/DEPS
[modify] https://crrev.com/f32093e4b9ec4738fbc6a654a37f64fdad304164/third_party/libjingle_xmpp/task_runner/task.cc
[modify] https://crrev.com/f32093e4b9ec4738fbc6a654a37f64fdad304164/third_party/libjingle_xmpp/task_runner/task_unittest.cc
[modify] https://crrev.com/f32093e4b9ec4738fbc6a654a37f64fdad304164/third_party/libjingle_xmpp/task_runner/taskparent.cc
[modify] https://crrev.com/f32093e4b9ec4738fbc6a654a37f64fdad304164/third_party/libjingle_xmpp/task_runner/taskparent.h
[modify] https://crrev.com/f32093e4b9ec4738fbc6a654a37f64fdad304164/third_party/libjingle_xmpp/task_runner/taskrunner.cc
[modify] https://crrev.com/f32093e4b9ec4738fbc6a654a37f64fdad304164/third_party/libjingle_xmpp/task_runner/taskrunner.h
[modify] https://crrev.com/f32093e4b9ec4738fbc6a654a37f64fdad304164/third_party/libjingle_xmpp/xmllite/xmlelement.cc
[modify] https://crrev.com/f32093e4b9ec4738fbc6a654a37f64fdad304164/third_party/libjingle_xmpp/xmpp/jid.cc
[modify] https://crrev.com/f32093e4b9ec4738fbc6a654a37f64fdad304164/third_party/libjingle_xmpp/xmpp/xmppengineimpl.cc
[modify] https://crrev.com/f32093e4b9ec4738fbc6a654a37f64fdad304164/third_party/libjingle_xmpp/xmpp/xmpptask.h
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bff08443a02f0e04a334b72db515cdcbaaf5e97e

commit bff08443a02f0e04a334b72db515cdcbaaf5e97e
Author: Mirko Bonadei <mbonadei@chromium.org>
Date: Wed Jan 09 14:05:44 2019

Stop using WebRTC's arraysize.

Bug: 919085
Change-Id: Ic2dfbc4924b7b98d1050c82b27e012412ebaee24
Reviewed-on: https://chromium-review.googlesource.com/c/1397623
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621135}
[modify] https://crrev.com/bff08443a02f0e04a334b72db515cdcbaaf5e97e/third_party/libjingle_xmpp/DEPS
[modify] https://crrev.com/bff08443a02f0e04a334b72db515cdcbaaf5e97e/third_party/libjingle_xmpp/task_runner/task_unittest.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7732d36e9bb0b76fedb6e873b727a23efcb8ec03

commit 7732d36e9bb0b76fedb6e873b727a23efcb8ec03
Author: Mirko Bonadei <mbonadei@chromium.org>
Date: Thu Jan 10 07:08:39 2019

Stop using RTC_LOG and rtc::ConstantLabels machinery.

Instead of RTC_LOG, this CL switches libjingle_xmpp to DVLOG(1).

This also removes a convoluted error message lookup machinery in
third_party/libjingle_xmpp/xmpp/xmpplogintask.cc.


Bug: 919085
Change-Id: Id8f24dd3a4907923c0c5d4ea2fee0a68d266d5bc
Reviewed-on: https://chromium-review.googlesource.com/c/1397607
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621491}
[modify] https://crrev.com/7732d36e9bb0b76fedb6e873b727a23efcb8ec03/third_party/libjingle_xmpp/task_runner/task_unittest.cc
[modify] https://crrev.com/7732d36e9bb0b76fedb6e873b727a23efcb8ec03/third_party/libjingle_xmpp/xmpp/jid.cc
[modify] https://crrev.com/7732d36e9bb0b76fedb6e873b727a23efcb8ec03/third_party/libjingle_xmpp/xmpp/xmppclient.cc
[modify] https://crrev.com/7732d36e9bb0b76fedb6e873b727a23efcb8ec03/third_party/libjingle_xmpp/xmpp/xmpplogintask.cc
[modify] https://crrev.com/7732d36e9bb0b76fedb6e873b727a23efcb8ec03/third_party/libjingle_xmpp/xmpp/xmpplogintask.h
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a589b0923807565a2e799b352314118f66d3052b

commit a589b0923807565a2e799b352314118f66d3052b
Author: Mirko Bonadei <mbonadei@chromium.org>
Date: Thu Jan 10 09:44:25 2019

Remove dependency on rtc::ProxyType and cricket::ProtocolType.

Instead of sharing the enum types rtc::ProxyType and
cricket::ProtocolType with WebRTC, libjingle_xmpp now has a copy of
these emums.

This CL also updates the only place where a method affected by this
change was invoked.

Bug: 919085
Change-Id: I28a94d0f6f141eb2418e71a4ac783f98d8651e50
Reviewed-on: https://chromium-review.googlesource.com/c/1398082
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621524}
[modify] https://crrev.com/a589b0923807565a2e799b352314118f66d3052b/jingle/notifier/base/xmpp_connection.cc
[modify] https://crrev.com/a589b0923807565a2e799b352314118f66d3052b/jingle/notifier/communicator/connection_settings.cc
[modify] https://crrev.com/a589b0923807565a2e799b352314118f66d3052b/third_party/libjingle_xmpp/xmpp/xmppclientsettings.h
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/812090c2c8488456a0ffd08e722a80f52c3b3a8e

commit 812090c2c8488456a0ffd08e722a80f52c3b3a8e
Author: Mirko Bonadei <mbonadei@chromium.org>
Date: Thu Jan 10 22:25:47 2019

Remove dead code from XmppClientSettings.

Follow-up of crrev.com/c/1398082.

Bug: 919085
Change-Id: Ie07252fa653f8a453112a4fdaea960a05d6aaec6
Reviewed-on: https://chromium-review.googlesource.com/c/1404267
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621777}
[modify] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/third_party/libjingle_xmpp/xmpp/xmppclient.cc
[modify] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/third_party/libjingle_xmpp/xmpp/xmppclientsettings.h
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a0f1a106e88bdc75e504a8f7e7fc319f92575d3

commit 5a0f1a106e88bdc75e504a8f7e7fc319f92575d3
Author: Mirko Bonadei <mbonadei@chromium.org>
Date: Thu Jan 10 23:09:43 2019

Remove rtc::SocketAddress from PreXmppAuth::StartPreXmppAuth.

The end goal is to stop using rtc::SocketAddress in libjingle_xmpp,
it seems that PreXmppAuth::StartPreXmppAuth doesn't use this parameter
so this CL removes it.

It seems that a deeper refactoring is needed, most of the parameters
are unused.

Bug: 919085
Change-Id: I5039296580995303cc0df3a2a89ac75bbc0a669a
Reviewed-on: https://chromium-review.googlesource.com/c/1405322
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621793}
[modify] https://crrev.com/5a0f1a106e88bdc75e504a8f7e7fc319f92575d3/jingle/notifier/base/gaia_token_pre_xmpp_auth.cc
[modify] https://crrev.com/5a0f1a106e88bdc75e504a8f7e7fc319f92575d3/jingle/notifier/base/gaia_token_pre_xmpp_auth.h
[modify] https://crrev.com/5a0f1a106e88bdc75e504a8f7e7fc319f92575d3/jingle/notifier/base/xmpp_connection_unittest.cc
[modify] https://crrev.com/5a0f1a106e88bdc75e504a8f7e7fc319f92575d3/third_party/libjingle_xmpp/xmpp/prexmppauth.h
[modify] https://crrev.com/5a0f1a106e88bdc75e504a8f7e7fc319f92575d3/third_party/libjingle_xmpp/xmpp/xmppclient.cc
Project Member

Comment 16 by bugdroid1@chromium.org, Jan 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0802fdb51fe3a158b3fa924601547f0ea971ca11

commit 0802fdb51fe3a158b3fa924601547f0ea971ca11
Author: Mirko Bonadei <mbonadei@chromium.org>
Date: Mon Jan 14 07:19:41 2019

Remove XmlElementTest.

Bug: 919085
Change-Id: I2cb61c39018e08cce1087834507f55136481fc06
Reviewed-on: https://chromium-review.googlesource.com/c/1404273
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622390}
[modify] https://crrev.com/0802fdb51fe3a158b3fa924601547f0ea971ca11/third_party/libjingle_xmpp/xmllite/xmlelement_unittest.cc
Project Member

Comment 17 by bugdroid1@chromium.org, Jan 16 (6 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c6ffe77dfcae9d253da277a3ad2c25c589c1661

commit 4c6ffe77dfcae9d253da277a3ad2c25c589c1661
Author: Mirko Bonadei <mbonadei@chromium.org>
Date: Wed Jan 16 18:31:24 2019

Remove usage of rtc::SocketAddress.

Instead of using the WebRTC version of SocketAddress, uses
net::HostPortPair.

Notably, it removes support for IPs but it seems like hostnames were
already the only supported way to specify an address (see the
now deleted test NetworkServiceAsyncSocketTest.NoHostnameConnect).

Bug: 919085
Change-Id: I58dfd6876ffe07a89726edb5d4868518addcf386
Reviewed-on: https://chromium-review.googlesource.com/c/1409303
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623305}
[modify] https://crrev.com/4c6ffe77dfcae9d253da277a3ad2c25c589c1661/jingle/glue/network_service_async_socket.cc
[modify] https://crrev.com/4c6ffe77dfcae9d253da277a3ad2c25c589c1661/jingle/glue/network_service_async_socket.h
[modify] https://crrev.com/4c6ffe77dfcae9d253da277a3ad2c25c589c1661/jingle/glue/network_service_async_socket_unittest.cc
[modify] https://crrev.com/4c6ffe77dfcae9d253da277a3ad2c25c589c1661/jingle/notifier/base/fake_base_task.cc
[modify] https://crrev.com/4c6ffe77dfcae9d253da277a3ad2c25c589c1661/jingle/notifier/communicator/connection_settings.cc
[modify] https://crrev.com/4c6ffe77dfcae9d253da277a3ad2c25c589c1661/jingle/notifier/communicator/connection_settings.h
[modify] https://crrev.com/4c6ffe77dfcae9d253da277a3ad2c25c589c1661/jingle/notifier/communicator/connection_settings_unittest.cc
[modify] https://crrev.com/4c6ffe77dfcae9d253da277a3ad2c25c589c1661/third_party/libjingle_xmpp/BUILD.gn
[modify] https://crrev.com/4c6ffe77dfcae9d253da277a3ad2c25c589c1661/third_party/libjingle_xmpp/DEPS
[modify] https://crrev.com/4c6ffe77dfcae9d253da277a3ad2c25c589c1661/third_party/libjingle_xmpp/xmpp/asyncsocket.h
[modify] https://crrev.com/4c6ffe77dfcae9d253da277a3ad2c25c589c1661/third_party/libjingle_xmpp/xmpp/prexmppauth.h
[modify] https://crrev.com/4c6ffe77dfcae9d253da277a3ad2c25c589c1661/third_party/libjingle_xmpp/xmpp/xmppclient.cc
[modify] https://crrev.com/4c6ffe77dfcae9d253da277a3ad2c25c589c1661/third_party/libjingle_xmpp/xmpp/xmppclientsettings.h
Project Member

Comment 18 by bugdroid1@chromium.org, Jan 16 (6 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d222ac4eca88a948fefda6674cb9b08988dac628

commit d222ac4eca88a948fefda6674cb9b08988dac628
Author: Mirko Bonadei <mbonadei@chromium.org>
Date: Wed Jan 16 23:19:34 2019

Remove inclusion of webrtc/p2p/base/port.h.

Bug: 919085
Change-Id: Iafc49f41db75aa2200c5540b46f12a632b09cec9
Reviewed-on: https://chromium-review.googlesource.com/c/1416130
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623438}
[modify] https://crrev.com/d222ac4eca88a948fefda6674cb9b08988dac628/third_party/libjingle_xmpp/xmpp/xmppclientsettings.h
Project Member

Comment 19 by bugdroid1@chromium.org, Jan 17 (5 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c55ccac71d53a193ea3846e85b98e2c1b4f28cb4

commit c55ccac71d53a193ea3846e85b98e2c1b4f28cb4
Author: Mirko Bonadei <mbonadei@chromium.org>
Date: Thu Jan 17 10:37:46 2019

Remove dependency on webrtc/rtc_base/time_utils.h.

Since the only user of the libjingle task runner doesn't use timeout
tasks, this CL removes the code needed to support timeout tasks
in order to remove a dependency on WebRTC's time_utils.h.

Bug: 919085
Change-Id: Ia013cb54d253f2277448351d1c64eeac3c8a26ca
Reviewed-on: https://chromium-review.googlesource.com/c/1415411
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623635}
[modify] https://crrev.com/c55ccac71d53a193ea3846e85b98e2c1b4f28cb4/jingle/glue/task_pump.cc
[modify] https://crrev.com/c55ccac71d53a193ea3846e85b98e2c1b4f28cb4/jingle/glue/task_pump.h
[modify] https://crrev.com/c55ccac71d53a193ea3846e85b98e2c1b4f28cb4/third_party/libjingle_xmpp/task_runner/task.cc
[modify] https://crrev.com/c55ccac71d53a193ea3846e85b98e2c1b4f28cb4/third_party/libjingle_xmpp/task_runner/task.h
[modify] https://crrev.com/c55ccac71d53a193ea3846e85b98e2c1b4f28cb4/third_party/libjingle_xmpp/task_runner/task_unittest.cc
[modify] https://crrev.com/c55ccac71d53a193ea3846e85b98e2c1b4f28cb4/third_party/libjingle_xmpp/task_runner/taskrunner.cc
[modify] https://crrev.com/c55ccac71d53a193ea3846e85b98e2c1b4f28cb4/third_party/libjingle_xmpp/task_runner/taskrunner.h
Project Member

Comment 20 by bugdroid1@chromium.org, Jan 18 (4 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d19f43d2663ceb64157f6388a95e70c3a3bfd6a7

commit d19f43d2663ceb64157f6388a95e70c3a3bfd6a7
Author: Mirko Bonadei <mbonadei@chromium.org>
Date: Fri Jan 18 19:41:59 2019

Remove dependency on webrtc/rtc_base/thread.h.

Bug: 919085
No-Presubmit: true
Change-Id: Id4883aad5209299ae337b3c9a94e5619ba18a000
Reviewed-on: https://chromium-review.googlesource.com/c/1417530
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624242}
[modify] https://crrev.com/d19f43d2663ceb64157f6388a95e70c3a3bfd6a7/third_party/libjingle_xmpp/task_runner/DEPS
[modify] https://crrev.com/d19f43d2663ceb64157f6388a95e70c3a3bfd6a7/third_party/libjingle_xmpp/task_runner/task_unittest.cc
Project Member

Comment 21 by bugdroid1@chromium.org, Jan 18 (4 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80d1ceaf9af778cab601247d6359bba87971d88d

commit 80d1ceaf9af778cab601247d6359bba87971d88d
Author: Mirko Bonadei <mbonadei@chromium.org>
Date: Fri Jan 18 22:22:17 2019

Migrate libjingle_xmpp to jingle_xmpp namespace.

At the moment, lijingle_xmpp uses two namespaces "buzz" and "rtc". This
happened for historical reasons but as of today, jingle_xmpp is a
standalone library that is only used by Chromium.

This CL removes the two namespaces in favor of "jingle_xmpp".

This will also prevent namespace clashes with WebRTC, which internally
uses "rtc".

Bug: 919085
Change-Id: I5957f15f0b71770ef65f1814fb7add6b5fc530c4
Reviewed-on: https://chromium-review.googlesource.com/c/1416142
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624318}
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/glue/mock_task.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/glue/mock_task.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/glue/network_service_async_socket.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/glue/network_service_async_socket.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/glue/network_service_async_socket_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/glue/task_pump.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/base/fake_base_task.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/base/fake_base_task.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/base/gaia_token_pre_xmpp_auth.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/base/gaia_token_pre_xmpp_auth.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/base/notifier_options_util.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/base/notifier_options_util.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/base/weak_xmpp_client.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/base/weak_xmpp_client.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/base/weak_xmpp_client_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/base/xmpp_connection.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/base/xmpp_connection.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/base/xmpp_connection_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/communicator/connection_settings.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/communicator/connection_settings.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/communicator/login.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/communicator/login.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/communicator/login_settings.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/communicator/login_settings.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/communicator/login_settings_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/communicator/single_login_attempt.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/communicator/single_login_attempt.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/communicator/single_login_attempt_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/listener/push_notifications_listen_task.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/listener/push_notifications_listen_task.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/listener/push_notifications_send_update_task.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/listener/push_notifications_send_update_task.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/listener/push_notifications_send_update_task_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/listener/push_notifications_subscribe_task.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/listener/push_notifications_subscribe_task.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/listener/push_notifications_subscribe_task_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/listener/send_ping_task.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/listener/send_ping_task.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/listener/send_ping_task_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/listener/xml_element_util.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/listener/xml_element_util.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/listener/xml_element_util_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/listener/xmpp_push_client.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/jingle/notifier/listener/xmpp_push_client.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/client/chromoting_client.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/client/chromoting_client.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/client/host_experiment_sender.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/client/host_experiment_sender.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/host/client_session_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/host/gcd_state_updater.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/host/gcd_state_updater.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/host/heartbeat_sender.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/host/heartbeat_sender.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/host/heartbeat_sender_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/host/host_change_notification_listener.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/host/host_change_notification_listener.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/host/host_change_notification_listener_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/host/host_experiment_session_plugin.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/host/host_experiment_session_plugin.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/host/host_experiment_session_plugin_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/host/host_status_logger_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/host/pam_authorization_factory_posix.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/host/register_support_host_request.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/host/register_support_host_request.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/host/register_support_host_request_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/host/server_log_entry_host_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/host/signaling_connector.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/host/signaling_connector.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/authenticator.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/authenticator.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/authenticator_test_base.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/content_description.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/content_description.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/content_description_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/fake_authenticator.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/fake_authenticator.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/fake_session.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/fake_session.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/ice_transport.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/ice_transport.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/ice_transport_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/jingle_info_request.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/jingle_info_request.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/jingle_messages.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/jingle_messages.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/jingle_messages_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/jingle_session.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/jingle_session.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/jingle_session_manager.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/jingle_session_manager.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/jingle_session_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/negotiating_authenticator_base.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/negotiating_authenticator_base.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/negotiating_client_authenticator.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/negotiating_client_authenticator.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/negotiating_host_authenticator.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/negotiating_host_authenticator.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/pairing_authenticator_base.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/pairing_authenticator_base.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/protocol_mock_objects.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/rejecting_authenticator.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/rejecting_authenticator.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/session_plugin.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/spake2_authenticator.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/spake2_authenticator.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/spake2_authenticator_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/third_party_authenticator_base.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/third_party_authenticator_base.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/third_party_client_authenticator.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/third_party_client_authenticator.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/third_party_host_authenticator.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/third_party_host_authenticator.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/transport.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/v2_authenticator.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/v2_authenticator.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/v2_authenticator_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/validating_authenticator.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/validating_authenticator.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/validating_authenticator_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/webrtc_transport.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/webrtc_transport.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/protocol/webrtc_transport_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/delegating_signal_strategy.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/delegating_signal_strategy.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/fake_signal_strategy.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/fake_signal_strategy.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/iq_sender.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/iq_sender.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/iq_sender_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/log_to_server.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/log_to_server.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/log_to_server_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/mock_signal_strategy.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/push_notification_subscriber.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/push_notification_subscriber.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/push_notification_subscriber_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/server_log_entry.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/server_log_entry.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/server_log_entry_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/server_log_entry_unittest.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/signal_strategy.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/signaling_address.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/signaling_address.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/signaling_address_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/xmpp_login_handler.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/xmpp_login_handler.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/xmpp_signal_strategy.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/xmpp_signal_strategy.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/xmpp_signal_strategy_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/xmpp_stream_parser.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/xmpp_stream_parser.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/remoting/signaling/xmpp_stream_parser_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/task_runner/task.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/task_runner/task.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/task_runner/task_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/task_runner/taskparent.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/task_runner/taskparent.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/task_runner/taskrunner.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/task_runner/taskrunner.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmllite/qname.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmllite/qname.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmllite/qname_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmllite/xmlbuilder.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmllite/xmlbuilder.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmllite/xmlbuilder_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmllite/xmlconstants.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmllite/xmlconstants.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmllite/xmlelement.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmllite/xmlelement.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmllite/xmlelement_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmllite/xmlnsstack.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmllite/xmlnsstack.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmllite/xmlnsstack_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmllite/xmlparser.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmllite/xmlparser.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmllite/xmlparser_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmllite/xmlprinter.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmllite/xmlprinter.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmllite/xmlprinter_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmpp/asyncsocket.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmpp/constants.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmpp/constants.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmpp/fakexmppclient.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmpp/jid.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmpp/jid.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmpp/jid_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmpp/plainsaslhandler.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmpp/prexmppauth.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmpp/saslcookiemechanism.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmpp/saslhandler.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmpp/saslmechanism.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmpp/saslmechanism.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmpp/saslplainmechanism.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmpp/util_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmpp/util_unittest.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmpp/xmppclient.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmpp/xmppclient.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmpp/xmppclientsettings.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmpp/xmppengine.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmpp/xmppengine_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmpp/xmppengineimpl.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmpp/xmppengineimpl.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmpp/xmppengineimpl_iq.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmpp/xmpplogintask.cc
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmpp/xmpplogintask.h
[modify] https://crrev.com/80d1ceaf9af778cab601247d6359bba87971d88d/third_party/libjingle_xmpp/xmpp/xmpplogintask_unittest.cc
[modify] https://crrev.com/80d1ceaf9af778cab60124
Project Member

Comment 22 by bugdroid1@chromium.org, Today (19 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3514203635d4f5c2d660784dd3007f1018c9af88

commit 3514203635d4f5c2d660784dd3007f1018c9af88
Author: Mirko Bonadei <mbonadei@chromium.org>
Date: Tue Jan 22 11:14:42 2019

Stop depending on WebRTC GN templates.

* Stop using rtc_* GN templates (which should only be used by WebRTC),

* Dependencies on WebRTC are now declared (even if it is sad that
  libjingle_xmpp uses base64 and sigslot from
  WebRTC's rtc_base/third_party).

* Update DEPS files.


Bug: 919085
Change-Id: I8918436237e459d60465166be94714c0c6691f63
Reviewed-on: https://chromium-review.googlesource.com/c/1404159
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624758}
[modify] https://crrev.com/3514203635d4f5c2d660784dd3007f1018c9af88/remoting/client/plugin/BUILD.gn
[modify] https://crrev.com/3514203635d4f5c2d660784dd3007f1018c9af88/services/network/public/cpp/BUILD.gn
[modify] https://crrev.com/3514203635d4f5c2d660784dd3007f1018c9af88/third_party/libjingle_xmpp/BUILD.gn
[modify] https://crrev.com/3514203635d4f5c2d660784dd3007f1018c9af88/third_party/libjingle_xmpp/xmllite/DEPS
[modify] https://crrev.com/3514203635d4f5c2d660784dd3007f1018c9af88/third_party/libjingle_xmpp/xmpp/DEPS
[modify] https://crrev.com/3514203635d4f5c2d660784dd3007f1018c9af88/third_party/webrtc_overrides/BUILD.gn
►

Sign in to add a comment