New issue
Advanced search Search tips

Issue 919083 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 5
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 917419



Sign in to add a comment

Building lld times out on Linux, Windows

Project Member Reported by thakis@chromium.org, Jan 4

Issue description

I made a clang roll attempt to 350340  at https://chromium-review.googlesource.com/c/chromium/src/+/1394732

linux_upload_clang timed out after 3h. Usually it takes 1h. All the time went into linking lld.

win_upload_clang failed due to "command timed out: 2400 seconds without output, attempting to kill", also while linking lld.



I think we build lld with LTO on Linux. I'm not sure if we do this on Windows....looks like no: https://cs.chromium.org/chromium/src/tools/clang/scripts/package.py?type=cs&q=lto-lld&sq=package:chromium&g=0&l=216


My initial theory was that this is due to LTO getting slower, but that doesn't explain the Windows issue.
 
Owner: p...@chromium.org
Status: Started (was: Untriaged)
I can reproduce the timeout locally on Linux.

I started bisecting on LLVM revisions. So far I'm at r350224 good r350340 bad.
Thanks!
I bisected as far as r350332 good r350340 bad. The most suspicious change in that range is r350334 which added an expensive check to the asserts build. It's possible that on Windows we were hitting the same check in one of the compiles (note that progress on Windows was 2200/2203 which probably meant that it was not a link but a compile that hung). The check was moved under expensive checks in r350349 so hopefully we can just roll past that.
Status: Fixed (was: Started)
Confirmed that a locally built Linux package for r350349 does not have this problem.

Sign in to add a comment