Issue metadata
Sign in to add a comment
|
Regression: Two focuses are seen when we tab after typing something in app launcher search bar |
||||||||||||||||||||||
Issue descriptionChrome Version: 73.0.3654.0/11521.0.0 dev channel Candy,Celes,Peppy OS: Chrome OS What steps will reproduce the problem? (1)Sign-in to user>> Click on app launcher and type some letter and press tab>> observe unnecessarily focus is seen on close icon even though default focus is on first app Actual: Two focuses are seen when we tab after typing something in app launcher search bar Expected: Focus should be seen on 2nd app icon when tabbed This is a Regression issue as same is working fine in M63 NOTE: Issue is seen in M64, M65, M66, M67, M68, M69, M70, M71 and M72 also Attaching screencast for reference
,
Jan 7
,
Jan 7
ginko@, is this fixed after your refactoring?
,
Jan 7
,
Jan 8
This isn't fixed by any CL I am currently working on. This will take at least 2 weeks for me to start work on if you leave it here, as a result I will unassign it until I can get to it
,
Jan 16
(6 days ago)
,
Jan 19
(4 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aaee335781975296a269a9324798e5a23b2cdc41 commit aaee335781975296a269a9324798e5a23b2cdc41 Author: Weidong Guo <weidongg@chromium.org> Date: Sat Jan 19 01:02:42 2019 Fix double focus issue in search results page Changes: Remove the first result's highlight when focus is moved from search box textfield. (e.g. to close button or last search result). Bug: 919050 Test: AppListViewFocusTest.FirstResultSelectedAfterSearchResultsUpdated Change-Id: I6a85f04631145bddfa439ee8acbcff417e0b9d42 Reviewed-on: https://chromium-review.googlesource.com/c/1423350 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#624391} [modify] https://crrev.com/aaee335781975296a269a9324798e5a23b2cdc41/ash/app_list/views/app_list_main_view.cc [modify] https://crrev.com/aaee335781975296a269a9324798e5a23b2cdc41/ash/app_list/views/app_list_main_view.h [modify] https://crrev.com/aaee335781975296a269a9324798e5a23b2cdc41/ash/app_list/views/app_list_view_unittest.cc [modify] https://crrev.com/aaee335781975296a269a9324798e5a23b2cdc41/ash/app_list/views/search_box_view_unittest.cc [modify] https://crrev.com/aaee335781975296a269a9324798e5a23b2cdc41/ash/components/shortcut_viewer/views/keyboard_shortcut_view.h [modify] https://crrev.com/aaee335781975296a269a9324798e5a23b2cdc41/ui/chromeos/search_box/search_box_view_base.cc [modify] https://crrev.com/aaee335781975296a269a9324798e5a23b2cdc41/ui/chromeos/search_box/search_box_view_delegate.h
,
Jan 19
(4 days ago)
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kebalaji@chromium.org
, Jan 4