New issue
Advanced search Search tips

Issue 919013 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

WebView instrumentation(Android WebView TestShell) can't handle any touch events after drag-and-drop

Reported by fanjins...@sogou-inc.com, Jan 4

Issue description

Steps to reproduce the problem:
1. Build WebView instrumentation apk(ninja -C out/Default webview_instrumentation_apk) by the source code, and install WebViewInstrumentation.apk on Android N or N+ 
2. Load url https://m.sohu.com, and open any news, then select some words by the long press
3. Long press the selected words, then drag the selected word to any place
4. After dropped, TestShell cann't handle any touch events except scroll.

What is the expected behavior?

What went wrong?
TestShell cann't handle any touch events after drag-and-drop.

Did this work before? N/A 

Chrome version: 73.0.3661.0  Channel: stable
OS Version: 7.1.1
Flash Version:
 
Labels: Needs-triage-Mobile
Cc: jbanavatu@chromium.org chelamcherla@chromium.org
Labels: Triaged-Mobile Needs-Feedback
@fanjinsong: Please provide test file to install or link to download along with screencast on reproducing the issue, this would help in further triaging.

Thanks! 
@jbanavatu This URL:
https://dlmse.sogoucdn.com/awp/WebViewInstrumentation.apk
links to the WebViewInstrumentation apk.
And the attached screencast shows this issue.
Screenshot_20190107-093605.png
438 KB View Download
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 7

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9476f0bc07d9d735f867a2cb1af4665806fe72d

commit f9476f0bc07d9d735f867a2cb1af4665806fe72d
Author: Jinsong Fan <fanjinsong@sogou-inc.com>
Date: Mon Jan 07 16:48:05 2019

AW: Override onDragEvent() for webview instrumentation

Since touch-drag-drop is enabled by default on Android N+, the
AwTestContainerView does not pass the DragEvent to the AwContents,
causing the blink to not handle the touch event correctly after
drag-and-drop.
The CL overrides onDragEvent() for webview instrumentation apk.

Bug:  919013 
Change-Id: I77a31c2243f2ade3b2c17aa14d733bda05c2dc3d
Reviewed-on: https://chromium-review.googlesource.com/c/1393130
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620354}
[modify] https://crrev.com/f9476f0bc07d9d735f867a2cb1af4665806fe72d/android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java

Cc: fanjins...@sogou-inc.com
Owner: changwan@chromium.org
Status: Assigned (was: Unconfirmed)
Unable to assign to fanjinsong@sogou-inc.com, hence assigning to reviewer changwan@. Please change if this is not the case.

@fanjinsong@sogou-inc.com: Could you please let us know if this is fixed in latest canary, we can change status to fixed.

Thanks!
Components: -UI Test>Android Mobile>WebView
Status: Fixed (was: Assigned)


Sign in to add a comment