Findit identified the culprit r619841 as introducing flaky test(s) summarized in https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOGYxMzMzNmQ0M2NhMTBlZTEwYmQyMmFkMDJhYWIxMWM3ZDc5OTEyOAw Please revert the culprit or disable the test(s) asap. If you are the owner, please fix! If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20culprit%20r619841&comment=Link%20to%20Culprit%3A%20https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOGYxMzMzNmQ0M2NhMTBlZTEwYmQyMmFkMDJhYWIxMWM3ZDc5OTEyOAw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c0d4779099e40a82e26e8d6e7517365f48f69c0 commit 4c0d4779099e40a82e26e8d6e7517365f48f69c0 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Fri Jan 04 03:17:24 2019 Revert "Add reshape and copy outside case for SkiaOutputSurfaceImplTest" This reverts commit 8f13336d43ca10ee10bd22ad02aab11c7d799128. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 619841 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOGYxMzMzNmQ0M2NhMTBlZTEwYmQyMmFkMDJhYWIxMWM3ZDc5OTEyOAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests/8493 Sample Failed Step: viz_unittests on (none) GPU on Mac Sample Flaky Test: SkiaOutputSurfaceImplTest.CopyOutOutside Original change's description: > Add reshape and copy outside case for SkiaOutputSurfaceImplTest > > Bug: 894806 > Change-Id: Id76b1a229b9583e7d7304b4f5262e2b8d9bbbbb3 > Reviewed-on: https://chromium-review.googlesource.com/c/1388020 > Commit-Queue: Xing Xu <xing.xu@intel.com> > Reviewed-by: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619841} Change-Id: Ic8105579dffefcf7f13cfb12e30e350c6ffee6e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 894806, 919012 Reviewed-on: https://chromium-review.googlesource.com/c/1395719 Cr-Commit-Position: refs/heads/master@{#619874} [modify] https://crrev.com/4c0d4779099e40a82e26e8d6e7517365f48f69c0/components/viz/service/display_embedder/skia_output_surface_impl_unittest.cc
Removing Sheriff-Chromium tag since revert has deleted the flaky test.
Comment 1 by bugdroid1@chromium.org
, Jan 4