New issue
Advanced search Search tips

Issue 919007 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 11
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: CrExtensionsManagerTestWithOptionsDialog.ShowOptionsDialog

Blocking:
issue 912026



Sign in to add a comment

CrExtensionsManagerTestWithOptionsDialog.ShowOptionsDialog is flaky

Project Member Reported by Findit, Jan 4

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jan 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4cdafc0e9dfc5b08d7c0d5aa95902d2a87b1861

commit d4cdafc0e9dfc5b08d7c0d5aa95902d2a87b1861
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Fri Jan 04 02:55:24 2019

Revert "Extensions: Focus correct button on options dialog close."

This reverts commit 5aa7731c3075fe63d1f016252fc094bba1491d17.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 619843 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNWFhNzczMWMzMDc1ZmU2M2QxZjAxNjI1MmZjMDk0YmJhMTQ5MWQxNww

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win10%20Tests%20x64/30552

Sample Failed Step: network_service_browser_tests on Windows-10-15063

Sample Flaky Test: CrExtensionsManagerTestWithOptionsDialog.ShowOptionsDialog

Original change's description:
> Extensions: Focus correct button on options dialog close.
> 
> Also fix some const references surfaced by presubmit.
> 
> Bug: 912026
> Change-Id: I2661f69f0e63e613a9b8e9d565813c3e27fed340
> Reviewed-on: https://chromium-review.googlesource.com/c/1377494
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Commit-Queue: Hector Carmona <hcarmona@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#619843}

Change-Id: I66ae0de35342e94b47e76dac658df2eb1f12e4b0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 912026,  919007 
Reviewed-on: https://chromium-review.googlesource.com/c/1395717
Cr-Commit-Position: refs/heads/master@{#619870}
[modify] https://crrev.com/d4cdafc0e9dfc5b08d7c0d5aa95902d2a87b1861/chrome/browser/resources/md_extensions/detail_view.js
[modify] https://crrev.com/d4cdafc0e9dfc5b08d7c0d5aa95902d2a87b1861/chrome/browser/resources/md_extensions/manager.js
[modify] https://crrev.com/d4cdafc0e9dfc5b08d7c0d5aa95902d2a87b1861/chrome/test/data/extensions/options_page_in_view/manifest.json
[modify] https://crrev.com/d4cdafc0e9dfc5b08d7c0d5aa95902d2a87b1861/chrome/test/data/webui/extensions/cr_extensions_browsertest.js
[modify] https://crrev.com/d4cdafc0e9dfc5b08d7c0d5aa95902d2a87b1861/chrome/test/data/webui/extensions/manager_test.js

Labels: -Sheriff-Chromium
Removing Sheriff-Chromium tag since this revert deletes the offending test.
Blocking: 912026
Status: Assigned (was: Untriaged)
Yep, my CL added the change. I'll take a look at the cause of the flakiness before re-landing.
Status: Fixed (was: Assigned)
Was able to reproduce locally and landed offending change again w/ fix to avoid test failure.

CL to enable test again: https://crrev.com/c/1405459
Components: UI>Browser>ExtensionsManagement

Sign in to add a comment