New issue
Advanced search Search tips

Issue 918970 link

Starred by 2 users
Status: Fixed
Owner:
smbar...@chromium.org
Closed: Jan 4
Cc:
jkardatzke@chromium.org
nverne@chromium.org
tbuck...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

CrostiniManager should use format string for container version

Project Member Reported by smbar...@chromium.org, Jan 3 
CrostiniManager's default image server should be https://storage.googleapis.com/cros-containers/%d as the milestone will be filled in by tremplin: https://chromium.googlesource.com/chromiumos/platform/tremplin/+/6832c25a9cbd34a2a475206cda53e2e8c9fa9081/src/chromiumos/tremplin/tremplin.go#313

This is necessary to pull in the correct container version. Right now, Crostini container setup will download the M69 container version even on M73.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95d1f03df9bbcdf0b16c39cee3de5095362e3f4a

commit 95d1f03df9bbcdf0b16c39cee3de5095362e3f4a
Author: Stephen Barber <smbarber@chromium.org>
Date: Fri Jan 04 01:04:40 2019

Update Crostini image server URL

The image server URL should have a %d in it, to be replaced with
the Chrome OS milestone at runtime.

BUG= chromium:918970 
TEST=set up crostini; check that container has wget preinstalled

Change-Id: I3cdfce9ea1b80e704719da05449734c82d2b7dc9
Reviewed-on: https://chromium-review.googlesource.com/c/1395025
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Stephen Barber <smbarber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619840}
[modify] https://crrev.com/95d1f03df9bbcdf0b16c39cee3de5095362e3f4a/chrome/browser/chromeos/crostini/crostini_util.h

Comment 2 by smbar...@chromium.org, Jan 4

Status: Fixed (was: Started)

Comment 3 by smbar...@chromium.org, Jan 4

Cc: tbuck...@chromium.org
+tbuckley this is probably worth merging back into 72.
►

Sign in to add a comment