Issue metadata
Sign in to add a comment
|
DevTools: blue highlight for element overlay flickers when |
||||||||||||||||||||
Issue descriptionWhat steps will reproduce the problem? (1) Open DevTools' Elements panel (make sure 'Styles' sidebar is open, too) (2) Click a different element or use ArrowUp/Down keys to change the selected element in the tree What is the expected result? Upon selecting a new element, the blue overlay highlight should persist What happens instead? The blue overlay highlight flickers, shown quickly before disappearing. Narrow bisect: https://chromium.googlesource.com/chromium/src/+/4fbc5af23dad1e53127a4829ae206c263cc5ceda
,
Jan 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e4a073a3d8c968a1f7c9af7e6c2f6a47e959151 commit 6e4a073a3d8c968a1f7c9af7e6c2f6a47e959151 Author: Erik Luo <luoe@chromium.org> Date: Fri Jan 04 18:26:43 2019 DevTools: only hide highlight when active property is set When highlighting the active property, we used to always hide the overlay highlight, even if no active property was being highlighted. This CL checks that we do not hide unrelated highlights. Screenshot: https://imgur.com/a/W0zFEqq Bug: 918957 Change-Id: I118369e64af4062994221a5a79e8b0e16989b665 Reviewed-on: https://chromium-review.googlesource.com/c/1394986 Reviewed-by: Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#620002} [modify] https://crrev.com/6e4a073a3d8c968a1f7c9af7e6c2f6a47e959151/third_party/blink/renderer/devtools/front_end/elements/StylesSidebarPane.js
,
Jan 4
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by l...@chromium.org
, Jan 3