New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 918952 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO until 2019-01-24
Closed: Jan 4
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression

Blocked on:
issue 267348
issue 860391
issue 917589
issue 918643

Blocking:
issue 614112



Sign in to add a comment

Four canvas-related pixel tests failing on Nexus 5

Project Member Reported by kbr@chromium.org, Jan 3

Issue description

Failing as of this build:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20FYI%20Release%20%28Nexus%205%29/12726

Pixel_Canvas2DRedBox
Pixel_CanvasDisplayLinearRGBAccelerated2D
Pixel_CanvasDisplayLinearRGBUnaccelerated2DGPUCompositing
Pixel_CanvasLowLatency2D

Example failure:
http://chromium-browser-gpu-tests.commondatastorage.googleapis.com/view_test_results.html?961443c81edb97c93ac8851f1226a0ff556795ea_Android_FYI_Release_Nexus_5__telemetry

No obvious differences.

Possible culprits:

Move CanvasRenderingContext2D::font_lru_list_ to LinkedHashSet.
https://chromium.googlesource.com/chromium/src/+/dd5243fbc38f4d41da6f9790117d370685dcb31e

Update transform list interpolation
https://chromium.googlesource.com/chromium/src/+/3038d348f38e5917fc7bea5a7bcc785f51f8d477

Clearing backdrop_filter_bounds in DirectRenderer::DrawFrame
https://chromium.googlesource.com/chromium/src/+/f5fc6a5e9e2ef32881a9d157d0700cb529d3557e

 
kbr@, not sure how this is blocked by 917589 - perhaps you meant a different #?
masonfreed@: just wanted to establish a possible cause/effect relationship between the fix for Issue 917589 and this bug. Still not sure which of those 3 CLs might have caused this bug.

If the rebaseline succeeds, I'll close this as fixed and it won't require further investigation.

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a902145c9a65fc452c8fdd90ed2fb18ca1ef5f9

commit 5a902145c9a65fc452c8fdd90ed2fb18ca1ef5f9
Author: Kenneth Russell <kbr@chromium.org>
Date: Fri Jan 04 03:14:11 2019

Rebaseline 4 canvas pixel tests failing on Nexus 5.

  Pixel_Canvas2DRedBox
  Pixel_CanvasDisplayLinearRGBAccelerated2D
  Pixel_CanvasDisplayLinearRGBUnaccelerated2DGPUCompositing
  Pixel_CanvasLowLatency2D

Bug:  918952 
Change-Id: Ic747a861cb778f5f07c00e6b5862c8a3e4ce9407
Tbr: fserb@chromium.org
Tbr: mcasas@chromium.org
Tbr: zakerinasab@chromium.org
Tbr: ynovikov@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1394984
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619873}
[modify] https://crrev.com/5a902145c9a65fc452c8fdd90ed2fb18ca1ef5f9/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/5a902145c9a65fc452c8fdd90ed2fb18ca1ef5f9/content/test/gpu/gpu_tests/pixel_test_pages.py

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82c076e395e804bf93292f6ba4b21111fa1f1dd5

commit 82c076e395e804bf93292f6ba4b21111fa1f1dd5
Author: Kenneth Russell <kbr@chromium.org>
Date: Fri Jan 04 18:51:18 2019

Re-enable 4 canvas pixel tests.

  Pixel_Canvas2DRedBox
  Pixel_CanvasDisplayLinearRGBAccelerated2D
  Pixel_CanvasDisplayLinearRGBUnaccelerated2DGPUCompositing
  Pixel_CanvasLowLatency2D

Should be rebaselined at this point.

Bug:  918952 
Change-Id: I89238fe4e294582e356ccfaf8b394b253f925976
Tbr: fserb@chromium.org
Tbr: mcasas@chromium.org
Tbr: zakerinasab@chromium.org
Tbr: ynovikov@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1395003
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620015}
[modify] https://crrev.com/82c076e395e804bf93292f6ba4b21111fa1f1dd5/content/test/gpu/gpu_tests/pixel_expectations.py

Blockedon: -614112
Blocking: 614112
Status: Fixed (was: Assigned)
These tests are passing (everywhere, as far as I can tell) after the rebaseline.

Sign in to add a comment