Plan: deprecate in M73, remove in M74. blink-dev intent thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/gwocKqRuXvw
Actually, since PPB_Compositor is a "dev" API and only whitelisted for ARC (which doesn't use it any more), we should remove directly in 73.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6ff5bd40da6d03e677ce9ab52d0a740527397b2 commit a6ff5bd40da6d03e677ce9ab52d0a740527397b2 Author: Antoine Labour <piman@chromium.org> Date: Fri Jan 04 17:10:16 2019 Remove use of PPB_Compositor in TestFlashFullscreenForBrowserUI PPB_Compositor is going away, so replace with PPB_Graphics3D. Also fix logic related to submitting frames while callbacks are pending (might be related to test flakiness). Bug: 918951 Change-Id: I232c87525f39e268c6fd26072cb465c07fc4256b Reviewed-on: https://chromium-review.googlesource.com/c/1395144 Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#619980} [modify] https://crrev.com/a6ff5bd40da6d03e677ce9ab52d0a740527397b2/ppapi/tests/test_flash_fullscreen_for_browser_ui.cc [modify] https://crrev.com/a6ff5bd40da6d03e677ce9ab52d0a740527397b2/ppapi/tests/test_flash_fullscreen_for_browser_ui.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50c237decafa79afe58b88c8c997b9db15134fa0 commit 50c237decafa79afe58b88c8c997b9db15134fa0 Author: Antoine Labour <piman@chromium.org> Date: Fri Jan 04 22:27:32 2019 Re-run ppapi/generators/generator.py Some previous changes left pp_macros.h in an inconsistent state. Also fixup the generator so that il makes git cl format a noop on it. Bug: 918951 Change-Id: I0f9bac70831b95e9a1a6ee7b9ba47dd62a88baa4 Reviewed-on: https://chromium-review.googlesource.com/c/1396609 Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#620088} [modify] https://crrev.com/50c237decafa79afe58b88c8c997b9db15134fa0/ppapi/c/pp_macros.h [modify] https://crrev.com/50c237decafa79afe58b88c8c997b9db15134fa0/ppapi/generators/idl_c_header.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0c56e43d06e4d6f75855ab992df726cf6011a93 commit c0c56e43d06e4d6f75855ab992df726cf6011a93 Author: Antoine Labour <piman@chromium.org> Date: Thu Jan 10 22:26:07 2019 Remove PPB_Compositor It's incompatible with shared images / Vulkan, and it usage is extremely low (not available on stable except for ARC, which doesn't use it any more). Bug: 918951 Change-Id: Ia01d2b276456536394fecffb39d5ea6c90cfe0de Reviewed-on: https://chromium-review.googlesource.com/c/1396611 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Ben Smith <binji@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#621778} [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/BUILD.gn [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/chrome/common/ppapi_utils.cc [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/chrome/renderer/chrome_content_renderer_client.cc [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/chrome/renderer/chrome_content_renderer_client.h [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/content/public/renderer/content_renderer_client.cc [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/content/public/renderer/content_renderer_client.h [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/content/renderer/BUILD.gn [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/content/renderer/pepper/content_renderer_pepper_host_factory.cc [delete] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/content/renderer/pepper/pepper_compositor_host.cc [delete] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/content/renderer/pepper/pepper_compositor_host.h [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/content/renderer/pepper/pepper_plugin_instance_impl.cc [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/content/renderer/pepper/pepper_plugin_instance_impl.h [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/content/renderer/pepper/plugin_module.cc [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/content/renderer/pepper/resource_creation_impl.cc [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/content/renderer/pepper/resource_creation_impl.h [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/content/shell/renderer/shell_content_renderer_client.cc [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/content/shell/renderer/shell_content_renderer_client.h [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/native_client_sdk/src/libraries/ppapi/library.dsc [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/native_client_sdk/src/libraries/ppapi_cpp/library.dsc [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/ppapi/BUILD.gn [delete] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/ppapi/api/ppb_compositor.idl [delete] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/ppapi/api/ppb_compositor_layer.idl [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/ppapi/c/BUILD.gn [delete] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/ppapi/c/ppb_compositor.h [delete] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/ppapi/c/ppb_compositor_layer.h [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/ppapi/cpp/BUILD.gn [delete] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/ppapi/cpp/compositor.cc [delete] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/ppapi/cpp/compositor.h [delete] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/ppapi/cpp/compositor_layer.cc [delete] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/ppapi/cpp/compositor_layer.h [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/ppapi/cpp/instance.cc [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/ppapi/cpp/instance.h [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/ppapi/examples/BUILD.gn [delete] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/ppapi/examples/compositor/BUILD.gn [delete] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/ppapi/examples/compositor/compositor.cc [delete] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/ppapi/examples/compositor/compositor.html [delete] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/ppapi/examples/compositor/spinning_cube.cc [delete] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/ppapi/examples/compositor/spinning_cube.h [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/ppapi/host/resource_host.cc [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/ppapi/host/resource_host.h [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/ppapi/proxy/BUILD.gn [delete] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/ppapi/proxy/compositor_layer_resource.cc [delete] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/ppapi/proxy/compositor_layer_resource.h [delete] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/ppapi/proxy/compositor_resource.cc [delete] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/ppapi/proxy/compositor_resource.h [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/ppapi/proxy/interface_list.cc [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/ppapi/proxy/ppapi_messages.h [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/ppapi/proxy/ppapi_param_traits.h [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/ppapi/proxy/ppb_instance_proxy.cc [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/ppapi/proxy/resource_creation_proxy.cc [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/ppapi/proxy/resource_creation_proxy.h [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/ppapi/shared_impl/BUILD.gn [delete] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/ppapi/shared_impl/compositor_layer_data.cc [delete] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/ppapi/shared_impl/compositor_layer_data.h [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/ppapi/shared_impl/resource.h [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/ppapi/tests/all_c_includes.h [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/ppapi/tests/all_cpp_includes.h [delete] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/ppapi/tests/test_compositor.cc [delete] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/ppapi/tests/test_compositor.h [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/ppapi/thunk/BUILD.gn [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/ppapi/thunk/interfaces_ppb_public_dev_channel.h [delete] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/ppapi/thunk/ppb_compositor_api.h [delete] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/ppapi/thunk/ppb_compositor_layer_api.h [delete] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/ppapi/thunk/ppb_compositor_layer_thunk.cc [delete] https://crrev.com/812090c2c8488456a0ffd08e722a80f52c3b3a8e/ppapi/thunk/ppb_compositor_thunk.cc [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/ppapi/thunk/resource_creation_api.h [modify] https://crrev.com/c0c56e43d06e4d6f75855ab992df726cf6011a93/tools/metrics/histograms/enums.xml
Comment 1 by piman@chromium.org
, Jan 3