New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 918943 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Messages: Show notification when phone pairing is disconnected

Project Member Reported by khorimoto@chromium.org, Jan 3

Issue description

Once multi-device setup is completed, the "Messages" PWA is installed, but further setup is required before the app can be used. Specifically, the Chromebook needs to be paired with the user's phone via a QR code displayed in the PWA.

However, this pairing can be broken in two ways:
(1) The PWA is being migrated from messages.android.com to messages.google.com (see issue 917855). Once this occurs, the pairing state will be lost. (Note: the Messages team is exploring mechanisms by which this can be bypassed, but it's unclear if this task can be completed due to privacy/security implications.)
(2) The pairing expires after 30 days if it has not been used, so an infrequent Chromebook user can experience this issue.

When this situation occurs, we should alert the user that the devices need to be re-paired. Otherwise, the user could be confused about why message syncing and Chromebook-side notifications have ceased to work correctly.

Proposed notification title: Pair your phone with Messages
Proposed notification message: Click here to send and receive messages from your Chromebook.

Assigning to jonann@ for string recommendations.
 
Status: Started (was: Assigned)
@khorimoto For review:

notification title:

Pair your phone with Messages

notification message: 

Send and receive text messages from your Chromebook

Owner: khorimoto@chromium.org
Thanks, jonann@! I'll look into implementing this now.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/caad2b29698e833626ff7e97dc11a1f31709b94c

commit caad2b29698e833626ff7e97dc11a1f31709b94c
Author: Kyle Horimoto <khorimoto@chromium.org>
Date: Wed Jan 09 18:15:35 2019

[CrOS MultiDevice] Move Android SMS files to appropriate location.

This CL moves several files which are specific to Android SMS from:
  //chrome/browser/chromeos/multidevice_setup
to:
  //chrome/browser/chromeos/android_sms

This CL is in preparation for making AndroidSmsService own objects of
these classes itself. Currently, they are owned directly by the
MultiDeviceSetupService, but future CLs will require that they are
accessed out of the service, requiring this refactor.

Bug:  918943 
Change-Id: I2cbf5d8f35ec8d5589ef2d6c92ac56b27fa682b8
Reviewed-on: https://chromium-review.googlesource.com/c/1401669
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621222}
[modify] https://crrev.com/caad2b29698e833626ff7e97dc11a1f31709b94c/chrome/browser/chromeos/BUILD.gn
[rename] https://crrev.com/caad2b29698e833626ff7e97dc11a1f31709b94c/chrome/browser/chromeos/android_sms/android_sms_app_helper_delegate_impl.cc
[rename] https://crrev.com/caad2b29698e833626ff7e97dc11a1f31709b94c/chrome/browser/chromeos/android_sms/android_sms_app_helper_delegate_impl.h
[rename] https://crrev.com/caad2b29698e833626ff7e97dc11a1f31709b94c/chrome/browser/chromeos/android_sms/android_sms_app_helper_delegate_impl_unittest.cc
[rename] https://crrev.com/caad2b29698e833626ff7e97dc11a1f31709b94c/chrome/browser/chromeos/android_sms/android_sms_pairing_state_tracker_impl.cc
[rename] https://crrev.com/caad2b29698e833626ff7e97dc11a1f31709b94c/chrome/browser/chromeos/android_sms/android_sms_pairing_state_tracker_impl.h
[modify] https://crrev.com/caad2b29698e833626ff7e97dc11a1f31709b94c/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/caad2b29698e833626ff7e97dc11a1f31709b94c/chrome/browser/ui/webui/settings/chromeos/multidevice_handler.cc
[modify] https://crrev.com/caad2b29698e833626ff7e97dc11a1f31709b94c/chrome/browser/ui/webui/settings/md_settings_ui.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a67b3839281259d517e5ac18ce57fc92525562f1

commit a67b3839281259d517e5ac18ce57fc92525562f1
Author: Kyle Horimoto <khorimoto@chromium.org>
Date: Thu Jan 10 01:23:41 2019

[CrOS MultiDevice] Update build for //c/b/chromeos/android_sms files.

Previously, there was a //c/b/chromeos/android_sms BUILD file, but this:
(1) Is causing circular dependency issues in follow-up CL
    https://chromium-review.googlesource.com/c/chromium/src/+/1402022.
(2) Does not follow the same convention as other sub-directories of
    //c/b/chromeos.

This CL removes that BUILD file and integrates all files into the
top-level //c/b/chromeos file.

Bug:  918943 
Change-Id: I1fb5a13d738b5ecaeb888d554cdc66aab092b74c
Reviewed-on: https://chromium-review.googlesource.com/c/1403988
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621408}
[modify] https://crrev.com/a67b3839281259d517e5ac18ce57fc92525562f1/chrome/browser/BUILD.gn
[modify] https://crrev.com/a67b3839281259d517e5ac18ce57fc92525562f1/chrome/browser/chromeos/BUILD.gn
[delete] https://crrev.com/142c53535abd878822fcabc14c2c5ee3a823f701/chrome/browser/chromeos/android_sms/BUILD.gn
[modify] https://crrev.com/a67b3839281259d517e5ac18ce57fc92525562f1/chrome/browser/ui/BUILD.gn

Notification badge icon attached.
It's a bit of an odd size for this type of icon so let me know how that works out.
message icon.svg
335 bytes Download
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/235a38d21ad50442fd4a3362e143aa5bedf89bf3

commit 235a38d21ad50442fd4a3362e143aa5bedf89bf3
Author: Kyle Horimoto <khorimoto@chromium.org>
Date: Thu Jan 10 23:26:41 2019

[CrOS MultiDevice] Make AndroidSmsService own related classes.

This CL makes AndroidSmsService the owner of AndroidSmsAppHelperDelegate
and AndroidSmsPairingStateTracker (previously, objects of these classes
belonged to MultiDeviceSetupService). Upcoming changes require that
these classes be shared among multiple clients, so it is necessary that
they be accessible outside of the service.

As part of this change, I updated AndroidSmsService's constructor to
take other KeyedServices as explicit parameters to make dependencies
clear, and I updated its factory to depend on the other KeyedServices'
factories.

Bug:  918943 ,  876972 
Change-Id: Iee064d97349bccb191533056ceea5cb52984dcba
Reviewed-on: https://chromium-review.googlesource.com/c/1402022
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621800}
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/chromeos/android_sms/android_sms_app_helper_delegate_impl.cc
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/chromeos/android_sms/android_sms_app_helper_delegate_impl.h
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/chromeos/android_sms/android_sms_app_helper_delegate_impl_unittest.cc
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/chromeos/android_sms/android_sms_pairing_state_tracker_impl.cc
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/chromeos/android_sms/android_sms_pairing_state_tracker_impl.h
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/chromeos/android_sms/android_sms_service.cc
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/chromeos/android_sms/android_sms_service.h
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/chromeos/android_sms/android_sms_service_factory.cc
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/chromeos/android_sms/android_sms_urls.cc
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/chromeos/android_sms/android_sms_urls.h
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/ui/webui/settings/chromeos/multidevice_handler.cc
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/ui/webui/settings/chromeos/multidevice_handler.h
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/ui/webui/settings/chromeos/multidevice_handler_unittest.cc
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/android_sms_app_installing_status_observer.cc
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/android_sms_app_installing_status_observer.h
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/android_sms_app_installing_status_observer_unittest.cc
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/feature_state_manager_impl.cc
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/feature_state_manager_impl.h
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/feature_state_manager_impl_unittest.cc
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/multidevice_setup_impl.cc
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/multidevice_setup_impl.h
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/multidevice_setup_impl_unittest.cc
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/multidevice_setup_initializer.cc
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/multidevice_setup_initializer.h
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/multidevice_setup_service.cc
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/multidevice_setup_service.h
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/multidevice_setup_service_unittest.cc
[modify] https://crrev.com/235a38d21ad50442fd4a3362e143aa5bedf89bf3/chromeos/services/multidevice_setup/public/cpp/multidevice_setup_client_impl_unittest.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1a6276ae0adda5618c6e2adae5be9768bdfb9a9

commit e1a6276ae0adda5618c6e2adae5be9768bdfb9a9
Author: Kyle Horimoto <khorimoto@chromium.org>
Date: Fri Jan 11 20:34:23 2019

[CrOS MultiDevice] Show notification when Messages pairing is lost.

Once multi-device setup is completed, the "Messages" PWA is installed,
but further setup is required before the app can be used. Specifically,
the Chromebook needs to be paired with the user's phone via a QR code
displayed in the PWA.

However, this pairing is broken the PWA is migrated from
messages.android.com to messages.google.com (see
https://crbug.com/917855.

This CL alerts the user that the devices need to be re-paired when this
situation arises.

Bug:  918943 
Change-Id: Ib662edf42ba01320cc12e6f3955b80c390d4493e
Reviewed-on: https://chromium-review.googlesource.com/c/1406159
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622126}
[modify] https://crrev.com/e1a6276ae0adda5618c6e2adae5be9768bdfb9a9/ash/public/cpp/vector_icons/BUILD.gn
[add] https://crrev.com/e1a6276ae0adda5618c6e2adae5be9768bdfb9a9/ash/public/cpp/vector_icons/notification_messages.icon
[modify] https://crrev.com/e1a6276ae0adda5618c6e2adae5be9768bdfb9a9/ash/system/message_center/message_center_controller.cc
[modify] https://crrev.com/e1a6276ae0adda5618c6e2adae5be9768bdfb9a9/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/e1a6276ae0adda5618c6e2adae5be9768bdfb9a9/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/e1a6276ae0adda5618c6e2adae5be9768bdfb9a9/chrome/browser/chromeos/android_sms/android_sms_service.cc
[modify] https://crrev.com/e1a6276ae0adda5618c6e2adae5be9768bdfb9a9/chrome/browser/chromeos/android_sms/android_sms_service.h
[modify] https://crrev.com/e1a6276ae0adda5618c6e2adae5be9768bdfb9a9/chrome/browser/chromeos/android_sms/android_sms_service_factory.cc
[modify] https://crrev.com/e1a6276ae0adda5618c6e2adae5be9768bdfb9a9/chrome/browser/chromeos/android_sms/android_sms_service_factory.h
[add] https://crrev.com/e1a6276ae0adda5618c6e2adae5be9768bdfb9a9/chrome/browser/chromeos/android_sms/pairing_lost_notifier.cc
[add] https://crrev.com/e1a6276ae0adda5618c6e2adae5be9768bdfb9a9/chrome/browser/chromeos/android_sms/pairing_lost_notifier.h
[add] https://crrev.com/e1a6276ae0adda5618c6e2adae5be9768bdfb9a9/chrome/browser/chromeos/android_sms/pairing_lost_notifier_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment